From nobody@FreeBSD.org  Wed Jan 25 23:32:05 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B476816A422
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2006 23:32:03 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 81E3F43D45
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2006 23:32:03 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0PNW3vu035186
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2006 23:32:03 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k0PNW37p035185;
	Wed, 25 Jan 2006 23:32:03 GMT
	(envelope-from nobody)
Message-Id: <200601252332.k0PNW37p035185@www.freebsd.org>
Date: Wed, 25 Jan 2006 23:32:03 GMT
From: Donal Fellows <donal.k.fellows@manchester.ac.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Review of FreeBSD Port of Tcl
X-Send-Pr-Version: www-2.3

>Number:         92334
>Category:       ports
>Synopsis:       Review of FreeBSD Port of Tcl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lawrance
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 25 23:40:03 GMT 2006
>Closed-Date:    Sat Apr 29 14:52:19 GMT 2006
>Last-Modified:  Sat Apr 29 14:52:19 GMT 2006
>Originator:     Donal Fellows
>Release:        Not relevant/applicable
>Organization:
University of Manchester /  Tcl Core Team
>Environment:
Not relevant/applicable
>Description:
I have been reviewing the patches to Tcl source files as part of the port of Tcl to FreeBSD (looking at http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/tcl84/files/) and I have some feedback.

 * patch-tclUnixChan.c - it is not really clear what this patch is attempting to do, but it is definitely not doing what its check in comment seems to indicate is attempted. FWIW, Tcl configures all FDs that satisfy the isatty() call as serial channels *except* stdin/stdout/stderr and explicitly /dev/tty (NB not /dev/ttya or anything else that has /dev/tty as a prefix; just the literal). My guess is that this patch can be dropped with no ill effect at all, given that asking around indicates that you don't have a device called "/dev/cua" (/dev/cuaa0 etc. not counting given the logic of that patch).

 * patch-tclUnixInit.c - this patch has been accepted into the Tcl core; it will form part of Tcl 8.4.11

 * patch-tclUnixSock.c - this patch seems to indicate that a better configure test for uname() is necessary, though I don't know what to do exactly there. In any case, I suspect that this patch is fixing things in the wrong place.

 * patch-aa,patch-configure - I've not reviewed these (they're for files that we pretty much expect vendors to adapt anyway)
>How-To-Repeat:
N/A
>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lawrance 
Responsible-Changed-By: lawrance 
Responsible-Changed-When: Sun Apr 16 05:30:23 UTC 2006 
Responsible-Changed-Why:  
I'll handle it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92334 
State-Changed-From-To: open->closed 
State-Changed-By: lawrance 
State-Changed-When: Sat Apr 29 14:48:00 UTC 2006 
State-Changed-Why:  
Thanks very much for the review!  Here are the changes 
I made as a result: 

patch-tclUnixChan.c - I agree that this patch is bogus.  Removed. 

patch-tclUnixInit.c - Patch will remain until the port is updated to 
a version of Tcl which includes the patch.  Thanks for incorporating 
it into your source. 

patch-tclUnixSock.c - This patch was introduced on the premise that 
uname() only returned the first 32 characters of the nodename.  This 
is not the case now, so the patch was removed. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=92334 
>Unformatted:
