From lioux@uol.com.br  Wed Jan 25 15:03:55 2006
Return-Path: <lioux@uol.com.br>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E410416A420
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 25 Jan 2006 15:03:55 +0000 (GMT)
	(envelope-from lioux@uol.com.br)
Received: from vette.gigo.com (vette.gigo.com [216.218.228.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A70B543D49
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 25 Jan 2006 15:03:55 +0000 (GMT)
	(envelope-from lioux@uol.com.br)
Received: from 201.34.193.107 (201-34-193-107.bsace702.dsl.brasiltelecom.net.br [201.34.193.107])
	by vette.gigo.com (Postfix) with ESMTP id 1B7BB5992
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 25 Jan 2006 07:03:53 -0800 (PST)
Received: (qmail 32049 invoked by uid 1001); 25 Jan 2006 13:02:41 -0200
Message-Id: <20060125150304.31953.qmail@exxodus.fedaykin.here>
Date: 25 Jan 2006 13:02:41 -0200
From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
Reply-To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: chuck@pkix.net, pav@FreeBSD.org
Subject: [patch:fix] sysutils/dvd+rw-tools : thread problems: build typo and hard coded build options
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         92315
>Category:       ports
>Synopsis:       [patch:fix] sysutils/dvd+rw-tools : thread problems: build typo and hard coded build options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lioux
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 25 15:10:03 GMT 2006
>Closed-Date:    Mon Mar 27 16:29:46 GMT 2006
>Last-Modified:  Mon Mar 27 16:29:46 GMT 2006
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD exxodus.home.here 6.0-STABLE FreeBSD 6.0-STABLE #8: Fri Jan 20 02:20:43 BRST 2006 lioux@exxodus:/usr/obj-6.x/usr/src-6.x/sys/LIOUX i386

>Description:

o dvd+rw-tools Makefile uses an incorrect compile time macro due
  to a typo. It should be using -D_THREAD_SAFE instead of -DTHREAS_SAFE
o Futhermore, make sure the port upholds PTHREAD_{CFLAGS,LIBS}
o Bump PORTREVISION to make users update
	
>How-To-Repeat:

>Fix:

--- patch-Makefile begins here ---
--- Makefile.orig	Wed Jan 25 09:44:41 2006
+++ Makefile	Wed Jan 25 12:55:27 2006
@@ -6,7 +6,7 @@
 
 PORTNAME=	dvd+rw-tools
 PORTVERSION=	6.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils
 MASTER_SITES=	http://www.pkix.net/mirror/fy.chalmers.se/ \
 		http://fy.chalmers.se/~appro/linux/DVD+RW/tools/
@@ -25,7 +25,12 @@
 PORTDOCS=	index.html
 
 post-patch:
-	${REINPLACE_CMD} -e 's/-O2//' ${WRKSRC}/Makefile.m4
+	${REINPLACE_CMD} \
+		-e 's/-D_THREAS_SAFE/-D_THREAD_SAFE/' \
+		-e 's/-D_THREAD_SAFE/-D_THREAD_SAFE ${PTHREAD_CFLAGS}/' \
+		-e 's/-pthread/${PTHREAD_LIBS}/' \
+		-e 's/-O2//' \
+		${WRKSRC}/Makefile.m4
 
 do-install:
 .for i in ${BIN_FILES}
--- patch-Makefile ends here ---


>Release-Note:
>Audit-Trail:
Adding to audit trail from misfiled PR ports/92321:

Date: Wed, 25 Jan 2006 12:41:37 -0500
From: Chuck Swiger <chuck@pkix.net>

 Hi, all--
 
 On Jan 25, 2006, at 10:02 AM, Mario Sergio Fujikawa Ferreira wrote:
 > [ ... ]
 
 Although I won't have time to test this change until later today,  
 thanks for the fix, and I'm willing to approve it.  ports/91874 did  
 in fact need more testing for FreeBSD 4...
 
 -- 
 -Chuck
State-Changed-From-To: open->feedback 
State-Changed-By: mnag 
State-Changed-When: Sat Feb 18 21:35:32 UTC 2006 
State-Changed-Why:  
Ask for maintainer approval. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92315 
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Sun Mar 26 21:39:58 UTC 2006 
State-Changed-Why:  
Maintainer approved 


Responsible-Changed-From-To: freebsd-ports-bugs->lioux 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sun Mar 26 21:39:58 UTC 2006 
Responsible-Changed-Why:  
Submitter is committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92315 
State-Changed-From-To: open->closed 
State-Changed-By: lioux 
State-Changed-When: Mon Mar 27 16:29:45 UTC 2006 
State-Changed-Why:  
Fix committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92315 
>Unformatted:
