From roderick@developer.nedforce.nl  Fri Jan 20 19:10:23 2006
Return-Path: <roderick@developer.nedforce.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D172E16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2006 19:10:23 +0000 (GMT)
	(envelope-from roderick@developer.nedforce.nl)
Received: from developer.nedforce.nl (82-168-201-247.dsl.ip.tiscali.nl [82.168.201.247])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1DA0343D46
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2006 19:10:20 +0000 (GMT)
	(envelope-from roderick@developer.nedforce.nl)
Received: from developer.nedforce.nl (localhost.nedforce.nl [127.0.0.1])
	by developer.nedforce.nl (8.13.4/8.13.4) with ESMTP id k0KIA453082722
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2006 19:10:04 +0100 (CET)
	(envelope-from roderick@developer.nedforce.nl)
Received: (from root@localhost)
	by developer.nedforce.nl (8.13.4/8.13.4/Submit) id k0KIA4NW082721;
	Fri, 20 Jan 2006 19:10:04 +0100 (CET)
	(envelope-from roderick)
Message-Id: <200601201810.k0KIA4NW082721@developer.nedforce.nl>
Date: Fri, 20 Jan 2006 19:10:04 +0100 (CET)
From: Roderick van Domburg <roderick@developer.nedforce.nl>
Reply-To: Roderick van Domburg <roderick@developer.nedforce.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: databases/rubygem-activerecord: MySQL options & portlint(1) cleanup
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jw@innerewut.de

>Number:         92072
>Category:       ports
>Synopsis:       databases/rubygem-activerecord: MySQL options & portlint(1) cleanup
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    vd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 20 19:20:03 GMT 2006
>Closed-Date:    Mon Jan 23 16:48:55 GMT 2006
>Last-Modified:  Mon Jan 23 16:48:55 GMT 2006
>Originator:     Roderick van Domburg
>Release:        FreeBSD 6.0-STABLE sparc64
>Organization:
University of Twente
>Environment:
System: FreeBSD developer.nedforce.nl 6.0-STABLE FreeBSD 6.0-STABLE #1: Thu Jan 12 10:47:03 CET 2006 roderick@developer.nedforce.nl:/usr/obj/usr/src/sys/DEVELOPER sparc64


	
>Description:
This patch adds a nifty options screen so that users can pull in the native
MySQL bindings. These bindings increase Rails' database performance by a
said 10-15%.

I turned the option off by default, to prevent annoyances for non-MySQL
users. While I was here, I fixed several portlint(1) warnings as well.
	
>How-To-Repeat:
	
>Fix:

	

--- patch-rubygem-activerecord-mysql begins here ---
diff -ruN rubygem-activerecord.bak/Makefile rubygem-activerecord/Makefile
--- rubygem-activerecord.bak/Makefile	Fri Jan 20 18:29:48 2006
+++ rubygem-activerecord/Makefile	Fri Jan 20 19:02:56 2006
@@ -6,17 +6,27 @@
 
 PORTNAME=	activerecord
 PORTVERSION=	1.13.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases ruby
+MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/
 
 MAINTAINER=	jw@innerewut.de
 COMMENT=	Object-relational mapping layer for Rails MVC Framework
 
-MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/
-
 BUILD_DEPENDS=	${LOCALBASE}/${SPEC_DIR}/activesupport-1.2.5.gemspec:${PORTSDIR}/devel/rubygem-activesupport
 RUN_DEPENDS=	${BUILD_DEPENDS}
 
+OPTIONS=	NATIVE_MYSQL "Use native MySQL bindings (faster)" Off
+OPTIONSFILE=	${PORT_DBDIR}/rubygem-${PORTNAME}/options
+
+# to get RUBY_SITEARCHLIBDIR
+USE_RUBY=	yes
+
 .include <bsd.port.pre.mk>
+
+.if defined(WITH_NATIVE_MYSQL)
+RUN_DEPENDS+=	${RUBY_SITEARCHLIBDIR}/mysql.so:${PORTSDIR}/databases/ruby-mysql
+.endif
+
 .include "${PORTSDIR}/devel/ruby-gems/Makefile.common"
 .include <bsd.port.post.mk>
--- patch-rubygem-activerecord-mysql ends here ---


>Release-Note:
>Audit-Trail:

From: Roderick van Domburg <r.s.a.vandomburg@student.utwente.nl>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/92072: databases/rubygem-activerecord: MySQL options &
 portlint(1) cleanup
Date: Fri, 20 Jan 2006 20:29:19 +0100

 Reply-To should be r.s.a.vandomburg@student.utwente.nl.
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jan 20 21:31:31 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92072 

From: Jonathan Weiss <jw@innerewut.de>
To: bug-followup@FreeBSD.org,  roderick@developer.nedforce.nl, 
 edwin@FreeBSD.org
Cc:  
Subject: Re: ports/92072: databases/rubygem-activerecord: MySQL options &
 portlint(1) cleanup
Date: Sun, 22 Jan 2006 14:07:37 +0100

 Cheers,
 
 
 The patch looks ok, I've updated it to include support for PostgreSQL 
 and SQLite3 bindings:
 
 
 -------------------------------------
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/databases/rubygem-activerecord/Makefile,v
 retrieving revision 1.5
 diff -u -r1.5 Makefile
 --- Makefile	21 Jan 2006 20:25:05 -0000	1.5
 +++ Makefile	22 Jan 2006 11:20:03 -0000
 @@ -6,17 +6,37 @@
 
   PORTNAME=	activerecord
   PORTVERSION=	1.13.2
 -PORTREVISION=	1
 +PORTREVISION=	2
   CATEGORIES=	databases rubygems
 +MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/
 
   MAINTAINER=	jw@innerewut.de
   COMMENT=	Object-relational mapping layer for Rails MVC Framework
 
 -MASTER_SITES=	http://rubyforge.org/frs/download.php/7641/
 -
   BUILD_DEPENDS= 
 ${LOCALBASE}/${SPEC_DIR}/activesupport-1.2.5.gemspec:${PORTSDIR}/devel/rubygem-activesupport
   RUN_DEPENDS=	${BUILD_DEPENDS}
 
 +OPTIONS=	NATIVE_MYSQL "Use native MySQL bindings" Off\
 +		NATIVE_POSTGRESQL "Use native PostgreSQL bindings" Off\
 +		NATIVE_SQLITE3 "Use native SQLite3 bindings" Off
 +OPTIONSFILE=	${PORT_DBDIR}/rubygem-${PORTNAME}/options
 +
 +# to get RUBY_SITEARCHLIBDIR
 +USE_RUBY=	yes
 +
   .include <bsd.port.pre.mk>
 +
 +.if defined(WITH_NATIVE_MYSQL)
 +RUN_DEPENDS+= 
 ${RUBY_SITEARCHLIBDIR}/mysql.so:${PORTSDIR}/databases/ruby-mysql
 +.endif
 +
 +.if defined(WITH_NATIVE_POSTGRESQL)
 +RUN_DEPENDS+= 
 ${RUBY_SITEARCHLIBDIR}/postgres.so:${PORTSDIR}/databases/ruby-postgres
 +.endif
 +
 +.if defined(WITH_NATIVE_SQLITE3)
 +RUN_DEPENDS+= 
 ${RUBY_SITEARCHLIBDIR}/sqlite3_api.so:${PORTSDIR}/databases/ruby-sqlite3
 +.endif
 +
   .include "${PORTSDIR}/devel/ruby-gems/Makefile.common"
   .include <bsd.port.post.mk>
 -------------------------------------
 
 
 Regards,
 Jonathan
 -- 
 Jonathan Weiss
 http://blog.innerewut.de
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Sun Jan 22 20:37:58 UTC 2006 
State-Changed-Why:  
maintainer approved with additional patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92072 
Responsible-Changed-From-To: freebsd-ports-bugs->vd 
Responsible-Changed-By: vd 
Responsible-Changed-When: Mon Jan 23 14:54:50 UTC 2006 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92072 
State-Changed-From-To: open->closed 
State-Changed-By: vd 
State-Changed-When: Mon Jan 23 16:42:04 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=92072 
>Unformatted:
