From josh@tcbug.org  Wed Jan 18 16:09:17 2006
Return-Path: <josh@tcbug.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4419316A443
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jan 2006 16:09:17 +0000 (GMT)
	(envelope-from josh@tcbug.org)
Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D42BA43D58
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jan 2006 16:09:16 +0000 (GMT)
	(envelope-from josh@tcbug.org)
Received: from gimpy.tcbug.org (c-24-118-173-219.hsd1.mn.comcast.net[24.118.173.219])
          by comcast.net (sccrmhc13) with SMTP
          id <2006011816033901300o8bhde>; Wed, 18 Jan 2006 16:03:39 +0000
Message-Id: <1137600212.48622@gimpy.tcbug.org>
Date: Wed, 18 Jan 2006 10:03:32 -0600
From: "Josh Paetzel" <Josh Paetzel <josh@tcbug.org>>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [patch]  Fix missing dependancy in www/cadaver
X-Send-Pr-Version: gtk-send-pr 0.4.7 
X-GNATS-Notify: josh@tcbug.org

>Number:         91962
>Category:       ports
>Synopsis:       [patch]  Fix missing dependancy in www/cadaver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    vd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 18 16:10:07 GMT 2006
>Closed-Date:    Tue Feb 07 17:23:38 GMT 2006
>Last-Modified:  Tue Feb 07 17:23:38 GMT 2006
>Originator:     Josh Paetzel
>Release:        FreeBSD 6.0-RELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.0-RELEASE #0: Thu Nov  3 09:36:13 UTC 2005
    root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC



>Description:


www/cadaver/Makefile is missing the gettext dependancy...installing cadaver without having devel/gettext installed previously fails.


>How-To-Repeat:


Make sure deve/gettext isn't installed and try installing www/cadaver


>Fix:


Apply the following patch to www/cadaver/Makefile

$ cat Makefile.diff
--- Makefile.old        Wed Jan 18 09:46:56 2006
+++ Makefile    Wed Jan 18 09:47:10 2006
@@ -19,6 +19,7 @@
 LIB_DEPENDS=   neon.25:${PORTSDIR}/www/neon

 USE_GPG?=      yes
+USE_GETTEXT=   yes
 SIG_FILES=     ${DISTNAME}${EXTRACT_SUFX}.asc
 USE_GETOPT_LONG=       yes
 GNU_CONFIGURE= yes


>Release-Note:
>Audit-Trail:
Class-Changed-From-To: maintainer-update->change-request 
Class-Changed-By: edwin 
Class-Changed-When: Wed Jan 18 21:44:02 UTC 2006 
Class-Changed-Why:  
Fix category (submitter is not maintainer) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jan 18 21:44:10 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 

From: Josh Paetzel <josh@tcbug.org>
To: bug-followup@freebsd.org,
 edwin@freebsd.org
Cc:  
Subject: Re: ports/91962: [patch]  Fix missing dependancy in www/cadaver
Date: Wed, 18 Jan 2006 21:11:44 -0600

 On Wednesday 18 January 2006 15:44, Edwin Groothuis wrote:
 > Maintainer of www/cadaver,
 >
 > Please note that PR ports/91962 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the
 > patch and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/91962
 
 Yes, I agree to this patch (I'm the one who submitted it)
 
 >Class-Changed-From-To: maintainer-update->change-request 
 >Class-Changed-By: edwin 
 >Class-Changed-When: Wed Jan 18 21:44:02 UTC 2006 
 >Class-Changed-Why:  
 >Fix category (submitter is not maintainer) 
 
 I am the maintainer.
 
 -- 
 Thanks,
 
 Josh Paetzel
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 19 05:49:53 UTC 2006 
State-Changed-Why:  
Submitter is maintainer (please use correct email address next time 
to speed up the process) 


Class-Changed-From-To: change-request->maintainer-update 
Class-Changed-By: edwin 
Class-Changed-When: Thu Jan 19 05:49:53 UTC 2006 
Class-Changed-Why:  
From: ""Josh Paetzel" <Josh Paetzel" <josh@tcbug.org> 

^^^--- that's what it went wrong on. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 19 11:27:26 UTC 2006 
State-Changed-Why:  
Leftover files: 

-r--r--r-- 1 root  wheel  13745 Jan 19 11:25 usr/local/share/locale/es/LC_MESSAGES/cadaver.mo 
-r--r--r-- 1 root  wheel  13885 Jan 19 11:25 usr/local/share/locale/it/LC_MESSAGES/cadaver.mo 
-r--r--r-- 1 root  wheel  26663 Jan 19 11:25 usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo 

Are you sure that en@quot is a proper line? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 

From: Josh Paetzel <josh@tcbug.org>
To: Edwin Groothuis <edwin@freebsd.org>
Cc:  
Subject: Re: ports/91962: [patch]  Fix missing dependancy in www/cadaver
Date: Thu, 19 Jan 2006 20:20:28 -0600

 On Thursday 19 January 2006 05:28, you wrote:
 > Synopsis: [patch]  Fix missing dependancy in www/cadaver
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: edwin
 > State-Changed-When: Thu Jan 19 11:27:26 UTC 2006
 > State-Changed-Why:
 > Leftover files:
 >
 > -r--r--r-- 1 root  wheel  13745 Jan 19 11:25
 > usr/local/share/locale/es/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
 > wheel  13885 Jan 19 11:25
 > usr/local/share/locale/it/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
 > wheel  26663 Jan 19 11:25
 > usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo
 >
 > Are you sure that en@quot is a proper line?
 >
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=91962
 
 I think I'm a tad confused.  If I reply to the mail you sent me it 
 goes to  freebsd-ports-bugs@FreeBSD.org
 
 If I submit a followup to the PR it points to bug-followup@freebsd.org
 
 Which of the two would be appropriate?
 
 In the meantime kris@ has marked the port as broken.  (Yes, I've taken 
 took much time to deal with this)  Should I modify the patch to 
 remove the BROKEN tag or is that worthy of a different PR?  Thanks 
 for your patience and help, I'm slowly but surely getting up to speed 
 on this port maintainer thing. :)
 
 -- 
 Thanks,
 
 Josh Paetzel
 

From: Edwin Groothuis <edwin@mavetju.org>
To: Josh Paetzel <josh@tcbug.org>
Cc: FreeBSD Gnats Submit <freebsd-gnats-submit@freebsd.org>
Subject: Re: ports/91962: [patch]  Fix missing dependancy in www/cadaver
Date: Fri, 20 Jan 2006 13:30:30 +1100

 On Thu, Jan 19, 2006 at 08:20:28PM -0600, Josh Paetzel wrote:
 > Which of the two would be appropriate?
 
 ports-bugs-followup it more appropriate.
 
 > In the meantime kris@ has marked the port as broken.  (Yes, I've taken 
 > took much time to deal with this)  Should I modify the patch to 
 > remove the BROKEN tag or is that worthy of a different PR?  Thanks 
 > for your patience and help, I'm slowly but surely getting up to speed 
 > on this port maintainer thing. :)
 
 If you say that the file directory "en@quote" is correct then I'll
 submit the fixes, and remove the BROKEN line.
 
 Edwin
 -- 
 Edwin Groothuis      |            Personal website: http://www.mavetju.org
 edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/

From: Josh Paetzel <josh@tcbug.org>
To: Edwin Groothuis <edwin@freebsd.org>
Cc:  
Subject: Re: ports/91962: [patch]  Fix missing dependancy in www/cadaver
Date: Thu, 26 Jan 2006 09:59:21 -0600

 --Boundary-00=_ZHP2Dhttu7pvNmo
 Content-Type: text/plain;
   charset="iso-8859-6"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Thursday 19 January 2006 05:28, you wrote:
 > Synopsis: [patch]  Fix missing dependancy in www/cadaver
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: edwin
 > State-Changed-When: Thu Jan 19 11:27:26 UTC 2006
 > State-Changed-Why:
 > Leftover files:
 >
 > -r--r--r-- 1 root  wheel  13745 Jan 19 11:25
 > usr/local/share/locale/es/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
 > wheel  13885 Jan 19 11:25
 > usr/local/share/locale/it/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
 > wheel  26663 Jan 19 11:25
 > usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo
 >
 > Are you sure that en@quot is a proper line?
 >
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=91962
 
 Here's the patch that will get cadaver working again.  
 
 -- 
 Thanks,
 
 Josh Paetzel
 
 --Boundary-00=_ZHP2Dhttu7pvNmo
 Content-Type: text/x-diff;
   charset="iso-8859-6";
   name="Makefile.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="Makefile.diff"
 
 --- Makefile.old	Thu Jan 26 09:46:26 2006
 +++ Makefile	Thu Jan 26 09:48:20 2006
 @@ -18,9 +18,8 @@
  
  LIB_DEPENDS=	neon.25:${PORTSDIR}/www/neon
  
 -BROKEN=		Does not compile
 -
  USE_GPG?=	yes
 +USE_GETTEXT=	yes
  SIG_FILES=	${DISTNAME}${EXTRACT_SUFX}.asc
  USE_GETOPT_LONG=	yes
  GNU_CONFIGURE=	yes
 
 --Boundary-00=_ZHP2Dhttu7pvNmo--
 
Responsible-Changed-From-To: freebsd-ports-bugs->vd 
Responsible-Changed-By: vd 
Responsible-Changed-When: Tue Feb 7 15:19:24 UTC 2006 
Responsible-Changed-Why:  
I will take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 
State-Changed-From-To: feedback->closed 
State-Changed-By: vd 
State-Changed-When: Tue Feb 7 17:16:45 UTC 2006 
State-Changed-Why:  
Patch in ports/91756 which includes these changes has been committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91962 
>Unformatted:
