From vd@datamax.bg  Wed Jan 18 09:46:22 2006
Return-Path: <vd@datamax.bg>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 09F5816A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jan 2006 09:46:22 +0000 (GMT)
	(envelope-from vd@datamax.bg)
Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BC3DC43E06
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Jan 2006 09:45:18 +0000 (GMT)
	(envelope-from vd@datamax.bg)
Received: from qlovarnika.bg.datamax (qlovarnika.bg.datamax [192.168.10.2])
	by jengal.datamax.bg (Postfix) with SMTP id 0B651B832;
	Wed, 18 Jan 2006 11:45:06 +0200 (EET)
Received: (nullmailer pid 1811 invoked by uid 1002);
	Wed, 18 Jan 2006 09:45:06 -0000
Message-Id: <20060118094505.GA1779@qlovarnika.bg.datamax>
Date: Wed, 18 Jan 2006 11:45:06 +0200
From: Vasil Dimov <vd@datamax.bg>
Reply-To: vd@datamax.bg
To: FreeBSD-gnats-submit@freebsd.org
Cc: edwin@mavetju.org
Subject: [patch] misc/tinderbox shouldn't allow no database to be selected
X-Send-Pr-Version: 3.113

>Number:         91943
>Category:       ports
>Synopsis:       [patch] misc/tinderbox shouldn't allow no database to be selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    edwin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 18 09:50:02 GMT 2006
>Closed-Date:    Wed Jan 18 10:29:40 GMT 2006
>Last-Modified:  Wed Jan 18 11:50:44 GMT 2006
>Originator:     Vasil Dimov
>Release:        FreeBSD 6.0-STABLE amd64
>Organization:
DataMax
>Environment:

>Description:

As tinderbox is useless without a database the port should force (at
least) one to be selected in the `make config' step.

>How-To-Repeat:

>Fix:

--- tinderbox_db.diff begins here ---
Index: Makefile
===================================================================
RCS file: /usr/local/cvsupdroot/ports/misc/tinderbox/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	3 Jan 2006 00:00:47 -0000	1.5
+++ Makefile	18 Jan 2006 09:34:47 -0000
@@ -29,6 +29,10 @@
 
 .include <bsd.port.pre.mk>
 
+.if !defined(WITH_PGSQL) && !defined(WITH_MYSQL)
+BROKEN=	"Tinderbox is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL"
+.endif
+
 .if defined(WITH_PGSQL)
 USE_PGSQL=	yes
 USE_PHP+=	pgsql
--- tinderbox_db.diff ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Wed Jan 18 10:29:36 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91943 
Responsible-Changed-From-To: freebsd-ports-bugs->edwin 
Responsible-Changed-By: sem 
Responsible-Changed-When: Wed Jan 18 11:50:42 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91943 
>Unformatted:
