From dougb@FreeBSD.org  Sat Jan 14 07:09:52 2006
Return-Path: <dougb@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAA8316A420
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jan 2006 07:09:52 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12])
	by mx1.FreeBSD.org (Postfix) with SMTP id CB31C43D58
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jan 2006 07:09:51 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 88358 invoked by uid 399); 14 Jan 2006 07:09:50 -0000
Received: from localhost (HELO ?192.168.1.101?) (dougb@dougbarton.us@127.0.0.1)
  by localhost with SMTP; 14 Jan 2006 07:09:50 -0000
Message-Id: <43C8A3BC.1070108@FreeBSD.org>
Date: Fri, 13 Jan 2006 23:09:48 -0800
From: Doug Barton <dougb@FreeBSD.org>
To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com>
Cc: Mike Jakubik <mikej@rogers.com>, 
 FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>,
  ports@freebsd.org
In-Reply-To: <20060113020125.5c1317a1@it.buh.tecnik93.com>
Subject: Re: [PATCH] security/courier-authlib-base: update rc.d script to
 REQUIRE mysql_client
References: <1137031540.61580@it.buh.tecnik93.com>	<43C6EAE9.5070901@rogers.com> <20060113020125.5c1317a1@it.buh.tecnik93.com>

>Number:         91784
>Category:       ports
>Synopsis:       Re: [PATCH] security/courier-authlib-base: update rc.d script to
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 14 07:20:03 GMT 2006
>Closed-Date:    Sat Jan 14 08:46:14 GMT 2006
>Last-Modified:  Sat Jan 14 08:46:14 GMT 2006
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 Ion-Mihai Tetcu wrote:
 > On Thu, 12 Jan 2006 18:48:57 -0500
 > Mike Jakubik <mikej@rogers.com> wrote:
 
 >> I think the real solution would be to generate the required services 
 >> dynamically based on what the port is compiled with. This obviously 
 >> means some more work, but i think a lot of port maintainers will have
 >> to go through this, to properly utilize RCng. Examples can be
 >> apparently taken from the misc/compat5 port.
 > 
 > Or my mail/dspam-devel.
 
 You definitely have some cool stuff in there! I would like to mention one 
 little nit, that I was actually reminded of myself recently. When you do 
 default variable values, it's better to do it like this:
 
 dspam_enable=${dspam_enable-"NO"}
 
 rather than with the colon. That way if the user has done this in 
 /etc/rc.conf:  dspam_enable="" the default will still be no (since - 
 replaces the value only if it's unset, whereas :- replaces if it is unset OR 
 null). This isn't too meaningful for things like _enable where either result 
 would have basically the same effect, but it is meaningful for things like 
 _flags, where in your script, if the user did dspam_flags="" they would 
 unexpectedly have nothing replaced with your default.
 
 hth,
 
 Doug
 
 -- 
 
      This .signature sanitized for your protection
 
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 14 08:43:46 UTC 2006 
State-Changed-Why:  
Misfiled followup to ports/91698; content migrated. 

At this point I kind of hope the posters will get the hint and start 
following up to the message that has "Re: ports/91698: " in the Subject. 


Responsible-Changed-From-To: gnats-admin->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jan 14 08:43:46 UTC 2006 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=91784 
>Unformatted:
  REQUIRE mysql_client
