From paul@lugnut.aps.org  Sun Jan  8 19:52:54 2006
Return-Path: <paul@lugnut.aps.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A929816A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jan 2006 19:52:54 +0000 (GMT)
	(envelope-from paul@lugnut.aps.org)
Received: from lugnut.aps.org (lugnut.aps.org [149.28.3.100])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 41AB043D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jan 2006 19:52:54 +0000 (GMT)
	(envelope-from paul@lugnut.aps.org)
Received: from lugnut.aps.org (localhost [127.0.0.1])
	by lugnut.aps.org (8.13.4/8.13.4) with ESMTP id k08JqpBm055512;
	Sun, 8 Jan 2006 14:52:51 -0500 (EST)
	(envelope-from paul@lugnut.aps.org)
Received: (from root@localhost)
	by lugnut.aps.org (8.13.4/8.13.1/Submit) id k08JqmGi055511;
	Sun, 8 Jan 2006 14:52:48 -0500 (EST)
	(envelope-from paul)
Message-Id: <200601081952.k08JqmGi055511@lugnut.aps.org>
Date: Sun, 8 Jan 2006 14:52:48 -0500 (EST)
From: Paul Dlug <paul@aps.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: pgollucci@p6m7g8.com
Subject: [PATCH] Fix www/p5-Apache-DBI so that it works with www/apache22
X-Send-Pr-Version: 3.113
X-GNATS-Notify: pgollucci@p6m7g8.com

>Number:         91526
>Category:       ports
>Synopsis:       [PATCH] Fix www/p5-Apache-DBI so that it works with www/apache22
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    vd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 08 20:00:16 GMT 2006
>Closed-Date:    Tue Jan 24 09:42:08 GMT 2006
>Last-Modified:  Tue Jan 24 09:42:08 GMT 2006
>Originator:     Paul Dlug
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD lugnut.aps.org 6.0-STABLE FreeBSD 6.0-STABLE #8: Mon Jan  2 14:35:30 EST
>Description:
When www/apache22 and www/mod_perl2 are installed www/p5-Apache-DBI will not install. This is
because it explicitly looks for PREFIX/libexec/apache2/mod_perl.so when WITH_MODPERL2 is
defined. With www/apache22 the path is PREFIX/libexec/apache22/mod_perl.so My submitted patch
dynamically looks up the libexec path for apache modules with a call to apxs, it falls back
to the hardcoded path. This approach is used successfully by other modules (see 
www/mod_auth_kerb or www/p5-CGI-SpeedyCGI for example).

Port maintainer (pgollucci@p6m7g8.com) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

begin 644 p5-Apache-DBI-0.98.patch
`
end

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jan 8 20:04:12 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 

From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it works with
 www/apache22
Date: Sun, 08 Jan 2006 18:14:31 -0500

 Edwin Groothuis wrote:
 > Maintainer of www/p5-Apache-DBI,
 > 
 > Please note that PR ports/91526 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/91526
 > 
 Approved -- I agree with the concept, but am unable to view the patch ????
 
 Also,
 
 Now that CPAN has fixed it's indexing for this module, we can switch 
 back to it :)
 
 MASTER_SITES=   ${MASTER_SITE_PERL_CPAN}
 MASTER_SITE_SUBDIR= Apache
 
 instead of pulling it from Apache.
 
 HTH
 
 
 -- 
 ------------------------------------------------------------------------
 "Love is not the one you can picture yourself marrying,
 but the one you can't picture the rest of your life without."
 
 "It takes a minute to have a crush on someone, an hour to like someone,
 and a day to love someone, but it takes a lifetime to forget someone..."
 
 "I wanna hold ya till I die ... I wanna hold ya till the fear in me 
 subsides."
 
 Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
 Consultant / http://p6m7g8.net/Resume/resume.shtml
 Senior Software Engineer - TicketMaster - http://ticketmaster.com
 1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Mon Jan 9 00:54:42 UTC 2006 
State-Changed-Why:  
Maintainer approves 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jan 9 00:56:17 UTC 2006 
State-Changed-Why:  
Paul,  

The patch is missing, can you resupply it? 

Edwin 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 

From: Paul Dlug <paul@aps.org>
To: bug-followup@FreeBSD.org, Paul Dlug <paul@aps.org>
Cc:  
Subject: Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it works with www/apache22
Date: Sun, 8 Jan 2006 21:10:36 -0500

 --Apple-Mail-4--448353254
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=US-ASCII;
 	delsp=yes;
 	format=flowed
 
 Sorry about that, not sure how I left that off. The diff is attached.  
 It includes the modification of the MASTER_SITES as well as an  
 upgrade to 0.9901 (0.98 is not available on CPAN so the upgrade was  
 necessary to modify MASTER_SITES as well as to provide the new,  
 improved version).
 
 
 --Apple-Mail-4--448353254
 Content-Transfer-Encoding: 7bit
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="apache_dbi.diff"
 Content-Disposition: attachment;
 	filename=apache_dbi.diff
 
 diff -ruN --exclude=CVS /usr/ports/www/p5-Apache-DBI/Makefile /usr/home/paul/myports/www/p5-Apache-DBI/Makefile
 --- /usr/ports/www/p5-Apache-DBI/Makefile	Wed Jan  4 04:18:05 2006
 +++ /usr/home/paul/myports/www/p5-Apache-DBI/Makefile	Sun Jan  8 21:06:56 2006
 @@ -6,26 +6,34 @@
  #
  
  PORTNAME=	Apache-DBI
 -PORTVERSION=	0.98
 +PORTVERSION=	0.9901
  CATEGORIES=	www databases perl5
 -MASTER_SITES=	http://people.apache.org/~pgollucci/CPAN/Apache-DBI/
 +MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
 +MASTER_SITE_SUBDIR=	Apache
 +
  PKGNAMEPREFIX=	p5-
  
  MAINTAINER=	pgollucci@p6m7g8.com
  COMMENT=	DBI persistent connection, authentication and authorization
  
 +MAN3=		Apache::DBI.3 Apache::AuthDBI.3
 +
 +PERL_CONFIGURE=	yes
 +USE_APACHE=	yes
 +
 +.include <bsd.port.pre.mk>
 +
  .if defined(WITH_MODPERL2)
 -RUN_DEPENDS+=	${LOCALBASE}/libexec/apache2/mod_perl.so:${PORTSDIR}/www/mod_perl2
 +.if exists(${APXS})
 +APACHE_MODULE_DIR!=${APXS} -q LIBEXECDIR
 +.else
 +APACHE_MODULE_DIR?=${PREFIX}/libexec/apache2
 +.endif
 +RUN_DEPENDS+=	${APACHE_MODULE_DIR}/mod_perl.so:${PORTSDIR}/www/mod_perl2
  .else
  RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/mod_perl.pm:${PORTSDIR}/www/mod_perl
  .endif
  BUILD_DEPENDS=	${RUN_DEPENDS}
 -
 -PERL_CONFIGURE=	yes
 -
 -MAN3=		Apache::DBI.3 Apache::AuthDBI.3
 -
 -.include <bsd.port.pre.mk>
  
  .if ${PERL_LEVEL} < 500800
  BUILD_DEPENDS+=	${SITE_PERL}/Test/More.pm:${PORTSDIR}/devel/p5-Test-Simple
 diff -ruN --exclude=CVS /usr/ports/www/p5-Apache-DBI/distinfo /usr/home/paul/myports/www/p5-Apache-DBI/distinfo
 --- /usr/ports/www/p5-Apache-DBI/distinfo	Wed Jan  4 04:18:05 2006
 +++ /usr/home/paul/myports/www/p5-Apache-DBI/distinfo	Sun Jan  8 21:08:33 2006
 @@ -1,2 +1,3 @@
 -MD5 (Apache-DBI-0.98.tar.gz) = 2b351ba7bafc2d5add23f1e76f99b90c
 -SIZE (Apache-DBI-0.98.tar.gz) = 30642
 +MD5 (Apache-DBI-0.9901.tar.gz) = 3651690e9d25b6634b9e5f554afa7f5e
 +SHA256 (Apache-DBI-0.9901.tar.gz) = db4aa7d8a8b0ef2d996c4f827129becdb3464939667d199f24199aec308da311
 +SIZE (Apache-DBI-0.9901.tar.gz) = 31786
 
 --Apple-Mail-4--448353254--
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Mon Jan 9 05:52:21 UTC 2006 
State-Changed-Why:  
Patch recieived 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 

From: Paul Dlug <paul@aps.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it works with www/apache22
Date: Mon, 16 Jan 2006 22:35:06 -0500

 I'm not sure why the last few email's I sent failed to update the  
 case but here it goes again.
 
 The maintainer has approved this patch (as per the email below),  
 please commit.
 
 
 Thanks,
 Paul
 
 
 > From: 	  pgollucci@p6m7g8.com
 > Subject: 	Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it  
 > works with www/apache22
 > Date: 	January 12, 2006 9:29:02 PM EST
 > To: 	  paul@aps.org
 >
 > Paul Dlug wrote:
 >
 >> I was just wondering if you had a chance to review this patch, it  
 >> would be helpful to get it committed.
 >>
 > I thought I already had ?
 >
 > Committ away... FYI, I'm going to roll Apache-DBI 1.0 towars the  
 > start of February on CPAN..
 >

From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: bug-followup@FreeBSD.org, paul@aps.org
Cc:  
Subject: Re: ports/91526: [PATCH] Fix www/p5-Apache-DBI so that it works with
 www/apache22
Date: Wed, 18 Jan 2006 23:18:04 -0500

 files/patch-mp2-api
 
 is no longer needed.
 
 Also, this PR will fix PR 89387 so please close that one and commit this 
 one.
Class-Changed-From-To: update->maintainer-update 
Class-Changed-By: linimon 
Class-Changed-When: Thu Jan 19 06:03:40 UTC 2006 
Class-Changed-Why:  
Fix class. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 
Responsible-Changed-From-To: freebsd-ports-bugs->vd 
Responsible-Changed-By: vd 
Responsible-Changed-When: Mon Jan 23 18:23:11 UTC 2006 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 
State-Changed-From-To: open->closed 
State-Changed-By: vd 
State-Changed-When: Tue Jan 24 09:41:36 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91526 
>Unformatted:
