From infofarmer@gmail.com  Sun Jan  8 18:30:51 2006
Return-Path: <infofarmer@gmail.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A715716A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jan 2006 18:30:51 +0000 (GMT)
	(envelope-from infofarmer@gmail.com)
Received: from uproxy.gmail.com (uproxy.gmail.com [66.249.92.195])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E16E443D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  8 Jan 2006 18:30:50 +0000 (GMT)
	(envelope-from infofarmer@gmail.com)
Received: by uproxy.gmail.com with SMTP id o2so446593uge
        for <FreeBSD-gnats-submit@freebsd.org>; Sun, 08 Jan 2006 10:30:49 -0800 (PST)
Received: by 10.66.242.9 with SMTP id p9mr893294ugh;
        Sun, 08 Jan 2006 10:30:48 -0800 (PST)
Received: from localhost ( [83.237.13.127])
        by mx.gmail.com with ESMTP id a1sm1618663ugf.2006.01.08.10.30.47;
        Sun, 08 Jan 2006 10:30:48 -0800 (PST)
Message-Id: <43c15a58.5be4e545.2f8e.70b4@mx.gmail.com>
Date: Sun, 08 Jan 2006 10:30:48 -0800 (PST)
From: infofarmer@gmail.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: update multimedia/audacious
X-Send-Pr-Version: 3.113
X-GNATS-Notify: redchrom@gmail.com

>Number:         91521
>Category:       ports
>Synopsis:       update multimedia/audacious
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    novel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 08 18:40:02 GMT 2006
>Closed-Date:    Tue Jan 17 05:59:06 GMT 2006
>Last-Modified:  Tue Jan 17 05:59:06 GMT 2006
>Originator:     Andrew Pantyukhin
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD sat64.net17 6.0-STABLE FreeBSD 6.0-STABLE #2: Sat Dec 31 02:36:56 MSK 2005 sat@sat64.net17:/usr/obj/usr/src/sys/SATCUR32 i386


	
>Description:
Add modplug knob. Bump portrevision at will. Also, using PLIST_SUB
to add a single file is ugly, use PLIST_FILES instead.
	
>How-To-Repeat:
	
>Fix:

	

--- audacious.diff begins here ---
diff -urN /usr/ports/multimedia/audacious/Makefile audacious/Makefile
--- /usr/ports/multimedia/audacious/Makefile	Sat Jan  7 02:47:05 2006
+++ audacious/Makefile	Sun Jan  8 21:26:27 2006
@@ -42,6 +42,7 @@
 
 OPTIONS=	VORBIS	"Enable Ogg Vorbis input" on \
 		FLAC	"Enable flac input" on \
+		MODPLUG	"Enable modplug input" on \
 		ESOUND	"Enable Esound output"  off \
 		VISUAL  "Enable libvisual plugin" off \
 		ID3V2	"Enable id3v2 editing" off \
@@ -71,6 +72,14 @@
 .else
 PLIST_SUB+=	FLACPLUGIN:="@comment "
 CONFIGURE_ARGS+=	--disable-flac
+.endif
+
+.if !defined(WITHOUT_MODPLUG)
+INPUT_PLUGINS+=	modplug
+PLIST_FILES+=	lib/audacious/Input/libmodplug.so
+LIB_DEPENDS+=	modplug.0:${PORTSDIR}/audio/libmodplug
+.else
+CONFIGURE_ARGS+=	--disable-modplug
 .endif
 
 .if defined(WITH_ESOUND)
--- audacious.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jan 8 18:44:10 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91521 

From: "Stepan Zastupov [RedChrom]" <redchrom@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/91521: update multimedia/audacious
Date: Tue, 10 Jan 2006 03:24:33 +0800

 --HG+GLK89HZ1zG0kk
 Content-Type: text/plain; charset=koi8-r
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 It's look nice, i'm approve it.
 
 --=20
 Best regards, Zastupov Stepan aka RedChrom
 Blog: http://livejournal.com/~redchrom
 xmpp:redchrom@jabber.ru
 
 --HG+GLK89HZ1zG0kk
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQFDwrhxkD+Dz/IxjeMRAvZaAJ0QotP52doJzAmf+v5rCjc3kUZykACfVAyT
 gnNOVsgeL7jrynDivEVhNHs=
 =kMeC
 -----END PGP SIGNATURE-----
 
 --HG+GLK89HZ1zG0kk--
Responsible-Changed-From-To: freebsd-ports-bugs->novel 
Responsible-Changed-By: novel 
Responsible-Changed-When: Sat Jan 14 06:45:11 UTC 2006 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91521 
State-Changed-From-To: feedback->closed 
State-Changed-By: novel 
State-Changed-When: Tue Jan 17 05:55:50 UTC 2006 
State-Changed-Why:  
Using PLIST_SUB for a singe file is not ugly if your port uses 
pkg-plist. Mixing PLIST_FILES and pkg-plist doesn't look like a good 
style to me. 

A modified patch has been committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91521 
>Unformatted:
