From nobody@FreeBSD.org  Sat Jan  7 12:05:48 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 061E916A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Jan 2006 12:05:48 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8626E43D64
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Jan 2006 12:05:43 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k07C5YrG076206
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 7 Jan 2006 12:05:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k07C5Yg9076203;
	Sat, 7 Jan 2006 12:05:34 GMT
	(envelope-from nobody)
Message-Id: <200601071205.k07C5Yg9076203@www.freebsd.org>
Date: Sat, 7 Jan 2006 12:05:34 GMT
From: Peter Kerwien <peter@kerwien.homeip.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lftp may segfaults when linked with Readline 5.0
X-Send-Pr-Version: www-2.3

>Number:         91451
>Category:       ports
>Synopsis:       lftp may segfaults when linked with Readline 5.0
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 07 12:10:07 GMT 2006
>Closed-Date:    Tue Aug 29 20:56:41 GMT 2006
>Last-Modified:  Tue Aug 29 20:56:41 GMT 2006
>Originator:     Peter Kerwien
>Release:        FreeBSD-6.0-p1
>Organization:
N/A
>Environment:
FreeBSD netbsd.homedns.org 6.0-RELEASE-p1 FreeBSD 6.0-RELEASE-p1 #0: Sat Jan  7 01:20:19 CET 2006     root@netbsd.homedns.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When tabbing in lftp to fill in the rest of the pathnames, it sometimes 
segmentation faults.

See for more information:

http://bugs.gentoo.org/show_bug.cgi?id=95958
http://bugs.gentoo.org/show_bug.cgi?id=74815


>How-To-Repeat:
See:

http://bugs.gentoo.org/show_bug.cgi?id=95958
http://bugs.gentoo.org/show_bug.cgi?id=74815              
>Fix:
Configure lftp with --with-included-readline. See also:

http://bugs.gentoo.org/show_bug.cgi?id=95958
http://bugs.gentoo.org/show_bug.cgi?id=74815

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Jan 7 19:58:47 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91451 

From: Peter Kerwien <peter@kerwien.homeip.net>
To: "Dmitry A. Yanko" <fm@cross-road.org.ua>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
Date: Mon, 09 Jan 2006 19:50:08 +0100

 Patch does not fix this problem!
 
 root@freebsd# lftp
 lftp :~> open ftp.sunet.se
 lftp ftp.sunet.se:~> cd pub/Linux/kernel.org/Segmentation fault: 11 
 (core dumped)
 root@freebsd# lftp
 lftp :~> version
 LFTP | Version 3.3.5 | Copyright (c) 1996-2005 Alexander V. Lukyanov
 
 LFTP is free software, covered by the GNU General Public License, and 
 you are
 welcome to change it and/or distribute copies of it under certain 
 conditions.
 There is absolutely no warranty for LFTP.  See COPYING for details.
 
 Send bug reports and questions to <lftp@uniyar.ac.ru>.
 
 Libraries used: Readline 5.0, Expat 1.95.8, OpenSSL 0.9.7e-p1 25 Oct 2004
 
 Dmitry A. Yanko wrote:
 
 >Attached patch from author seems to solve a problem.
 >
 >
 >  
 >
 >------------------------------------------------------------------------
 >
 >diff -ruN lftp.orig/files/patch-complete.cc lftp/files/patch-complete.cc
 >--- lftp.orig/files/patch-complete.cc	Thu Jan  1 03:00:00 1970
 >+++ lftp/files/patch-complete.cc	Mon Jan  9 18:40:22 2006
 >@@ -0,0 +1,24 @@
 >+--- src/complete.cc.orig	Wed Nov  3 10:37:44 2004
 >++++ src/complete.cc	Mon Jan  9 18:38:59 2006
 >+@@ -660,7 +660,7 @@
 >+ 	    type=REMOTE_DIR;
 >+ 	 goto really_remote;
 >+       }
 >+-
 >++   really_local:
 >+       ArgV arg("", ResMgr::Query("cmd:cls-completion-default", 0));
 >+       fso.parse_argv(&arg);
 >+ 
 >+@@ -729,7 +729,11 @@
 >+    case REMOTE_FILE:
 >+    case REMOTE_DIR: {
 >+       if(!remote_completion && !force_remote)
 >+-	 break; // local
 >++      {
 >++	 if(type==REMOTE_DIR)
 >++	    type=LOCAL_DIR;
 >++	 goto really_local;
 >++      }
 >+    really_remote:
 >+       if(!strncmp(text,"bm:",3) && !strchr(text,'/'))
 >+       {
 >  
 >
 

From: Pav Lucistnik <pav@FreeBSD.org>
To: bug-followup@FreeBSD.org, peter@kerwien.homeip.net, fm@cross-road.org.ua
Cc:  
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
Date: Sun, 26 Mar 2006 21:52:18 +0200

 So what is the status of this PR?
 
 Also, which version of lftp do you have, Peter? Can you reproduce the
 problem with 3.4.0?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Pain clots and unformed lice pat this train.

From: "Dmitry A. Yanko" <fm@cross-road.org.ua>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, peter@kerwien.homeip.net
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
Date: Mon, 27 Mar 2006 12:49:29 +0300

 On Sun, Mar 26, 2006 at 09:52:18PM +0200, Pav Lucistnik wrote:
 > So what is the status of this PR?
 > 
 > Also, which version of lftp do you have, Peter? Can you reproduce the
 > problem with 3.4.0?
 Bug is still can be reprodused with lftp-3.4.0_2 and readline-5.0 (within
 system).
 It's ok with readline-5.1 (within ports).
 
 I think, that system's readline needs to be upgraded and there is no lftp's
 fault in this bug.
 
 P.S.: Somewhy, i can't send or reply PR from this server. freebsd.org's mx
 think that i have a broken back resolving. But it's ok with my resolving. Can
 you forward this problem to postmaster@freebsd.org ?
 
 

From: "Peter Kerwien" <peter@kerwien.homeip.net>
To: "Dmitry A. Yanko" <fm@cross-road.org.ua>
Cc: "Pav Lucistnik" <pav@freebsd.org>,
 bug-followup@freebsd.org,
 peter@kerwien.homeip.net
Subject: Re: ports/91451: lftp may segfaults when linked with Readline 5.0
Date: Mon, 27 Mar 2006 12:58:03 +0200 (CEST)

 Agree. I have tried with lftp-3.4.0_2 and it crashes. The solution for
 Gentoo was to upgrade readline.
 
 /Peter
 
 > On Sun, Mar 26, 2006 at 09:52:18PM +0200, Pav Lucistnik wrote:
 >> So what is the status of this PR?
 >>
 >> Also, which version of lftp do you have, Peter? Can you reproduce the
 >> problem with 3.4.0?
 > Bug is still can be reprodused with lftp-3.4.0_2 and readline-5.0 (within
 > system).
 > It's ok with readline-5.1 (within ports).
 >
 > I think, that system's readline needs to be upgraded and there is no
 > lftp's
 > fault in this bug.
 >
 > P.S.: Somewhy, i can't send or reply PR from this server. freebsd.org's mx
 > think that i have a broken back resolving. But it's ok with my resolving.
 > Can
 > you forward this problem to postmaster@freebsd.org ?
 >
 >
 >
 
 
 
 ----------------------------------------------------
 If Windows is the answer, you don't understand the question!
 
 
State-Changed-From-To: feedback->suspended 
State-Changed-By: pav 
State-Changed-When: Sun Apr 9 11:49:46 UTC 2006 
State-Changed-Why:  
The readline library in 7-CURRENT was updated to 5.1 
Set this PR `suspended' until someone MFC readline 5.1 into 6-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91451 
State-Changed-From-To: suspended->closed 
State-Changed-By: pav 
State-Changed-When: Tue Aug 29 20:56:19 UTC 2006 
State-Changed-Why:  
The port now always links a new readline from ports 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91451 
>Unformatted:
