From bh@izb.knu.ac.kr  Fri Jan  6 10:39:41 2006
Return-Path: <bh@izb.knu.ac.kr>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D233D16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jan 2006 10:39:41 +0000 (GMT)
	(envelope-from bh@izb.knu.ac.kr)
Received: from izb.knu.ac.kr (izb.knu.ac.kr [155.230.157.93])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D6E4A43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jan 2006 10:39:40 +0000 (GMT)
	(envelope-from bh@izb.knu.ac.kr)
Received: (qmail 32512 invoked from network); 6 Jan 2006 19:39:36 +0900
Received: from e.mx (HELO i.mx) (2002:9be6:9d5d:2::1)
        by e.mx (envelope-from bh@izb.knu.ac.kr)
	with AES256-SHA encrypted SMTP; 6 Jan 2006 19:39:36 +0900
Received: (qmail 32503 invoked from network); 6 Jan 2006 19:39:35 +0900
Received: from viola.izb.knu.ac.kr (2002:9be6:9d5d:2::2)
        by i.mx (envelope-from bh@izb.knu.ac.kr)
	with AES256-SHA encrypted SMTP; 6 Jan 2006 19:39:35 +0900
Received: by viola.izb.knu.ac.kr (Postfix, from userid 1001)
	id 9DA5A64AB; Fri,  6 Jan 2006 03:39:36 -0700 (MST)
Message-Id: <20060106103936.9DA5A64AB@viola.izb.knu.ac.kr>
Date: Fri,  6 Jan 2006 03:39:36 -0700 (MST)
From: Byung-Hee HWANG <bh@izb.knu.ac.kr>
Reply-To: Byung-Hee HWANG <bh@izb.knu.ac.kr>
To: FreeBSD-gnats-submit@freebsd.org
Cc: changbom.yoon@gmail.com
Subject: [PATCH] multimedia/quodlibet: FLAC Format support
X-Send-Pr-Version: 3.113
X-GNATS-Notify: changbom.yoon@gmail.com

>Number:         91388
>Category:       ports
>Synopsis:       [PATCH] multimedia/quodlibet: FLAC Format support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 06 10:40:02 GMT 2006
>Closed-Date:    Sat Jan 07 02:13:41 GMT 2006
>Last-Modified:  Sat Jan 07 02:13:41 GMT 2006
>Originator:     Byung-Hee HWANG
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
InZealBomb
>Environment:
System: FreeBSD viola.izb.knu.ac.kr 6.0-STABLE FreeBSD 6.0-STABLE #0: Sat Dec 10 09:05:22 MST 2005 bh@viola.izb.knu.ac.kr:/usr/src/sys/i386/compile/II82801BA i386

>Description:
- FLAC [1] Format support
- [1] http://flac.sourceforge.net/

>How-To-Repeat:
After CVSup(cause py-flac), I tried patch and re-build. It worked correctly.
See follow, <URL:http://izb.knu.ac.kr/~bh/tmp/py-flac/files/flac_ql_ss.png>.

>Fix:

--- ports-quodlibet-20060106.diff begins here ---
diff --exclude=CVS -uNr quodlibet.orig/Makefile quodlibet/Makefile
--- quodlibet.orig/Makefile	2006-01-04 14:16:53.000000000 -0700
+++ quodlibet/Makefile	2006-01-05 10:48:54.336986828 -0700
@@ -13,23 +13,43 @@
 MAINTAINER=	changbom.yoon@gmail.com
 COMMENT=	A GTK+-based audio player written in Python
 
-BUILD_DEPENDS=	${PYTHON_SITELIBDIR}/gst/__init__.py:${PORTSDIR}/multimedia/py-gstreamer \
-		${PYTHON_SITELIBDIR}/ogg/_ogg.so:${PORTSDIR}/audio/py-ogg \
-		${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis \
-		${PYTHON_SITELIBDIR}/madmodule.so:${PORTSDIR}/audio/py-mad
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/gst/__init__.py:${PORTSDIR}/multimedia/py-gstreamer \
-		${PYTHON_SITELIBDIR}/ogg/_ogg.so:${PORTSDIR}/audio/py-ogg \
-		${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis \
-		${PYTHON_SITELIBDIR}/madmodule.so:${PORTSDIR}/audio/py-mad
+BUILD_DEPENDS=	${PYTHON_SITELIBDIR}/gst/__init__.py:${PORTSDIR}/multimedia/py-gstreamer
+RUN_DEPENDS=	${PYTHON_SITELIBDIR}/gst/__init__.py:${PORTSDIR}/multimedia/py-gstreamer
 
 USE_PYTHON=	2.3+
 USE_GNOME=	pygtk2
 USE_GMAKE=	yes
 USE_X_PREFIX=	yes
-USE_GSTREAMER=	ogg vorbis mad
+USE_GSTREAMER=	yes
 
 MAN1=		exfalso.1 quodlibet.1
 
+# Supported formats: ogg vorbis mad flac
+QUODLIBET_FORMATS?=	ogg vorbis mad flac
+.for format in ${QUODLIBET_FORMATS}
+WANT_QUODLIBET_${format:U}=	yes
+.endfor
+
+.if defined(WANT_QUODLIBET_OGG)
+BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/ogg/_ogg.so:${PORTSDIR}/audio/py-ogg
+USE_GSTREAMER+=	ogg
+.endif
+
+.if defined(WANT_QUODLIBET_VORBIS)
+BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis
+USE_GSTREAMER+=	vorbis
+.endif
+
+.if defined(WANT_QUODLIBET_MAD)
+BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/madmodule.so:${PORTSDIR}/audio/py-mad
+USE_GSTREAMER+=	mad
+.endif
+
+.if defined(WANT_QUODLIBET_FLAC)
+BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/flac/__init__.py:${PORTSDIR}/audio/py-flac
+USE_GSTREAMER+=	flac
+.endif
+
 .if defined(PACKAGE_BUILDING)
 BUILD_DEPENDS+=	Xvfb:${X_VFBSERVER_PORT} \
 		${X11BASE}/lib/X11/fonts/misc/8x13O.pcf.gz:${X_FONTS_MISC_PORT}
@@ -37,7 +57,6 @@
 
 .if defined(WITH_EXTENSIONS)
 BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/gtk-2.0/egg/__init__.py:${PORTSDIR}/x11-toolkits/py-gnome-extras
-RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/gtk-2.0/egg/__init__.py:${PORTSDIR}/x11-toolkits/py-gnome-extras
 PLIST_SUB+=	EXTENSIONS:=""
 .else
 PLIST_SUB+=	EXTENSIONS:="@comment "
--- ports-quodlibet-20060106.diff ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jan 6 10:44:42 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91388 

From: ChangBom Yoon <changbom.yoon@gmail.com>
To: edwin@FreeBSD.org
Cc: bug-followup@FreeBSD.org, bh@izb.knu.ac.kr
Subject: Re: ports/91388: [PATCH] multimedia/quodlibet: FLAC Format support
Date: Fri, 6 Jan 2006 20:16:28 +0900

 On Fri, 6 Jan 2006 10:44:25 UT, Edwin Groothuis wrote:
 > Maintainer of multimedia/quodlibet,
 > 
 > Please note that PR ports/91388 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/91388
 
 I've test it. It works good. :-)
 
 -- 
 Realize your dream!!!
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Fri Jan 6 11:22:25 UTC 2006 
State-Changed-Why:  
Maintainer approved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91388 
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Sat Jan 7 02:13:39 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=91388 
>Unformatted:
