From ady@warpnet.ro  Sat Dec 19 10:48:15 1998
Received: from ady.warpnet.ro ([194.102.224.1])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA04536
          for <FreeBSD-gnats-submit@FreeBSD.ORG>; Sat, 19 Dec 1998 10:48:08 -0800 (PST)
          (envelope-from ady@warpnet.ro)
Received: from localhost (ady@localhost)
	by ady.warpnet.ro (8.8.8/8.8.8) with SMTP id UAA09829;
	Sat, 19 Dec 1998 20:47:55 +0200 (EET)
	(envelope-from ady@warpnet.ro)
Message-Id: <Pine.BSF.3.96.981219202520.9677B-100000@ady.warpnet.ro>
Date: Sat, 19 Dec 1998 20:47:55 +0200 (EET)
From: Adrian Penisoara <ady@warpnet.ro>
To: yds@dppl.com
Cc: FreeBSD-gnats-submit@FreeBSD.ORG, imap-uw@freebsd.ady.ro
In-Reply-To: <19981216214117.21269.qmail@paris.dppl.com>
Subject: Re: imap-uw: install mail.h rfc822.h linkage.h

>Number:         9130
>Category:       ports
>Synopsis:       Re: imap-uw: install mail.h rfc822.h linkage.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 19 10:50:00 PST 1998
>Closed-Date:    Sat Dec 19 23:02:18 GMT 1998
>Last-Modified:  Wed Oct 26 05:32:32 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: steve
State-Changed-When: Sat Dec 19 23:02:18 GMT 1998
State-Changed-Why: 
Meant as a followup to PR #9108.
>Unformatted:
Hi,

 Sorry for the late reply, I'm kept busy by a new satellite dish that
we've installed lately...

On 16 Dec 1998 yds@dppl.com wrote:

> 
> >Description: 
> 
> 	Currently the imap-uw port builds libc-client4.so.4 but doesn't
> install the required headers needed to link with the library. Examples of
> programs which link to c-clinet are Perl's Mail::Cclient and PHP3 w/IMAP
> enabled; pine uses it's own copy of c-client.

 I do support installing the neccesary aditions but the problem is: does
everyone who installs the imap-uw port need these aditions ? If enough
people would need them then I would gladly accept moving them in the
default install target, but if not, wouldn't it be a better ideea to leave
them in a separate install target and either reference it from the install
targer (conditioned with a INSTALL_HEADER variable) or invite those who
need it to execute a "make install-lib" ?...

> 
> >How-To-Repeat: 
> 
> 	Look at the comments in imap-uw/Makefile (which my patch is deleting
> since they will no longer be relevent)
> 
> >Fix: 
> 
> diff -ruN imap-uw.old/Makefile imap-uw/Makefile
> --- imap-uw.old/Makefile	Sat Nov 21 15:01:51 1998
> +++ imap-uw/Makefile	Wed Dec 16 15:49:31 1998
> @@ -32,14 +32,10 @@
>  post-configure:
>  	@${ECHO_MSG} ">> The c-client shared library will be named ${SHLIBNAME}"
>  
> -# this rule currently isn't called or used, because it's not sufficient to
> -# install just the .a file and mail.h, so we shouldn't install anything at all!
> -# Remark: only the shared library version is built now !
> -install-lib:
> -	${INSTALL_DATA} ${WRKSRC}/c-clinet/mail.h ${PREFIX}/include
> -	${INSTALL_DATA} ${WRKSRC}/c-client/c-client.a ${PREFIX}/lib/libc-client.a
> -
>  do-install:
> +	${INSTALL_DATA} ${WRKSRC}/c-client/mail.h ${PREFIX}/include
> +	${INSTALL_DATA} ${WRKSRC}/c-client/rfc822.h ${PREFIX}/include
> +	${INSTALL_DATA} ${WRKSRC}/c-client/linkage.h ${PREFIX}/include

 Are these files (mail.h , rfc822.h , linkage.h) enough for all of the
applications who need the c-client library ? Please check this with
someone more "in the know" (one of the developers eventually) ?

>  	${INSTALL} ${COPY} ${STRIP} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
>  		${WRKSRC}/c-client/${SHLIBNAME} ${PREFIX}/lib
>  	${LN} -sf ${SHLIBNAME} ${PREFIX}/lib/lib${SHLIBBASE}.so
> diff -ruN imap-uw.old/pkg/PLIST imap-uw/pkg/PLIST
> --- imap-uw.old/pkg/PLIST	Sat Nov 21 15:01:56 1998
> +++ imap-uw/pkg/PLIST	Wed Dec 16 15:50:29 1998
> @@ -1,4 +1,7 @@
>  bin/mboxtest
> +include/mail.h
> +include/rfc822.h
> +include/linkage.h
>  lib/%%SHLIBNAME%%
>  lib/lib%%SHLIBBASE%%.so
>  @exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m %B
> 
> 

  I'll try to make some tests tomorrow.

  I might not reply too soon; mail to "...ady.ro" domains may be delayed
for a day or so (due to nameserver changes), use ady@warpnet.ro instead,
until everything gets fixed here.

  Thanks!
  Ady (@freebsd.ady.ro)

