From past@ebs.gr  Tue Dec 27 09:29:20 2005
Return-Path: <past@ebs.gr>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9B10C16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Dec 2005 09:29:20 +0000 (GMT)
	(envelope-from past@ebs.gr)
Received: from fly.ebs.gr (fly.ebs.gr [62.103.84.177])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1EFF743D82
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Dec 2005 09:29:12 +0000 (GMT)
	(envelope-from past@ebs.gr)
Received: from ebs.gr (root@hal.ebs.gr [10.1.1.2])
	by fly.ebs.gr (8.12.9p1/8.12.9) with ESMTP id jBR9T9AF008111;
	Tue, 27 Dec 2005 11:29:09 +0200 (EET)
	(envelope-from past@ebs.gr)
Received: from ajax.ebs.gr (pc158.ebs.gr [10.1.1.158])
	by ebs.gr (8.13.3/8.12.11) with ESMTP id jBR9TswW029802;
	Tue, 27 Dec 2005 11:29:54 +0200 (EET)
	(envelope-from past@ebs.gr)
Message-Id: <1135675748.0@ajax.ebs.gr>
Date: Tue, 27 Dec 2005 11:29:08 +0200
From: "\"Panagiotis Astithas\" <Panagiotis Astithas" <past@ebs.gr>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Cc: sethk@meowfishies.com
Subject: [patch] Install a menu entry for sysutils/bpm
X-Send-Pr-Version: gtk-send-pr 0.4.6 
X-GNATS-Notify: sethk@meowfishies.com

>Number:         90971
>Category:       ports
>Synopsis:       [patch] Install a menu entry for sysutils/bpm
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 27 09:30:06 GMT 2005
>Closed-Date:    Fri Dec 30 06:07:14 GMT 2005
>Last-Modified:  Fri Dec 30 06:07:14 GMT 2005
>Originator:     Panagiotis Astithas
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
EBS Ltd. 
>Environment:


System: FreeBSD 6.0-STABLE #4: Thu Dec 22 19:57:57 EET 2005
    past@ajax.ebs.gr:/usr/obj/usr/src/sys/AJAX



>Description:


This patch installs a menu entry for sysutils/bpm in GNOME, KDE, etc.
that allows a user to be aware of its existence and able to run it without
using the command line. I invoke it via gnomesu in order to be actually
useful for installing ports right away.


>How-To-Repeat:





>Fix:


--- bpm.patch begins here ---
diff -ruN /usr/ports/sysutils/bpm/Makefile bpm/Makefile
--- /usr/ports/sysutils/bpm/Makefile	Thu Dec  8 18:24:32 2005
+++ bpm/Makefile	Mon Dec 19 23:41:21 2005
@@ -18,7 +18,7 @@
 RUN_DEPENDS=	portupgrade:${PORTSDIR}/sysutils/portupgrade
 
 USE_X_PREFIX=	yes
-USE_GNOME=	gtk20
+USE_GNOME=	gtk20 desktopfileutils
 USE_REINPLACE=	yes
 
 MAKE_ENV+=	OSTYPE="${OPSYS}"
@@ -29,5 +29,11 @@
 # GnomeVFS needs pthread; bpm may use GnomeVFS (via GtkFileChooser)
 	@${REINPLACE_CMD} -e 's|^CFLAGS+=|& ${PTHREAD_CFLAGS}|; \
 		s|^LDLIBS+=|& ${PTHREAD_LIBS}|' ${WRKSRC}/src/Makefile
+	@${SED} -e 's|%%PREFIX%%|${PREFIX}|g' ${FILESDIR}/bpm.desktop.in \
+		> ${WRKSRC}/bpm.desktop
+
+post-install:
+	${INSTALL_DATA} ${WRKSRC}/bpm.desktop ${PREFIX}/share/applications/bpm.desktop
+	@-update-desktop-database
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/sysutils/bpm/files/bpm.desktop.in bpm/files/bpm.desktop.in
--- /usr/ports/sysutils/bpm/files/bpm.desktop.in	Thu Jan  1 02:00:00 1970
+++ bpm/files/bpm.desktop.in	Tue Dec 20 00:20:46 2005
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Comment=The BSD Ports Manipulator
+Name=BPM
+Exec=gnomesu %%PREFIX%%/bin/bpm
+Encoding=UTF-8
+Terminal=false
+Type=Application
+Icon=%%PREFIX%%/share/bpm/pixmaps/pkg_48.png
+Categories=Application;System;
diff -ruN /usr/ports/sysutils/bpm/pkg-plist bpm/pkg-plist
--- /usr/ports/sysutils/bpm/pkg-plist	Tue Aug 24 07:21:59 2004
+++ bpm/pkg-plist	Mon Dec 19 23:33:24 2005
@@ -9,6 +9,9 @@
 %%DATADIR%%/pixmaps/pkg_48.png
 %%DATADIR%%/pixmaps/lock_48.png
 share/locale/en_CA/LC_MESSAGES/bpm.mo
+share/applications/bpm.desktop
+@exec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
 @dirrm libexec/bpm
 @dirrm %%DATADIR%%/pixmaps
 @dirrm %%DATADIR%%
+@unexec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
--- bpm.patch ends here ---



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Dec 27 09:33:48 UTC 2005 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90971 

From: Seth Kingsley <sethk@meowfishies.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/90971: [patch] Install a menu entry for sysutils/bpm
Date: Thu, 29 Dec 2005 13:23:35 -0800

 --ZrCu0B0FMx3UnjE2
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Dec 27, 2005 at 09:32:02AM +0000, Edwin Groothuis wrote:
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 
 I agree.  Please submit this patch.
 
 --=20
 || Seth Kingsley || sethk@meowfishies.com ||
 || http://www.meowfishies.com/ | Meow ^_^ ||
 
 --ZrCu0B0FMx3UnjE2
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.2 (FreeBSD)
 
 iD8DBQFDtFPXD1AymFxBOwgRApY+AJ9gVV0NBJGIGm2/xd2h8VpSGxxnvwCeLY+U
 kC4W210Tx3AN4BdqYZ8QagE=
 =UEZJ
 -----END PGP SIGNATURE-----
 
 --ZrCu0B0FMx3UnjE2--
State-Changed-From-To: feedback->open 
State-Changed-By: edwin 
State-Changed-When: Thu Dec 29 21:39:58 UTC 2005 
State-Changed-Why:  
Feedback received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90971 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Fri Dec 30 06:07:05 UTC 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90971 
>Unformatted:
