From nobody@FreeBSD.org  Fri Dec 23 16:31:23 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 335FB16A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Dec 2005 16:31:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EB7BB43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Dec 2005 16:31:22 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jBNGVMGF046890
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Dec 2005 16:31:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id jBNGVMX9046889;
	Fri, 23 Dec 2005 16:31:22 GMT
	(envelope-from nobody)
Message-Id: <200512231631.jBNGVMX9046889@www.freebsd.org>
Date: Fri, 23 Dec 2005 16:31:22 GMT
From: Chris Chou <m2chrischou@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Alacarte can not modify menu items without icon
X-Send-Pr-Version: www-2.3

>Number:         90857
>Category:       ports
>Synopsis:       Alacarte can not modify menu items without icon
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 23 16:40:05 GMT 2005
>Closed-Date:    Mon Dec 26 01:50:34 GMT 2005
>Last-Modified:  Mon Dec 26 01:50:34 GMT 2005
>Originator:     Chris Chou
>Release:        FreeBSD 6.0 i386
>Organization:
Sun Yat-sen University
>Environment:
FreeBSD www.itsphere.com 6.0-STABLE FreeBSD 6.0-STABLE #15: Tue Dec 13 22:30:02 CST 2005     chris@www.itsphere.com:/usr/obj/usr/src/sys/CHRIS  i386
>Description:
Alacarte can not modify menu items without icon specified.
>How-To-Repeat:
>Fix:
--- GnomeDialogHandler.py   Fri Dec 23 23:51:02 2005
+++ GnomeDialogHandler.py.origin    Fri Dec 23 23:50:27 2005
@@ -212,7 +212,10 @@
            )
        commandEntry.gtk_entry().set_completion(self.completion)
        iconButton = self.tree.get_widget('eiconbutton')
-       iconButton.set_pixmap_subdir(item.iconPath)
+       if item.iconPath == None:
+           iconButton.set_pixmap_subdir('')
+       else:
+           iconButton.set_pixmap_subdir(item.iconPath)
        termCheck = self.tree.get_widget('etermcheck')
        originalValues = (
            item.getKey('Name'), item.getKey('Comment'), item.getKey('Exec'),
@@ -221,7 +224,10 @@
        nameEntry.set_text(item.getKey('Name'))
        commentEntry.set_text(item.getKey('Comment'))
        commandEntry.set_filename(item.getKey('Exec'))
-       iconButton.set_filename(item.iconPath)
+       if item.iconPath == None:
+           iconButton.set_filename('')
+       else:
+           iconButton.set_filename(item.iconPath)
        if item.getKey('Terminal') == 'true':
            termCheck.set_active(1)
        self.setupEntry = False
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Dec 23 20:16:07 UTC 2005 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90857 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Mon Dec 26 01:50:16 UTC 2005 
State-Changed-Why:  
Committed, thanks! 

Patch was accepted by the alacarte author, too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90857 
>Unformatted:
 >cd /usr/ports/deskutils/alacarte
 >make install clean
 
 >alacarte
 
 Double click the menu items (application entry) without icon specified.
 
