From flz@xbsd.org  Thu Dec 15 15:17:29 2005
Return-Path: <flz@xbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E72E516A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Dec 2005 15:17:29 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ED7E143D60
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Dec 2005 15:17:28 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id C0C6E11ABD
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Dec 2005 16:17:27 +0100 (CET)
Received: from smtp.xbsd.org ([127.0.0.1])
 by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 80054-07 for <FreeBSD-gnats-submit@freebsd.org>;
 Thu, 15 Dec 2005 16:17:21 +0100 (CET)
Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6])
	by smtp.xbsd.org (Postfix) with SMTP id 97482115A6
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Dec 2005 16:17:21 +0100 (CET)
Received: by cream.xbsd.org (sSMTP sendmail emulation); Thu, 15 Dec 2005 16:16:29 +0000
Message-Id: <20051215151721.97482115A6@smtp.xbsd.org>
Date: Thu, 15 Dec 2005 16:16:29 +0000
From: "Florent Thoumie" <flz@xbsd.org>
Reply-To: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Ports defining CONF_FILES
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         90438
>Category:       ports
>Synopsis:       Ports defining CONF_FILES
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    flz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 15 15:20:03 GMT 2005
>Closed-Date:    Mon Feb 20 13:32:15 GMT 2006
>Last-Modified:  Mon Feb 20 13:32:15 GMT 2006
>Originator:     Florent Thoumie
>Release:        FreeBSD 6.0-RELEASE amd64
>Organization:
Xbsd.org
>Environment:
System: FreeBSD cream.xbsd.org 6.0-RELEASE FreeBSD 6.0-RELEASE #4: Mon Dec 5 02:31:46 UTC 2005 root@cream.xbsd.org:/usr/src/sys/amd64/compile/CREAM amd64


	
>Description:

These ports are using the variable name CONF_FILES :

- mail/dsbl-testers (dean@odyssey.apana.org.au)
- mail/elm+ME (ports@FreeBSD.org)
- net/dcd (mraleks@bk.ru)
- net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de)
- security/amap (rabbi@abditum.com)
- security/openscep (vsevolod@FreeBSD.org)
- sysutils/epylog (alan@wave2.co.uk) - done

ports/90436 has a new way to handle configuration files and the ports are likely
to be broken once the patch hits the tree.

Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before).

>How-To-Repeat:
	
>Fix:

s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->flz 
Responsible-Changed-By: flz 
Responsible-Changed-When: Thu Dec 15 16:03:08 UTC 2005 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90438 

From: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: dean@odyssey.apana.org.au, mraleks@bk.ru, Joerg.Pulz@frm2.tum.de,  rabbi@abditum.com, vsevolod@FreeBSD.org, alan@wave2.co.uk
Subject: Re: ports/90438: Ports defining CONF_FILES
Date: Thu, 15 Dec 2005 17:32:06 +0000

 --=-KF8RSFH+aSQEUXIZ7wis
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Le Jeudi 15 d=C3=A9cembre 2005 =C3=A0 16:16 +0000, Florent Thoumie a =C3=A9=
 crit :
 =09
 > >Description:
 >=20
 > These ports are using the variable name CONF_FILES :
 >=20
 > - mail/dsbl-testers (dean@odyssey.apana.org.au)
 > - mail/elm+ME (ports@FreeBSD.org)
 > - net/dcd (mraleks@bk.ru)
 > - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de)
 > - security/amap (rabbi@abditum.com)
 > - security/openscep (vsevolod@FreeBSD.org)
 > - sysutils/epylog (alan@wave2.co.uk)
 >=20
 > ports/90436 has a new way to handle configuration files and the ports are=
  likely
 > to be broken once the patch hits the tree.
 >=20
 > Please rename this variable within an acceptable time frame (I'm fixing m=
 aintainer timeout to one month, or less it the bsd.port.mk patch is committ=
 ed before).
 >=20
 > >How-To-Repeat:
 > =09
 > >Fix:
 >=20
 > s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name.
 
 	Please have a look at this PR.
 
 --=20
 Florent Thoumie
 flz@FreeBSD.org
 FreeBSD committer
 
 --=-KF8RSFH+aSQEUXIZ7wis
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: Ceci est une partie de message
 	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQBDoaiWMxEkbVFH3PQRAgc+AJ9IQzXm9ZPMmhtFsbU1t6IbDc1NfwCfbhO3
 r/LSdsbgceBQYWtgRkm4TO8=
 =d2Db
 -----END PGP SIGNATURE-----
 
 --=-KF8RSFH+aSQEUXIZ7wis--
 

From: Joerg Pulz <Joerg.Pulz@frm2.tum.de>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: Florent Thoumie <flz@xbsd.org>
Subject: Re: ports/90438: Ports defining CONF_FILES
Date: Thu, 15 Dec 2005 18:38:30 +0100 (CET)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --0-1128916854-1134668310=:1063
 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 8BIT
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 
 On Thu, 15 Dec 2005, Florent Thoumie wrote:
 
 > Le Jeudi 15 dcembre 2005  16:16 +0000, Florent Thoumie a crit :
 >
 >>> Description:
 >>
 >> These ports are using the variable name CONF_FILES :
 >>
 >> - mail/dsbl-testers (dean@odyssey.apana.org.au)
 >> - mail/elm+ME (ports@FreeBSD.org)
 >> - net/dcd (mraleks@bk.ru)
 >> - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de)
 >> - security/amap (rabbi@abditum.com)
 >> - security/openscep (vsevolod@FreeBSD.org)
 >> - sysutils/epylog (alan@wave2.co.uk)
 >>
 >> ports/90436 has a new way to handle configuration files and the ports are likely
 >> to be broken once the patch hits the tree.
 >>
 >> Please rename this variable within an acceptable time frame (I'm fixing maintainer timeout to one month, or less it the bsd.port.mk patch is committed before).
 >>
 >>> How-To-Repeat:
 >>
 >>> Fix:
 >>
 >> s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name.
 >
 > 	Please have a look at this PR.
 
 Hi Florent,
 
 attached you will find the patch for net/isc-dhcp3-server.
 
 Actually, i've one question: isn't the line
 ${INSTALL_DATA} ${PREFIX}/${conf}${CONF_SUFX} ${PREFIX}/${conf}
 in your patch overwriting already existing ${conf} files with the sample 
 version? I'm not sure, but a short test with a very simple self written 
 Makefile has overwritten ${PREFIX}/${conf} with 
 ${PREFIX}/${conf}${CONF_SUFX}, regardless of any changes made to 
 ${PREFIX}/${conf} before.
 If you can confirm this, you should probably insert a small test(1) line 
 before to prevent from overwriting already existing and working 
 configuration files during a simple upgrade.
 
 Please correct me if i'm wrong
 Joerg
 
 - -- 
 The beginning is the most important part of the work.
  				-Plato
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQFDoaoZSPOsGF+KA+MRAnT2AJ9Svqkmzrv9aZfSk4YpRlJLfjAT1wCfcV41
 Dt+vNRPsZNkIIM7IVF07mRw=
 =Ucnq
 -----END PGP SIGNATURE-----
 --0-1128916854-1134668310=:1063
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=isc-dhcp3-server.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <20051215183830.W1063@hades.admin.frm2>
 Content-Description: 
 Content-Disposition: attachment; filename=isc-dhcp3-server.diff
 
 SW5kZXg6IE1ha2VmaWxlDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
 ZmlsZTogL2hvbWUvbmN2cy9wb3J0cy9uZXQvaXNjLWRoY3AzLXNlcnZlci9N
 YWtlZmlsZSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTExDQpkaWZmIC11
 IC1yMS4xMTEgTWFrZWZpbGUNCi0tLSBNYWtlZmlsZQkxNCBEZWMgMjAwNSAx
 OTo0MToyNSAtMDAwMAkxLjExMQ0KKysrIE1ha2VmaWxlCTE1IERlYyAyMDA1
 IDE3OjA2OjA5IC0wMDAwDQpAQCAtMTM3LDcgKzEzNyw3IEBADQogLmVuZGlm
 DQogLmlmICR7U1VCU1lTfSA9PSBjbGllbnQNCiBCSU5fRklMRVM9CWRoY2xp
 ZW50DQotQ09ORl9GSUxFUz0JZGhjbGllbnQuY29uZg0KK0NMSUVOVF9DT05G
 X0ZJTEVTPQlkaGNsaWVudC5jb25mDQogU0FNUF9GSUxFUz0JY2xpZW50L2Ro
 Y2xpZW50LmNvbmYNCiBEQVRBX0ZJTEVTPQlkaGNsaWVudC5sZWFzZXMNCiAu
 ZWxpZiAke1NVQlNZU30gPT0gc2VydmVyDQpAQCAtMzI5LDcgKzMyOSw3IEBA
 DQogLmVuZGZvcg0KIA0KIGNyZWF0ZS1jb25mLWZpbGVzOg0KLS5mb3IgZiBp
 biAke0NPTkZfRklMRVN9DQorLmZvciBmIGluICR7Q0xJRU5UX0NPTkZfRklM
 RVN9DQogLmlmICFleGlzdHMoJHtDT05GX0RJUn0vJHtmfSkNCiAJQCR7VE9V
 Q0h9ICR7Q09ORl9ESVJ9LyR7Zn0NCiAuZW5kaWYNCg==
 
 --0-1128916854-1134668310=:1063--

From: Florent Thoumie <flz@xbsd.org>
To: Joerg Pulz <Joerg.Pulz@frm2.tum.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/90438: Ports defining CONF_FILES
Date: Thu, 15 Dec 2005 18:47:14 +0000

 --=-DuBXG75GEsLWFGjAGu9O
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Le Jeudi 15 d=C3=A9cembre 2005 =C3=A0 18:38 +0100, Joerg Pulz a =C3=A9crit =
 :
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 >=20
 >=20
 > On Thu, 15 Dec 2005, Florent Thoumie wrote:
 >=20
 > > Le Jeudi 15 d=C3=A9cembre 2005 =C3=A0 16:16 +0000, Florent Thoumie a =
 =C3=A9crit :
 > >
 > >>> Description:
 > >>
 > >> These ports are using the variable name CONF_FILES :
 > >>
 > >> - mail/dsbl-testers (dean@odyssey.apana.org.au)
 > >> - mail/elm+ME (ports@FreeBSD.org)
 > >> - net/dcd (mraleks@bk.ru)
 > >> - net/isc-dhcp3-server (Joerg.Pulz@frm2.tum.de)
 > >> - security/amap (rabbi@abditum.com)
 > >> - security/openscep (vsevolod@FreeBSD.org)
 > >> - sysutils/epylog (alan@wave2.co.uk)
 > >>
 > >> ports/90436 has a new way to handle configuration files and the ports =
 are likely
 > >> to be broken once the patch hits the tree.
 > >>
 > >> Please rename this variable within an acceptable time frame (I'm fixin=
 g maintainer timeout to one month, or less it the bsd.port.mk patch is comm=
 itted before).
 > >>
 > >>> How-To-Repeat:
 > >>
 > >>> Fix:
 > >>
 > >> s/CONF_FILES/LOCAL_CONF_FILES/g or whatever the name.
 > >
 > > 	Please have a look at this PR.
 >=20
 > Hi Florent,
 >=20
 > attached you will find the patch for net/isc-dhcp3-server.
 >=20
 > Actually, i've one question: isn't the line
 > ${INSTALL_DATA} ${PREFIX}/${conf}${CONF_SUFX} ${PREFIX}/${conf}
 > in your patch overwriting already existing ${conf} files with the sample=20
 > version? I'm not sure, but a short test with a very simple self written=20
 > Makefile has overwritten ${PREFIX}/${conf} with=20
 > ${PREFIX}/${conf}${CONF_SUFX}, regardless of any changes made to=20
 > ${PREFIX}/${conf} before.
 > If you can confirm this, you should probably insert a small test(1) line=20
 > before to prevent from overwriting already existing and working=20
 > configuration files during a simple upgrade.
 >=20
 > Please correct me if i'm wrong
 > Joerg
 
 	True, I've removed too much of the initial patch.
 
 	Thanks !
 
 --=20
 Florent Thoumie
 flz@FreeBSD.org
 FreeBSD committer
 
 --=-DuBXG75GEsLWFGjAGu9O
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: Ceci est une partie de message
 	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQBDoboyMxEkbVFH3PQRArIGAJ9sXyVyh3VDV2H97zcCwHEAoIRo+QCfVeaq
 KPCLRdtxgFE8dER2uCQMswE=
 =HVIj
 -----END PGP SIGNATURE-----
 
 --=-DuBXG75GEsLWFGjAGu9O--
 
State-Changed-From-To: open->closed 
State-Changed-By: flz 
State-Changed-When: Mon Feb 20 13:32:14 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90438 
>Unformatted:
