From sime@data.home.hr  Mon Dec 12 23:05:05 2005
Return-Path: <sime@data.home.hr>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8E8FE16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Dec 2005 23:05:05 +0000 (GMT)
	(envelope-from sime@data.home.hr)
Received: from data.home.hr (dh77-149.xnet.hr [83.139.77.149])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 89CDC43D58
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Dec 2005 23:04:53 +0000 (GMT)
	(envelope-from sime@data.home.hr)
Received: by data.home.hr (Postfix, from userid 34062)
	id 3BDE45F4C3; Tue, 13 Dec 2005 00:04:50 +0100 (CET)
Message-Id: <20051212230450.3BDE45F4C3@data.home.hr>
Date: Tue, 13 Dec 2005 00:04:50 +0100 (CET)
From: Simun Mikecin <sime@logos.hr>
Reply-To: Simun Mikecin <sime@logos.hr>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] www/mod_perl2: added support for www/apache22
X-Send-Pr-Version: 3.113
X-GNATS-Notify: lars.eggert@gmx.net

>Number:         90312
>Category:       ports
>Synopsis:       [patch] www/mod_perl2: added support for www/apache22
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 12 23:10:03 GMT 2005
>Closed-Date:    Mon Dec 19 18:24:42 GMT 2005
>Last-Modified:  Mon Dec 19 18:24:42 GMT 2005
>Originator:     Simun Mikecin
>Release:        FreeBSD 6.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD data.home.hr 6.0-STABLE FreeBSD 6.0-STABLE #0: Tue Dec 6 22:53:01 CET 2005 root@data.home.hr:/var/obj/usr/src.6/sys/DATA amd64


	
>Description:
Makefile of this port has hardcoded directories for integration with
www/apache20. With this patch it is able to dynamically detect installed
version of apache and configure accordingly. This adds support for
www/apache21 (not tested) and www/apache22 (tested).
>How-To-Repeat:
Try to use www/apache22 port with www/mod_perl2 shared module.
>Fix:
diff -urN mod_perl2.old/Makefile mod_perl2/Makefile
--- mod_perl2.old/Makefile	Fri Oct 21 20:04:57 2005
+++ mod_perl2/Makefile	Mon Dec 12 23:39:45 2005
@@ -16,8 +16,7 @@
 MAINTAINER=	lars.eggert@gmx.net
 COMMENT=	Embeds a Perl interpreter in the Apache2 server
 
-USE_APACHE=	yes
-WITH_APACHE2=	yes
+USE_APACHE=	2.0+
 PERL_CONFIGURE=	yes
 GMAKE=		yes
 
@@ -74,14 +73,14 @@
 .endif
 
 post-install:
-	${MKDIR} ${PREFIX}/include/apache2/modules/perl
+	${MKDIR} ${PREFIX}/${APACHEINCLUDEDIR}/modules/perl
 	${INSTALL_DATA} ${WRKSRC}/src/modules/perl/*.h \
-		${PREFIX}/include/apache2/modules/perl
-	${INSTALL_DATA} ${WRKSRC}/xs/*.h ${PREFIX}/include/apache2
-	${INSTALL_DATA} ${WRKSRC}/xs/APR/PerlIO/*.h ${PREFIX}/include/apache2
-	${MKDIR} ${PREFIX}/libexec/apache2
+		${PREFIX}/${APACHEINCLUDEDIR}/modules/perl
+	${INSTALL_DATA} ${WRKSRC}/xs/*.h ${PREFIX}/${APACHEINCLUDEDIR}
+	${INSTALL_DATA} ${WRKSRC}/xs/APR/PerlIO/*.h ${PREFIX}/${APACHEINCLUDEDIR}
+	${MKDIR} ${PREFIX}/${APACHEMODDIR}
 	${INSTALL_PROGRAM} ${WRKSRC}/src/modules/perl/mod_perl.so \
-		${PREFIX}/libexec/apache2/mod_perl.so
+		${PREFIX}/${APACHEMODDIR}/mod_perl.so
 	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.post.mk>
diff -urN mod_perl2.old/pkg-plist mod_perl2/pkg-plist
--- mod_perl2.old/pkg-plist	Fri Oct 21 20:04:57 2005
+++ mod_perl2/pkg-plist	Mon Dec 12 23:54:56 2005
@@ -1,56 +1,56 @@
 bin/mp2bug
-include/apache2/modperl_apr_perlio.h
-include/apache2/modperl_xs_sv_convert.h
-include/apache2/modperl_xs_typedefs.h
-include/apache2/modperl_xs_util.h
-include/apache2/modules/perl/mod_perl.h
-include/apache2/modules/perl/modperl_apache_compat.h
-include/apache2/modules/perl/modperl_apache_includes.h
-include/apache2/modules/perl/modperl_apr_compat.h
-include/apache2/modules/perl/modperl_apr_includes.h
-include/apache2/modules/perl/modperl_bucket.h
-include/apache2/modules/perl/modperl_callback.h
-include/apache2/modules/perl/modperl_cgi.h
-include/apache2/modules/perl/modperl_cmd.h
-include/apache2/modules/perl/modperl_common_debug.h
-include/apache2/modules/perl/modperl_common_includes.h
-include/apache2/modules/perl/modperl_common_log.h
-include/apache2/modules/perl/modperl_common_types.h
-include/apache2/modules/perl/modperl_common_util.h
-include/apache2/modules/perl/modperl_config.h
-include/apache2/modules/perl/modperl_const.h
-include/apache2/modules/perl/modperl_constants.h
-include/apache2/modules/perl/modperl_debug.h
-include/apache2/modules/perl/modperl_directives.h
-include/apache2/modules/perl/modperl_env.h
-include/apache2/modules/perl/modperl_error.h
-include/apache2/modules/perl/modperl_filter.h
-include/apache2/modules/perl/modperl_flags.h
-include/apache2/modules/perl/modperl_global.h
-include/apache2/modules/perl/modperl_gtop.h
-include/apache2/modules/perl/modperl_handler.h
-include/apache2/modules/perl/modperl_hooks.h
-include/apache2/modules/perl/modperl_interp.h
-include/apache2/modules/perl/modperl_io.h
-include/apache2/modules/perl/modperl_io_apache.h
-include/apache2/modules/perl/modperl_largefiles.h
-include/apache2/modules/perl/modperl_log.h
-include/apache2/modules/perl/modperl_mgv.h
-include/apache2/modules/perl/modperl_module.h
-include/apache2/modules/perl/modperl_options.h
-include/apache2/modules/perl/modperl_pcw.h
-include/apache2/modules/perl/modperl_perl.h
-include/apache2/modules/perl/modperl_perl_global.h
-include/apache2/modules/perl/modperl_perl_includes.h
-include/apache2/modules/perl/modperl_perl_pp.h
-include/apache2/modules/perl/modperl_perl_unembed.h
-include/apache2/modules/perl/modperl_svptr_table.h
-include/apache2/modules/perl/modperl_sys.h
-include/apache2/modules/perl/modperl_time.h
-include/apache2/modules/perl/modperl_tipool.h
-include/apache2/modules/perl/modperl_trace.h
-include/apache2/modules/perl/modperl_types.h
-include/apache2/modules/perl/modperl_util.h
+%%APACHEINCLUDEDIR%%/modperl_apr_perlio.h
+%%APACHEINCLUDEDIR%%/modperl_xs_sv_convert.h
+%%APACHEINCLUDEDIR%%/modperl_xs_typedefs.h
+%%APACHEINCLUDEDIR%%/modperl_xs_util.h
+%%APACHEINCLUDEDIR%%/modules/perl/mod_perl.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_apache_compat.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_apache_includes.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_apr_compat.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_apr_includes.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_bucket.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_callback.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_cgi.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_cmd.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_common_debug.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_common_includes.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_common_log.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_common_types.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_common_util.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_config.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_const.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_constants.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_debug.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_directives.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_env.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_error.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_filter.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_flags.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_global.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_gtop.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_handler.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_hooks.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_interp.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_io.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_io_apache.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_largefiles.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_log.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_mgv.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_module.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_options.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_pcw.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_perl.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_perl_global.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_perl_includes.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_perl_pp.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_perl_unembed.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_svptr_table.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_sys.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_time.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_tipool.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_trace.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_types.h
+%%APACHEINCLUDEDIR%%/modules/perl/modperl_util.h
 %%SITE_PERL%%/%%PERL_ARCH%%/APR.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/Base64.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/Brigade.pm
@@ -70,6 +70,7 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/Status.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/String.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/Table.pm
+%%SITE_PERL%%/%%PERL_ARCH%%/APR/ThreadMutex.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/URI.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/UUID.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/APR/Util.pm
@@ -208,6 +209,8 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/String/String.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Table/Table.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Table/Table.so
+%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/ThreadMutex/ThreadMutex.bs
+%%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/ThreadMutex/ThreadMutex.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/URI/URI.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/URI/URI.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/UUID/UUID.bs
@@ -270,7 +273,7 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/ModPerl/Util/Util.so
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/mod_perl2/.packlist
 %%SITE_PERL%%/%%PERL_ARCH%%/mod_perl2.pm
-libexec/apache2/mod_perl.so
+%%APACHEMODDIR%%/mod_perl.so
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/mod_perl2
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/ModPerl/Util
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/ModPerl/Global
@@ -304,6 +307,7 @@
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Util
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/UUID
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/URI
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/ThreadMutex
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Table
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/String
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/APR/Status
@@ -329,6 +333,6 @@
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Apache2
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Apache
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/APR
-@dirrm include/apache2/modules/perl
-@unexec rmdir %D/include/apache2/modules 2>/dev/null || true
-@unexec rmdir %D/include/apache2 2>/dev/null || true
+@dirrm %%APACHEINCLUDEDIR%%/modules/perl
+@unexec rmdir %D/%%APACHEINCLUDEDIR%%/modules 2>/dev/null || true
+@unexec rmdir %D/%%APACHEINCLUDEDIR%% 2>/dev/null || true
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Dec 12 23:12:47 UTC 2005 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90312 

From: Lars Eggert <lars.eggert@netlab.nec.de>
To: bug-followup@FreeBSD.org, sime@logos.hr
Cc:  
Subject: Re: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 10:13:33 +0100

 Hi,
 
 this appears to be OK, but note that I can only test mod_perl2 with  
 apache20. If we put this patch in (and not just make mod_perl2  
 apache20-compatible only), how are we dealing with testing  
 compatibility in the future?
 
 Lars
 --
 Lars Eggert                                     NEC Network Laboratories
 

From: =?iso-8859-2?Q?=A9imun_Mikecin?= <simun.mikecin@logos.hr>
To: "Lars Eggert" <lars.eggert@netlab.nec.de>,
	<bug-followup@freebsd.org>
Cc:  
Subject: RE: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 10:18:55 +0100

 Do you suggest making another port of mod_perl2 that works only with
 apache22? I don't agree with that.
 Other ports don't work that way either. For example, php5 port has the
 similar apache version detection.
 If the maintainer is not able to test some of the functionality then he
 should find someone else to do the testing for him.
 Apache 2.2 is stable, and I'm not the only one that needs mod_perl2 with
 it.

From: Lars Eggert <lars.eggert@netlab.nec.de>
To: =?WINDOWS-1252?Q?=8Aimun_Mikecin?= <simun.mikecin@logos.hr>
Cc: <bug-followup@freebsd.org>
Subject: Re: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 11:16:09 +0100

 On Dec 13, 2005, at 10:18, =8Aimun Mikecin wrote:
 > Do you suggest making another port of mod_perl2 that works only with
 > apache22? I don't agree with that.
 
 apache20, actually.
 
 > Other ports don't work that way either. For example, php5 port has the
 > similar apache version detection.
 > If the maintainer is not able to test some of the functionality =20
 > then he
 > should find someone else to do the testing for him.
 
 Well, do *you* volunteer to test apache21 and apache22 whenever I =20
 make a change to the mod_perl2 port?
 
 > Apache 2.2 is stable, and I'm not the only one that needs mod_perl2 =20=
 
 > with
 > it.
 
 Lars
 --
 Lars Eggert                                     NEC Network Laboratories
 

From: =?iso-8859-2?Q?=A9imun_Mikecin?= <simun.mikecin@logos.hr>
To: "Lars Eggert" <lars.eggert@netlab.nec.de>,
	<bug-followup@freebsd.org>
Cc:  
Subject: RE: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 12:51:24 +0100

 Just like the maintainership of the port does not mean you will *always*
 take care of bugfixing, updating and resolving problems, I cannot be a
 tester whenever you make a change. Port maintanership is based on doing
 it on best-effort basis as time permits, so is my help with testing.
 Nobody is paid to do it. Beside maintaining a few ports, I do testing
 for other maintainers in the environment they cant do the testing
 themself. It is usually testing on different hardware or different
 architecture. It would be a very bad thing for them to have an attitude
 to refuse to support other architectures just because they can test it
 only on (for example) i386.

From: Lars Eggert <lars.eggert@netlab.nec.de>
To: =?WINDOWS-1252?Q?=8Aimun_Mikecin?= <simun.mikecin@logos.hr>
Cc: <bug-followup@freebsd.org>
Subject: Re: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 13:13:23 +0100

 On Dec 13, 2005, at 12:51, =8Aimun Mikecin wrote:
 > Just like the maintainership of the port does not mean you will =20
 > *always*
 > take care of bugfixing, updating and resolving problems, I cannot be a
 > tester whenever you make a change. Port maintanership is based on =20
 > doing
 > it on best-effort basis as time permits, so is my help with testing.
 > Nobody is paid to do it.
 
 I am well aware of what port maintainership entails.
 
 > Beside maintaining a few ports, I do testing
 > for other maintainers in the environment they cant do the testing
 > themself. It is usually testing on different hardware or different
 > architecture.
 
 Hence my question if you were wiling to do the same for mod_perl2. =20
 Apparently, you aren't, which is fine of course.
 
 > It would be a very bad thing for them to have an attitude
 > to refuse to support other architectures just because they can test it
 > only on (for example) i386.
 
 I'm not refusing anything. I'm pointing out that adding support for =20
 configurations I can't test may create problems, because people will =20
 expect those configurations to work when I cannot test them.
 
 I'm open for constructive suggestions on how to deal with this. One =20
 way would be someone that can test these configurations and provide =20
 feedback. Another - worse - way is to temporarily disable those =20
 configurations, to avoid violating POLA ("well, it compiled, so it =20
 must run correctly, too").
 
 Lars
 --
 Lars Eggert                                     NEC Network Laboratories
 

From: =?iso-8859-2?Q?=A9imun_Mikecin?= <simun.mikecin@logos.hr>
To: "Lars Eggert" <lars.eggert@netlab.nec.de>,
	<bug-followup@freebsd.org>
Cc:  
Subject: RE: ports/90312: [patch] www/mod_perl2: added support for www/apache22
Date: Tue, 13 Dec 2005 14:06:32 +0100

 Don't get me wrong: I'm willing to help as my time and environment
 permits me to. No more, no less.
 If in some configuration it doesn't work, you can always mark it BROKEN
 in that case until someone comes with a solution.
State-Changed-From-To: feedback->closed 
State-Changed-By: barner 
State-Changed-When: Mon Dec 19 18:24:40 UTC 2005 
State-Changed-Why:  
Superceded by ports/90655 

http://www.freebsd.org/cgi/query-pr.cgi?pr=90312 
>Unformatted:
