From sem@fog.mbrd.ru  Mon Nov 21 12:12:16 2005
Return-Path: <sem@fog.mbrd.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 46BCA16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Nov 2005 12:12:16 +0000 (GMT)
	(envelope-from sem@fog.mbrd.ru)
Received: from fog.mbrd.ru (fog-mtu.mbrd.ru [195.34.35.73])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 92EC043D69
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Nov 2005 12:12:12 +0000 (GMT)
	(envelope-from sem@fog.mbrd.ru)
Received: from sem by fog.mbrd.ru with local (Exim 4.51 (FreeBSD))
	id 1EeAWm-0004SF-NI
	for FreeBSD-gnats-submit@freebsd.org; Mon, 21 Nov 2005 15:12:08 +0300
Message-Id: <E1EeAWm-0004SF-NI@fog.mbrd.ru>
Date: Mon, 21 Nov 2005 15:12:08 +0300
From: Sergey Matveychuk <sem@FreeBSD.org>
Sender: Sergey Matveychuk <sem@fog.mbrd.ru>
Reply-To: Sergey Matveychuk <sem@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: fetchindex does not respect FETCH_ENV from /etc/make.conf
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         89363
>Category:       ports
>Synopsis:       [patch] fetchindex does not respect FETCH_ENV from /etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 21 12:20:17 GMT 2005
>Closed-Date:    Thu Jan 12 04:18:18 GMT 2006
>Last-Modified:  Thu Jan 12 04:18:18 GMT 2006
>Originator:     Sergey Matveychuk
>Release:        FreeBSD 6.0-BETA5 i386
>Organization:
>Environment:
System: FreeBSD test1.mbrd.ru 6.0-BETA5 FreeBSD 6.0-BETA5 #12: Mon Sep 19 16:38:33 MSD 2005 root@test2.mbrd.ru:/usr/obj/usr/src/sys/TEST i386


	
>Description:
	
	Users, who set FETCH_ENV=http://proxy in /etc/make.conf
	has found 'make fetchindex' ignores their proxy.
>How-To-Repeat:
	
	Behind a firewall, put FETCH_ENV=http://your-proxy:port 
	into /etc/make.conf, go to ports dir and execute:
	make fetchindex

	The patch makes fetchindex behaviour more consistent.
>Fix:

	

--- fetchindex.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/Makefile,v
retrieving revision 1.91
diff -u -r1.91 Makefile
--- Makefile	8 Nov 2005 13:32:54 -0000	1.91
+++ Makefile	21 Nov 2005 12:03:39 -0000
@@ -71,9 +71,10 @@
 	@cd ${.CURDIR} && make ${.CURDIR}/${INDEXFILE}
 
 fetchindex:
-	@cd ${.CURDIR} && ${FETCHINDEX} ${MASTER_SITE_INDEX}/${INDEXFILE}.bz2 && bunzip2 -f ${INDEXFILE}.bz2 && chmod a+r ${INDEXFILE}
+	@cd ${.CURDIR} && ${SETENV} ${FETCH_ENV} ${FETCHINDEX} ${MASTER_SITE_INDEX}/${INDEXFILE}.bz2 && bunzip2 -f ${INDEXFILE}.bz2 && chmod a+r ${INDEXFILE}
 
 MASTER_SITE_INDEX?=	http://www.FreeBSD.org/ports/
+SETENV?=	/usr/bin/env
 FETCHINDEX?=	fetch -am
 INDEX_JOBS?=	2
 
--- fetchindex.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: sem 
Responsible-Changed-When: Mon Nov 21 12:21:04 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89363 

From: Sergey Matveychuk <sem@FreeBSD.org>
To: bug-followup@FreeBSD.org,  sem@FreeBSD.org
Cc:  
Subject: Re: ports/89363: fetchindex does not respect FETCH_ENV from /etc/make.conf
Date: Mon, 21 Nov 2005 15:29:28 +0300

 Just after I've submitted the PR I've found mnag's ports/89201.
 
 Only difference between them is: mnag does not use env(1).
 So, let's portmgr decide which one should be committed.
 -- 
 Sem.

Adding to audit trail by mcl:

We are going to use something based on this one rather than 89201, which
has been closed.
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Thu Jan 12 04:18:09 UTC 2006 
State-Changed-Why:  
Please see the combined patch in ports/89809 which attempts to fix 
multiple problems in this area. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=89363 
>Unformatted:
