From barner@gmx.de  Fri Nov 11 17:22:35 2005
Return-Path: <barner@gmx.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 982D616A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Nov 2005 17:22:35 +0000 (GMT)
	(envelope-from barner@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id 7657443D49
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Nov 2005 17:22:29 +0000 (GMT)
	(envelope-from barner@gmx.de)
Received: (qmail invoked by alias); 11 Nov 2005 17:22:27 -0000
Received: from unknown (EHLO zi025.glhnet.mhn.de) [129.187.19.157]
  by mail.gmx.net (mp031) with SMTP; 11 Nov 2005 18:22:27 +0100
Received: by zi025.glhnet.mhn.de (Postfix, from userid 1000)
	id B4A46C1B5; Fri, 11 Nov 2005 18:22:26 +0100 (CET)
Message-Id: <20051111172226.GF18306@zi025.glhnet.mhn.de>
Date: Fri, 11 Nov 2005 18:22:26 +0100
From: Simon Barner <barner@FreeBSD.org>
To: Vasil Dimov <vd@datamax.bg>
Cc: FreeBSD-gnats-submit@freebsd.org, matthias.andree@gmx.de,
	barner@FreeBSD.org
In-Reply-To: <20051111171256.GA56837@qlovarnika.bg.datamax>
Subject: Re: [patch] mail/fetchmail misses some messages since patch-imap.c
References: <20051111171256.GA56837@qlovarnika.bg.datamax>

>Number:         88851
>Category:       ports
>Synopsis:       Re: [patch] mail/fetchmail misses some messages since patch-imap.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 17:30:14 GMT 2005
>Closed-Date:    Fri Nov 11 20:02:24 GMT 2005
>Last-Modified:  Fri Nov 11 20:02:24 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 --6lCXDTVICvIQMz0h
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Vasil Dimov wrote:
 >=20
 > >Submitter-Id:	current-users
 > >Originator:	Vasil Dimov
 > >Organization:	DataMax
 > >Confidential:	no=20
 > >Synopsis:	[patch] mail/fetchmail misses some messages since patch-imap.c
 > >Severity:	non-critical
 > >Priority:	medium
 > >Category:	ports
 > >Class:		sw-bug
 > >Release:	FreeBSD 6.0-STABLE amd64
 > >Environment:
 >=20
 > >Description:
 >=20
 > Since files/patch-imap.c appeared fetchmail (sometimes) leaves one
 > message on the server.
 >=20
 > Here is dump of one erroneous session with packets from server dumped
 > to stdout. There is one message on the server, but fetchmail says
 > "No mail".
 >=20
 > IN >>> buf=3D* OK READY.
 > IN >>> buf=3D* CAPABILITY IMAP4REV1 SORT THREAD=3DREFERENCES MULTIAPPEND =
 UNSELECT LITERAL+ IDLE CHILDREN NAMESPACE LOGIN-REFERRALS AUTH=3DPLAIN
 > IN >>> buf=3DA0001 OK CAPABILITY COMPLETED.
 > IN >>> buf=3DA0002 OK LOGGED IN.
 > IN >>> buf=3D* FLAGS (\ANSWERED \FLAGGED \DELETED \SEEN \DRAFT)
 > IN >>> buf=3D* OK [PERMANENTFLAGS (\ANSWERED \FLAGGED \DELETED \SEEN \DRA=
 FT \*)] FLAGS PERMITTED.
 > IN >>> buf=3D* 1 EXISTS
 > IN >>> buf=3D* 0 RECENT
 > IN >>> buf=3D* OK [UIDVALIDITY 1130238900] UIDS VALID
 > IN >>> buf=3D* OK [UIDNEXT 166] PREDICTED NEXT UID
 > IN >>> buf=3DA0003 OK [READ-WRITE] SELECT COMPLETED.
 > IN >>> buf=3DA0004 OK EXPUNGE COMPLETED.
 > decreasing count, buf+2=3D004 OK EXPUNGE COMPLETED.
 > fetchmail: No mail for vd at localhost (folder freebsd-amd64)
 > IN >>> buf=3D* BYE LOGGING OUT
 > IN >>> buf=3DA0005 OK LOGOUT COMPLETED.
 >=20
 > Obviously buf+2 is in the middle of the fetchmail's tag, echoed by the
 > server, so atoi(buf+2) gives 4 in this case.
 >=20
 > Is this the intended operation?
 >=20
 > Maybe untagged command is expected here, eg "* 1 EXPUNGE"?
 > If this is true we should better go for the string after the first
 > space, instead of cutting the first two chars.
 >=20
 > >How-To-Repeat:
 >=20
 > >Fix:
 >=20
 > Be careful, I do not fully understand the meaning of the code I patched.
 >=20
 > --- fetchmail_count.diff begins here ---
 > diff -urN fetchmail.orig/Makefile fetchmail/Makefile
 > --- fetchmail.orig/Makefile	Fri Nov 11 02:21:03 2005
 > +++ fetchmail/Makefile	Fri Nov 11 18:45:32 2005
 > @@ -11,7 +11,7 @@
 > =20
 >  PORTNAME=3D	fetchmail
 >  PORTVERSION=3D	6.2.5.2
 > -PORTREVISION=3D	3
 > +PORTREVISION=3D	4
 >  CATEGORIES=3D	mail ipv6
 >  MASTER_SITES=3D	http://download.berlios.de/%SUBDIR%/:fetchmail_site,fetc=
 hmailconf_site \
 >  		http://www.catb.org/~esr/%SUBDIR%/:fetchmail_site \
 > diff -urN fetchmail.orig/files/patch-imap.c fetchmail/files/patch-imap.c
 > --- fetchmail.orig/files/patch-imap.c	Thu Nov 10 12:29:33 2005
 > +++ fetchmail/files/patch-imap.c	Fri Nov 11 18:43:44 2005
 > @@ -1,5 +1,5 @@
 > ---- ./imap.c.orig	2003-10-15 21:17:41.000000000 +0200
 > -+++ ./imap.c	2005-10-29 15:19:58.000000000 +0200
 > +--- imap.c.orig	Wed Oct 15 22:17:41 2003
 > ++++ imap.c	Fri Nov 11 18:43:23 2005
 >  @@ -105,6 +105,15 @@
 >   	{
 >   	    recentcount =3D atoi(buf+2);
 > @@ -8,7 +8,7 @@
 >  +	 * so count down by ourselves */
 >  +	else if (strstr(buf, " EXPUNGE"))
 >  +	{
 > -+	    if (atoi(buf+2) > 0) {
 > ++	    if (strstr(buf, " ") !=3D NULL && atoi(strstr(buf, " ") + 1) > 0) {
 >  +	       if (count > 0)
 >  +		   count --;
 >  +	    }
 > --- fetchmail_count.diff ends here ---
 
 I'll let Matthias comment on this first...
 
 --=20
 Best regards / Viele Gr=FC=DFe,                             barner@FreeBSD.=
 org
  Simon Barner                                                barner@gmx.de
 
 --6lCXDTVICvIQMz0h
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQFDdNNSCkn+/eutqCoRAnVBAKCTTtOwGLzfB8bToGq2zCSaHhef3wCg8E6U
 ZnS7a0pH0qLkjMZWt1ue+sY=
 =C+7t
 -----END PGP SIGNATURE-----
 
 --6lCXDTVICvIQMz0h--
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Fri Nov 11 20:01:44 GMT 2005 
State-Changed-Why:  
Misfiled followup to ports/88850. 


Responsible-Changed-From-To: gnats-admin->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Nov 11 20:01:44 GMT 2005 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=88851 
>Unformatted:
