From nobody@FreeBSD.org  Fri Nov 11 11:32:45 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5BF5416A41F
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2005 11:32:45 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0664443D46
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2005 11:32:45 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jABBWit9071562
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Nov 2005 11:32:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id jABBWiSh071560;
	Fri, 11 Nov 2005 11:32:44 GMT
	(envelope-from nobody)
Message-Id: <200511111132.jABBWiSh071560@www.freebsd.org>
Date: Fri, 11 Nov 2005 11:32:44 GMT
From: Zach Dykstra <md@anduin.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: HandBrake port build fails
X-Send-Pr-Version: www-2.3

>Number:         88838
>Category:       ports
>Synopsis:       HandBrake port build fails
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mezz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 11:40:15 GMT 2005
>Closed-Date:    Wed May 17 21:47:34 GMT 2006
>Last-Modified:  Wed May 17 21:47:34 GMT 2006
>Originator:     Zach Dykstra
>Release:        6.0-RELEASE
>Organization:
>Environment:
FreeBSD beren 6.0-RELEASE FreeBSD 6.0-RELEASE #1: Wed Nov  9 03:18:00 CST 2005     md@beren:/usr/src/sys/i386/compile/beren  i386
          
>Description:
When building the port multimedia/handbrake, the build fails on FreeBSD 6.0, with the latest ports tree (as of 11/11). Below is the build output:

beren# make install
===>  Building for handbrake-0.6.2_3
..found 205 target(s)...
..updating 4 target(s)...
Cc core/X264Enc.o
core/X264Enc.c: In function `HBX264EncInit':
core/X264Enc.c:44: error: structure has no member named `i_iframe'
core/X264Enc.c:45: error: structure has no member named `i_idrframe'
core/X264Enc.c:48: error: `X264_ANALYSE_I16x16' undeclared (first use in this function)
core/X264Enc.c:48: error: (Each undeclared identifier is reported only once
core/X264Enc.c:48: error: for each function it appears in.)
core/X264Enc.c:48: error: `X264_ANALYSE_P16x16' undeclared (first use in this function)
core/X264Enc.c:49: error: `X264_ANALYSE_P16x8' undeclared (first use in this function)
core/X264Enc.c:49: error: `X264_ANALYSE_P8x16' undeclared (first use in this function)
core/X264Enc.c:49: error: `X264_ANALYSE_P8x8' undeclared (first use in this function)
core/X264Enc.c:50: error: `X264_ANALYSE_SMART_PSUB' undeclared (first use in this function)
core/X264Enc.c:58: error: structure has no member named `i_width'
core/X264Enc.c:59: error: structure has no member named `i_height'
core/X264Enc.c:60: error: structure has no member named `i_plane'
core/X264Enc.c:62: error: structure has no member named `i_iframe'
core/X264Enc.c: In function `HBX264EncWork':
core/X264Enc.c:108: error: structure has no member named `i_stride'
core/X264Enc.c:109: error: structure has no member named `i_stride'
core/X264Enc.c:110: error: structure has no member named `i_stride'
core/X264Enc.c:112: error: structure has no member named `plane'
core/X264Enc.c:113: error: structure has no member named `plane'
core/X264Enc.c:113: error: structure has no member named `plane'
core/X264Enc.c:114: error: structure has no member named `plane'
core/X264Enc.c:114: error: structure has no member named `plane'
core/X264Enc.c:116: error: too few arguments to function `x264_encoder_encode'

cc -c -o core/X264Enc.o -O2 -fno-strict-aliasing -pipe -g -Wall -W -I/usr/local/include -DHB_FREEBSD -DHB_VERSION=\"0.6.2\" -Icore -I./contrib/libx264 core/X264Enc.c

..failed Cc core/X264Enc.o ...
..skipped libhb.a for lack of <core>X264Enc.o...
..skipped HBTest for lack of libhb.a...
..skipped gtk2HB for lack of libhb.a...
..failed updating 1 target(s)...
..skipped 3 target(s)...
*** Error code 1

Stop in /usr/ports/multimedia/handbrake.
>How-To-Repeat:
Build the hand brake port, the X264 ABI/API has changed from what the author expects. 
>Fix:
              
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->thompsa 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Nov 11 11:52:06 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88838 

From: Andrew Thompson <thompsa@freebsd.org>
To: bug-followup@FreeBSD.org, md@anduin.org
Cc:  
Subject: Re: ports/88838: HandBrake port build fails
Date: Sat, 12 Nov 2005 09:39:23 +1300

 This error happens if you have the multimedia/x264 port installed. You
 can move /usr/local/include/x264.h out of the way and handbrake will
 build sucessfully.
 
 Im working on upgrading to 0.7 and getting rid of this problem.
 
 
 Thanks for the PR,
 Andrew
State-Changed-From-To: open->analyzed 
State-Changed-By: vs 
State-Changed-When: Wed Nov 23 09:02:10 GMT 2005 
State-Changed-Why:  
Andrew suggested a workaround. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88838 
Responsible-Changed-From-To: thompsa->freebsd-ports-bugs 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Mon Mar 20 04:07:36 UTC 2006 
Responsible-Changed-Why:  
I gave up this port due to lack of time, hand over the PR too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88838 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: mezz 
State-Changed-When: Sun May 7 17:34:09 UTC 2006 
State-Changed-Why:  
Got same problem. I have committed the fix, so let me know if it is fix for 
you too. 


Responsible-Changed-From-To: freebsd-ports-bugs->mezz 
Responsible-Changed-By: mezz 
Responsible-Changed-When: Sun May 7 17:34:09 UTC 2006 
Responsible-Changed-Why:  
Got same problem. I have committed the fix, so let me know if it is fix for 
you too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88838 
State-Changed-From-To: feedback->closed 
State-Changed-By: mezz 
State-Changed-When: Wed May 17 21:47:01 UTC 2006 
State-Changed-Why:  
No respone for about ten days, it's fixed as far I can tell in my system. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88838 
>Unformatted:
