From pav@oook.cz  Wed Nov  9 21:57:08 2005
Return-Path: <pav@oook.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 654DA16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Nov 2005 21:57:08 +0000 (GMT)
	(envelope-from pav@oook.cz)
Received: from hood.oook.cz (hood.oook.cz [195.250.137.134])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9E97143D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Nov 2005 21:57:04 +0000 (GMT)
	(envelope-from pav@oook.cz)
Received: from ikaros.oook.cz (localhost [127.0.0.1])
	by hood.oook.cz (8.13.4/8.13.4) with ESMTP id jA9Lukk8084152
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 9 Nov 2005 22:56:52 +0100 (CET)
	(envelope-from pav@localhost.my.domain)
Received: (from pav@localhost)
	by ikaros.oook.cz (8.13.4/8.13.4/Submit) id jA9Luidv084151;
	Wed, 9 Nov 2005 22:56:44 +0100 (CET)
	(envelope-from pav)
Message-Id: <200511092156.jA9Luidv084151@ikaros.oook.cz>
Date: Wed, 9 Nov 2005 22:56:44 +0100 (CET)
From: Pav Lucistnik <pav@freebsd.org>
Reply-To: Pav Lucistnik <pav@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Make USE_REINPLACE noop
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         88754
>Category:       ports
>Synopsis:       Make USE_REINPLACE noop
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 09 22:00:18 GMT 2005
>Closed-Date:    Sat Jan 21 19:56:32 GMT 2006
>Last-Modified:  Sat Jan 21 19:56:32 GMT 2006
>Originator:     Pav Lucistnik
>Release:        FreeBSD 6.0-RC1 amd64
>Organization:
>Environment:
System: FreeBSD ikaros.oook.cz 6.0-RC1 FreeBSD 6.0-RC1 #0: Tue Nov 1 15:16:08 CET 2005 root@ikaros.oook.cz:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
In last batch of bsd.port.mk updates, old REINPLACE_CMD handling was removed.
Now the whole code consists of setting two make variables.

Because it no longer includes any external dependencies, I do propose to have
REINPLACE_CMD defined all the time, and that we remove USE_REINPLACE.

After this is committed, we can start removing USE_REINPLACE from individual
ports, slowly, over time.
>How-To-Repeat:
	
>Fix:

Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.518
diff -a -u -r1.518 bsd.port.mk
--- bsd.port.mk	8 Nov 2005 09:02:51 -0000	1.518
+++ bsd.port.mk	9 Nov 2005 21:55:17 -0000
@@ -1715,7 +1715,6 @@
 
 .if defined(PERL_CONFIGURE)
 USE_PERL5=	yes
-USE_REINPLACE=yes
 .endif
 
 .if ${PERL_LEVEL} >= 500600
@@ -1812,11 +1811,9 @@
 RUN_DEPENDS+=	gs:${PORTSDIR}/${GHOSTSCRIPT_PORT}
 .endif
 
-# Special macro for doing in-place file editing using regexps
-.if defined(USE_REINPLACE)
+# Macro for doing in-place file editing using regexps
 REINPLACE_ARGS?=	-i.bak
 REINPLACE_CMD?=	${SED} ${REINPLACE_ARGS}
-.endif
 
 # Names of cookies used to skip already completed stages
 EXTRACT_COOKIE?=	${WRKDIR}/.extract_done.${PKGNAME}.${PREFIX:S/\//_/g}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: pav 
Responsible-Changed-When: Wed Nov 9 22:04:53 GMT 2005 
Responsible-Changed-Why:  
Tasty sausages for portmgr (clement) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88754 
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Mon Dec 19 01:32:51 UTC 2005 
State-Changed-Why:  
Accepted for testing on the cluster. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88754 
State-Changed-From-To: analyzed->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 21 19:56:24 UTC 2006 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88754 
>Unformatted:
