From neuhauser@sigpipe.cz  Thu Nov  3 22:37:42 2005
Return-Path: <neuhauser@sigpipe.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7DE1116A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Nov 2005 22:37:42 +0000 (GMT)
	(envelope-from neuhauser@sigpipe.cz)
Received: from isis.sigpipe.cz (fw.sigpipe.cz [62.245.70.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 220B343D45
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Nov 2005 22:37:41 +0000 (GMT)
	(envelope-from neuhauser@sigpipe.cz)
Received: by isis.sigpipe.cz (Postfix, from userid 1001)
	id 0B05F1F87BED; Thu,  3 Nov 2005 23:37:40 +0100 (CET)
Message-Id: <20051103223740.0B05F1F87BED@isis.sigpipe.cz>
Date: Thu,  3 Nov 2005 23:37:40 +0100 (CET)
From: Roman Neuhauser <neuhauser@sigpipe.cz>
Reply-To: Roman Neuhauser <neuhauser@sigpipe.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         88471
>Category:       ports
>Synopsis:       [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 03 22:40:17 GMT 2005
>Closed-Date:    Fri Nov 04 09:18:15 GMT 2005
>Last-Modified:  Fri Nov  4 20:10:13 GMT 2005
>Originator:     Roman Neuhauser
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
>Environment:
>Description:
The attached patch prevents make fetch from trying MASTER_SITE_BACKUP
with RESTRICTED ports since that's futile by definition.

>How-To-Repeat:
	
>Fix:

	

--- Mk::bsd.port.mk,RESTRICTED-MASTER_SITE_BACKUP,0.patch begins here ---
Index: Mk/bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.517
diff -u -r1.517 bsd.port.mk
--- Mk/bsd.port.mk	15 Sep 2005 12:24:33 -0000	1.517
+++ Mk/bsd.port.mk	3 Nov 2005 22:17:40 -0000
@@ -2387,8 +2387,12 @@
 _MASTER_SITE_BACKUP:=	# empty
 .else
 _MASTER_SITE_OVERRIDE=	${MASTER_SITE_OVERRIDE}
+.if defined(RESTRICTED)
+_MASTER_SITE_BACKUP:=	# empty
+.else
 _MASTER_SITE_BACKUP=	${MASTER_SITE_BACKUP}
 .endif
+.endif
 
 # Search CDROM first if mounted, symlink instead of copy if
 # FETCH_SYMLINK_DISTFILES is set
--- Mk::bsd.port.mk,RESTRICTED-MASTER_SITE_BACKUP,0.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: garga 
Responsible-Changed-When: Fri Nov 4 09:11:20 GMT 2005 
Responsible-Changed-Why:  
portmgr territory. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88471 
State-Changed-From-To: open->closed 
State-Changed-By: kris 
State-Changed-When: Fri Nov 4 09:17:56 GMT 2005 
State-Changed-Why:  
Thanks for the submission, but this feature is actually used. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88471 

From: Kris Kennaway <kris@obsecurity.org>
To: Roman Neuhauser <neuhauser@sigpipe.cz>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/88471: [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
Date: Fri, 4 Nov 2005 04:17:40 -0500

 On Thu, Nov 03, 2005 at 11:37:40PM +0100, Roman Neuhauser wrote:
 > 
 > >Number:         88471
 > >Category:       ports
 > >Synopsis:       [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-ports-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Thu Nov 03 22:40:17 GMT 2005
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Roman Neuhauser
 > >Release:        FreeBSD 4.10-STABLE i386
 > >Organization:
 > >Environment:
 > >Description:
 > The attached patch prevents make fetch from trying MASTER_SITE_BACKUP
 > with RESTRICTED ports since that's futile by definition.
 
 It's not futile.  There's nothing wrong with setting
 MASTER_SITE_BACKUP to a private FTP site that contains the distfiles,
 and in fact this is what I do for package builds.
 
 Kris

From: Roman Neuhauser <neuhauser@sigpipe.cz>
To: Kris Kennaway <kris@obsecurity.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/88471: [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
Date: Fri, 4 Nov 2005 10:56:37 +0100

 # kris@obsecurity.org / 2005-11-04 04:17:40 -0500:
 > On Thu, Nov 03, 2005 at 11:37:40PM +0100, Roman Neuhauser wrote:
 > > >Number:         88471
 > > >Category:       ports
 > > >Synopsis:       [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
 
 > > The attached patch prevents make fetch from trying MASTER_SITE_BACKUP
 > > with RESTRICTED ports since that's futile by definition.
 > 
 > It's not futile.  There's nothing wrong with setting
 > MASTER_SITE_BACKUP to a private FTP site that contains the distfiles,
 > and in fact this is what I do for package builds.
 
     Ah, ok. Well, it is futile with the default settings, and, I'd
     hazard a guess, in the majority of uses. I'm thinking about adding
     a bit more code that'd empty _MASTER_SITE_BACKUP unless... Here
     comes the hard part. Any ideas?
 
 -- 
 How many Vietnam vets does it take to screw in a light bulb?
 You don't know, man.  You don't KNOW.
 Cause you weren't THERE.             http://bash.org/?255991

From: Kris Kennaway <kris@obsecurity.org>
To: Roman Neuhauser <neuhauser@sigpipe.cz>
Cc: Kris Kennaway <kris@obsecurity.org>, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/88471: [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP with RESTRICTED ports
Date: Fri, 4 Nov 2005 15:02:16 -0500

 --V0207lvV8h4k8FAm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Nov 04, 2005 at 10:56:37AM +0100, Roman Neuhauser wrote:
 > # kris@obsecurity.org / 2005-11-04 04:17:40 -0500:
 > > On Thu, Nov 03, 2005 at 11:37:40PM +0100, Roman Neuhauser wrote:
 > > > >Number:         88471
 > > > >Category:       ports
 > > > >Synopsis:       [PATCH] Mk/bsd.port.mk: don't try MASTER_SITE_BACKUP=
  with RESTRICTED ports
 >=20
 > > > The attached patch prevents make fetch from trying MASTER_SITE_BACKUP
 > > > with RESTRICTED ports since that's futile by definition.
 > >=20
 > > It's not futile.  There's nothing wrong with setting
 > > MASTER_SITE_BACKUP to a private FTP site that contains the distfiles,
 > > and in fact this is what I do for package builds.
 >=20
 >     Ah, ok. Well, it is futile with the default settings, and, I'd
 >     hazard a guess, in the majority of uses. I'm thinking about adding
 >     a bit more code that'd empty _MASTER_SITE_BACKUP unless... Here
 >     comes the hard part. Any ideas?
 
 I'd prefer to just leave it alone.  One extra fetch when the master
 sites do not work won't kill you.
 
 Kris
 
 --V0207lvV8h4k8FAm
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (FreeBSD)
 
 iD8DBQFDa75HWry0BWjoQKURAkwUAKDpfbR0kkFJzO9RUS4tC4uQBiKrCACfU9Pu
 odaf/NvsZYAlRvuzNpE5g0k=
 =hGle
 -----END PGP SIGNATURE-----
 
 --V0207lvV8h4k8FAm--
>Unformatted:
