From sheldonh@axl.training.iafrica.com  Mon Nov 23 01:49:08 1998
Received: from axl.training.iafrica.com (axl.training.iafrica.com [196.31.1.175])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA22477
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 Nov 1998 01:48:55 -0800 (PST)
          (envelope-from sheldonh@axl.training.iafrica.com)
Received: from sheldonh by axl.training.iafrica.com with local (Exim 2.053 #1)
	id 0zhsbJ-0002SZ-00
	for FreeBSD-gnats-submit@freebsd.org; Mon, 23 Nov 1998 11:48:09 +0200
Message-Id: <E0zhsbJ-0002SZ-00@axl.training.iafrica.com>
Date: Mon, 23 Nov 1998 11:48:09 +0200
From: axl@iafrica.com
Sender: Sheldon Hearn <sheldonh@axl.training.iafrica.com>
Reply-To: axl@iafrica.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] ports/mail/exim libident bug causes SEGV
X-Send-Pr-Version: 3.2

>Number:         8818
>Category:       ports
>Synopsis:       [PATCH] ports/mail/exim libident bug causes SEGV
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    markm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 23 01:50:02 PST 1998
>Closed-Date:    Fri Nov 27 00:53:19 PST 1998
>Last-Modified:  Fri Nov 27 00:54:47 PST 1998
>Originator:     Sheldon Hearn
>Release:        FreeBSD 2.2.7-STABLE i386
>Organization:
UUNET Internet Africa
>Environment:

	All environments.

>Description:

	Unexpected ident responses from connecting hosts cause SEGV in
	exim.

>How-To-Repeat:

	See exim mailing list archives (http://www.exim.org/) for
	discussion (around 10 Nov 1998).

>Fix:
	
	Apply the following patch to the port to create patch-ae:

diff -urN exim.orig/patches/patch-ae exim/patches/patch-ae
--- exim.orig/patches/patch-ae	Mon Nov 23 11:33:59 1998
+++ exim/patches/patch-ae	Mon Nov 23 11:32:05 1998
@@ -0,0 +1,19 @@
+*** src/libident/id_parse.c.orig      Fri Sep 18 04:13:13 1998
+--- src/libident/id_parse.c   Tue Nov 10 17:29:23 1998
+***************
+*** 198,204 ****
+        else
+            cp = id_strtok((char *)0, "\n\r", &c);
+  
+!       if (identifier)
+        {
+            *identifier = id_strdup(cp);
+            if (*identifier == NULL)
+--- 198,204 ----
+        else
+            cp = id_strtok((char *)0, "\n\r", &c);
+  
+!       if (identifier && cp)
+        {
+            *identifier = id_strdup(cp);
+            if (*identifier == NULL)
>Release-Note:
>Audit-Trail:

From: Sheldon Hearn <axl@iafrica.com>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports@freebsd.org
Cc:  Subject: Re: ports/8818: [PATCH] ports/mail/exim libident bug causes SEGV 
Date: Mon, 23 Nov 1998 12:44:37 +0200

 Damnit! Wrong patch sent. Please ignore the previous patch and apply the
 one that follows.
 
 Thanks,
 Sheldon.
 
 diff -urN exim.orig/patches/patch-ae exim/patches/patch-ae
 --- exim.orig/patches/patch-ae	Thu Jan  1 02:00:00 1970
 +++ exim/patches/patch-ae	Mon Nov 23 11:58:34 1998
 @@ -0,0 +1,9 @@
 +--- src/libident/id_parse.c.orig	Mon Nov 23 11:58:02 1998
 ++++ src/libident/id_parse.c	Mon Nov 23 11:58:15 1998
 +@@ -199,5 +199,5 @@
 + 	    cp = id_strtok((char *)0, "\n\r", &c);
 + 
 +-	if (identifier)
 ++	if (identifier && cp)
 + 	{
 + 	    *identifier = id_strdup(cp);
State-Changed-From-To: open->closed 
State-Changed-By: markm 
State-Changed-When: Fri Nov 27 00:53:19 PST 1998 
State-Changed-Why:  
Supplied patch applied 


Responsible-Changed-From-To: freebsd-ports->markm 
Responsible-Changed-By: markm 
Responsible-Changed-When: Fri Nov 27 00:53:19 PST 1998 
Responsible-Changed-Why:  
My commit. 
>Unformatted:
