From dom@djdomics.sceen.net  Thu Oct 27 18:44:12 2005
Return-Path: <dom@djdomics.sceen.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7B4A816A420
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Oct 2005 18:44:12 +0000 (GMT)
	(envelope-from dom@djdomics.sceen.net)
Received: from djdomics.sceen.net (rai93-2-82-231-187-222.fbx.proxad.net [82.231.187.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A040F43D66
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Oct 2005 18:44:06 +0000 (GMT)
	(envelope-from dom@djdomics.sceen.net)
Received: from djdomics.sceen.net (localhost [127.0.0.1])
	by djdomics.sceen.net (8.13.4/8.13.4) with ESMTP id j9RIhgip057753
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Oct 2005 20:43:42 +0200 (CEST)
	(envelope-from dom@djdomics.sceen.net)
Received: (from dom@localhost)
	by djdomics.sceen.net (8.13.4/8.13.1/Submit) id j9RIhfwq057671;
	Thu, 27 Oct 2005 20:43:41 +0200 (CEST)
	(envelope-from dom)
Message-Id: <200510271843.j9RIhfwq057671@djdomics.sceen.net>
Date: Thu, 27 Oct 2005 20:43:41 +0200 (CEST)
From: Dominique Goncalves <dominique.goncalves@gmail.com>
Reply-To: Dominique Goncalves <dominique.goncalves@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] fix a bug when inserting a disk in sysutils/gnomebaker	
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         88089
>Category:       ports
>Synopsis:       [PATCH] fix a bug when inserting a disk in sysutils/gnomebaker
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    mnag
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 27 18:50:06 GMT 2005
>Closed-Date:    Fri Oct 28 02:59:32 GMT 2005
>Last-Modified:  Fri Oct 28 02:59:32 GMT 2005
>Originator:     Dominique Goncalves
>Release:        FreeBSD 6.0-RC1 i386
>Organization:
djdomics.sceen.net	
>Environment:
System: FreeBSD djdomics.sceen.net 6.0-RC1 FreeBSD 6.0-RC1 #14: Sun Oct 16 13:29:45 CEST 2005 dom@venus:/usr/obj/usr/src/sys/VENUS i386


>Description:
	Fix a bug when inserting a disk.
	Reported and tested by: Danilo Augusto Vicente Lara daniloavl_at_terra.com.br
	Obtained from: gnomebaker cvs http://cvs.sourceforge.net/viewcvs.py/gnomebaker/gnomebaker/src/devices.c?r1=1.22&r2=1.23
	
>How-To-Repeat:
	Insert a disk, click ok and it continues to ask about the cd on drive. 

>Fix:

	Patch from gnomebaker cvs of src/devices.c revision 1.23

--- gnomebaker_update_p2.patch begins here ---
diff -ruN gnomebaker.orig/Makefile gnomebaker/Makefile
--- gnomebaker.orig/Makefile	Thu Oct 27 19:33:54 2005
+++ gnomebaker/Makefile	Thu Oct 27 19:34:52 2005
@@ -6,7 +6,7 @@
 
 PORTNAME=		gnomebaker
 PORTVERSION=		0.5.0
-PORTREVISION=		1
+PORTREVISION=		2	
 CATEGORIES=		sysutils gnome
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	gnomebaker
diff -ruN gnomebaker.orig/files/patch-src-devices.c gnomebaker/files/patch-src-devices.c
--- gnomebaker.orig/files/patch-src-devices.c	Thu Jan  1 01:00:00 1970
+++ gnomebaker/files/patch-src-devices.c	Wed Oct 26 22:16:48 2005
@@ -0,0 +1,12 @@
+--- src/devices.c.orig	Wed Oct 26 22:12:18 2005
++++ src/devices.c	Wed Oct 26 22:12:41 2005
+@@ -779,7 +779,8 @@
+     gchar* devicename = devices_get_device_config(devicekey, GB_DEVICE_NAME_LABEL);
+     gchar* message = g_strdup_printf(_("Please insert a disk into the %s"), devicename);    
+     gint ret = GTK_RESPONSE_OK;
+-    while(!devices_is_disk_inserted(devicekey) && (ret == GTK_RESPONSE_OK))
++    /* while(!devices_is_disk_inserted(devicekey) && (ret == GTK_RESPONSE_OK)) */
++    if(!devices_is_disk_inserted(devicekey))
+     {
+         devices_eject_disk(devicekey);
+         ret = gnomebaker_show_msg_dlg(parent, GTK_MESSAGE_INFO, 
--- gnomebaker_update_p2.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mnag 
Responsible-Changed-By: mnag 
Responsible-Changed-When: Fri Oct 28 02:03:41 GMT 2005 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88089 
State-Changed-From-To: open->closed 
State-Changed-By: mnag 
State-Changed-When: Fri Oct 28 02:59:30 GMT 2005 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=88089 
>Unformatted:
