From cperciva@hexahedron.daemonology.net  Sat Sep 17 23:05:11 2005
Return-Path: <cperciva@hexahedron.daemonology.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 60C9416A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Sep 2005 23:05:11 +0000 (GMT)
	(envelope-from cperciva@hexahedron.daemonology.net)
Received: from hexahedron.daemonology.net (S0106006067227a4a.vc.shawcable.net [24.87.209.6])
	by mx1.FreeBSD.org (Postfix) with SMTP id 867DE43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Sep 2005 23:05:10 +0000 (GMT)
	(envelope-from cperciva@hexahedron.daemonology.net)
Received: (qmail 31543 invoked by uid 1001); 17 Sep 2005 23:05:09 -0000
Message-Id: <20050917230509.31542.qmail@hexahedron.daemonology.net>
Date: 17 Sep 2005 23:05:09 -0000
From: Colin Percival <cperciva@freebsd.org>
Reply-To: Colin Percival <cperciva@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Additional commentary for describes target in bsd.port.mk
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         86281
>Category:       ports
>Synopsis:       Additional commentary for describes target in bsd.port.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 17 23:10:03 GMT 2005
>Closed-Date:    Sat Jan 21 19:51:33 GMT 2006
>Last-Modified:  Sat Jan 21 19:51:33 GMT 2006
>Originator:     Colin Percival
>Release:        FreeBSD 5.4-SECURITY i386
>Organization:
>Environment:
System: FreeBSD hexahedron.daemonology.net 5.4-SECURITY FreeBSD 5.4-SECURITY #0: Wed Jul 20 08:57:11 UTC 2005 root@builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386

>Description:

Portsnap uses the data format of "make describes" in an externally-visible
manner.  If this format ever changes, portsnap will need to adjust.

>How-To-Repeat:
>Fix:

Document in bsd.port.mk that portmgr should contact the portsnap 
maintainer before changing the format output by "make describe".

--- bsd.port.mk.diff begins here ---
Index: ports/Mk/bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.517
diff -u -p -r1.517 bsd.port.mk
--- ports/Mk/bsd.port.mk	15 Sep 2005 12:24:33 -0000	1.517
+++ ports/Mk/bsd.port.mk	17 Sep 2005 23:01:17 -0000
@@ -4676,6 +4676,9 @@ package-recursive: package
 # distribution-name|port-path|installation-prefix|comment| \
 #  description-file|maintainer|categories|extract-depends| \
 #  patch-depends|fetch-depends|build-depends|run-depends|www site
+#
+# If this ever changes, portmgr should contact the portsnap maintainer
+# first to avoid gratuitous breakage.
 
 .if !target(describe)
 describe:
--- bsd.port.mk.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: cperciva 
Responsible-Changed-When: Sat Sep 17 23:21:22 GMT 2005 
Responsible-Changed-Why:  
bsd.port.mk PRs belong to portmgr, I think. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86281 
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Mon Dec 19 01:30:22 UTC 2005 
State-Changed-Why:  
Accepted for testing on the cluster. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86281 
State-Changed-From-To: analyzed->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 21 19:51:23 UTC 2006 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86281 
>Unformatted:
