From matthew@thebunker.net  Tue Sep 13 18:44:06 2005
Return-Path: <matthew@thebunker.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33D1D16A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Sep 2005 18:44:06 +0000 (GMT)
	(envelope-from matthew@thebunker.net)
Received: from male.aldigital.co.uk (male.thebunker.net [213.129.64.13])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B4CCF43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Sep 2005 18:44:05 +0000 (GMT)
	(envelope-from matthew@thebunker.net)
Received: from lack-of-gravitas.thebunker.net (gateway.ash.thebunker.net [213.129.64.4])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by male.aldigital.co.uk (Postfix) with ESMTP
	id D13F8976F9; Tue, 13 Sep 2005 19:44:04 +0100 (BST)
Received: from lack-of-gravitas.thebunker.net (localhost [127.0.0.1])
	by lack-of-gravitas.thebunker.net (8.13.4/8.13.4) with ESMTP id j8DIi4ba095758;
	Tue, 13 Sep 2005 19:44:04 +0100 (BST)
	(envelope-from matthew@lack-of-gravitas.thebunker.net)
Received: (from matthew@localhost)
	by lack-of-gravitas.thebunker.net (8.13.4/8.13.4/Submit) id j8DIi4Pa095757;
	Tue, 13 Sep 2005 19:44:04 +0100 (BST)
	(envelope-from matthew)
Message-Id: <200509131844.j8DIi4Pa095757@lack-of-gravitas.thebunker.net>
Date: Tue, 13 Sep 2005 19:44:04 +0100 (BST)
From: Matthew Seaman <m.seaman@infracaninophile.co.uk>
Reply-To: Matthew Seaman <m.seaman@infracaninophile.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: herve.quiroz@esil.univ-mrs.fr
Subject: [maintainer] databases/mysql-connector-java improve installation of documentation
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         86088
>Category:       ports
>Synopsis:       [maintainer] databases/mysql-connector-java improve installation of documentation
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    hq
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 13 18:50:03 GMT 2005
>Closed-Date:    Wed Sep 14 16:42:18 GMT 2005
>Last-Modified:  Wed Sep 14 16:42:18 GMT 2005
>Originator:     Matthew Seaman
>Release:        FreeBSD 6.0-BETA3 i386
>Organization:
Infracaninophile
>Environment:
System: FreeBSD lack-of-gravitas.thebunker.net 6.0-BETA3 FreeBSD 6.0-BETA3 #3: Tue Aug 30 13:36:31 BST 2005 root@lack-of-gravitas.thebunker.net:/usr/obj/usr/src/sys/LACK-OF-GRAVITAS i386


	
>Description:

As suggested by Herve Quiroz in an e-mail conversation quite some time
ago now, instead of using ${CP} -r to install javadocs, use ${FIND}
with ${MKDIR} and ${INSTALL_DATA} to ensure that ownerships and
permissions come out right when port is built as a mortal user then
installed as root.

>How-To-Repeat:
	
>Fix:

	

--- mysql-connector-java.diff begins here ---
diff -Nur /usr/ports/databases/mysql-connector-java/Makefile mysql-connector-java/Makefile
--- /usr/ports/databases/mysql-connector-java/Makefile	Thu Jul  7 08:37:50 2005
+++ mysql-connector-java/Makefile	Tue Sep 13 19:34:33 2005
@@ -89,7 +89,14 @@
 .if !defined(NOPORTDOCS)
 	@${ECHO_MSG} -n ">> Installing documentation in ${DOCSDIR}..."
 	@${MKDIR} ${APIDOCSDIR}
-	@${CP} -r ${JAVADOCDIR}/* ${APIDOCSDIR}
+	@cd ${JAVADOCDIR} && for src in $$( ${FIND} . ) ; do \
+	    dst=${APIDOCSDIR}$${src#.} ; \
+	    if ${TEST} -d $$src ; then \
+	        ${MKDIR} $$dst ; \
+	    else \
+	        ${INSTALL_DATA} $$src $$dst ; \
+	    fi \
+	done
 	@for extradoc in ${EXTRADOCS} ; do                          \
 	  ${INSTALL_DATA} ${INSTALL_WRKSRC}/$$extradoc ${DOCSDIR} ; \
 	done
--- mysql-connector-java.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->hq 
Responsible-Changed-By: hq 
Responsible-Changed-When: Tue Sep 13 19:41:21 GMT 2005 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86088 
State-Changed-From-To: open->closed 
State-Changed-By: hq 
State-Changed-When: Wed Sep 14 16:42:08 GMT 2005 
State-Changed-Why:  
Patch commited. 

Thanks for your contribution! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=86088 
>Unformatted:
