From nivit@email.it  Wed Aug  3 17:08:03 2005
Return-Path: <nivit@email.it>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2470416A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  3 Aug 2005 17:08:03 +0000 (GMT)
	(envelope-from nivit@email.it)
Received: from vsmtp14.tin.it (vsmtp14.tin.it [212.216.176.118])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BEFD343D46
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  3 Aug 2005 17:08:02 +0000 (GMT)
	(envelope-from nivit@email.it)
Received: from stellina (82.52.76.189) by vsmtp14.tin.it (7.2.060.1)
        id 42E2842D004912E3 for FreeBSD-gnats-submit@freebsd.org; Wed, 3 Aug 2005 19:07:59 +0200
Received: (qmail 12315 invoked by uid 0); 3 Aug 2005 18:55:25 +0200
Message-Id: <20050803165525.12314.qmail@stellina>
Date: 3 Aug 2005 18:55:25 +0200
From: Nicola Vitale <nivit@email.it>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rzinkov@gmail.com
Subject: [PATCH] audio/moc: missing dependency (audio/libid3tag) for MP3 support 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         84526
>Category:       ports
>Synopsis:       [PATCH] audio/moc: missing dependency (audio/libid3tag) for MP3 support
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    lawrance
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 03 17:10:10 GMT 2005
>Closed-Date:    Fri Aug 05 02:17:29 GMT 2005
>Last-Modified:  Fri Aug 05 02:17:29 GMT 2005
>Originator:     Nicola Vitale
>Release:        FreeBSD 5.4-RELEASE-p4 i386
>Organization:
>Environment:

System: FreeBSD stellina.domo.sva 5.4-RELEASE-p4 FreeBSD 5.4-RELEASE-p4 #1: Sat Jul 16 15:18:36 CEST 2005

>Description:

It seems that moc requires libid3tag to build with MP3 support,
but such library is not in LIB_DEPENDS.
 
Port maintainer (rzinkov@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.63

>How-To-Repeat:

# cd /usr/ports/audio/moc; make install
[...]
checking for id3_file_open in -lid3tag... no
configure: error: You need libid3tag to play mp3, check the README file.
===>  Script "configure" failed unexpectedly.
Please report the problem to rzinkov@gmail.com [maintainer] and attach the
"/mnt/ufs-ad1s1e/ports/audio/moc/work/moc-2.3.0/config.log" including the
output of the failure of your make command. Also, it might be a good idea to
provide an overview of all packages installed on your system (e.g. an `ls
/var/db/pkg`).
*** Error code 1

Stop in /mnt/ufs-ad1s1e/ports/audio/moc.

>Fix:

--- moc-2.3.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/audio/moc/Makefile /mnt/ufs-ad1s1e/ports/audio/moc.my/Makefile
--- /usr/ports/audio/moc/Makefile	Tue Aug  2 11:46:19 2005
+++ /mnt/ufs-ad1s1e/ports/audio/moc.my/Makefile	Wed Aug  3 18:39:44 2005
@@ -48,7 +48,8 @@
 .endif
 
 .if defined(WITH_MP3)
-LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad
+LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad \
+		id3tag.2:${PORTSDIR}/audio/libid3tag
 PLIST_FILES+=	lib/moc/decoder_plugins/libmp3_decoder.so
 .else
 CONFIGURE_ARGS+=	--without-mp3
--- moc-2.3.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lawrance 
Responsible-Changed-By: lawrance 
Responsible-Changed-When: Thu Aug 4 05:36:25 GMT 2005 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84526 
State-Changed-From-To: open->feedback 
State-Changed-By: lawrance 
State-Changed-When: Thu Aug 4 14:19:26 GMT 2005 
State-Changed-Why:  
Maintainer was asked to review changes 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84526 

From: Sam Lawrance <lawrance@FreeBSD.org>
To: rzinkov@gmail.com, nivit@email.it, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/84526: [PATCH] audio/moc: missing dependency
	(audio/libid3tag) for MP3 support
Date: Fri, 05 Aug 2005 00:19:07 +1000

 Maintainer,
 
 What do you think about this patch:
 http://www.freebsd.org/cgi/query-pr.cgi?pr=84526
 
 I think it is useful - otherwise the port will fail as described if a
 user already has audio/madplay installed on its own (not installed
 through audio/mad).
 
 -- 
 Sam Lawrance                            lawrance@FreeBSD.org
 ph +61 0425 228 579                    boris@brooknet.com.au
 
 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: lawrance 
State-Changed-When: Fri Aug 5 02:15:45 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84526 
>Unformatted:
