From jdc@parodius.com  Thu Jul 28 07:57:53 2005
Return-Path: <jdc@parodius.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAE1116A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 28 Jul 2005 07:57:53 +0000 (GMT)
	(envelope-from jdc@parodius.com)
Received: from mx1.parodius.com (mx1.parodius.com [64.62.145.229])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A10F843D45
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 28 Jul 2005 07:57:53 +0000 (GMT)
	(envelope-from jdc@parodius.com)
Received: by mx1.parodius.com (Postfix, from userid 500)
	id 8D5F35E57; Thu, 28 Jul 2005 00:57:53 -0700 (PDT)
Message-Id: <20050728075753.8D5F35E57@mx1.parodius.com>
Date: Thu, 28 Jul 2005 00:57:53 -0700 (PDT)
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: net-mgmt/mrtg mistakingly deems IPv6 perl modules mandatory
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         84211
>Category:       ports
>Synopsis:       net-mgmt/mrtg mistakingly deems IPv6 perl modules mandatory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    demon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 28 08:00:32 GMT 2005
>Closed-Date:    Mon Sep 05 11:12:17 GMT 2005
>Last-Modified:  Mon Sep 05 11:12:17 GMT 2005
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Tue Jul 26 07:02:27 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
	The port mistakingly deems net/p5-IO-INET6 as a mandatory dependancy for
	mrtg.  This isn't the case; I took a look at the mrtg code, and support
	for IPv6 is optional, with proper perl code to detect if IPv6 modules
	are installed or not.

	Therefore, we should be honouring WITHOUT_IPV6 for this port.
>How-To-Repeat:
	Should be obvious.
>Fix:
	Apply below patch.


--- Makefile.orig	Tue Jul 26 03:13:47 2005
+++ Makefile	Tue Jul 26 03:13:02 2005
@@ -21,8 +21,7 @@
 COMMENT=	The multi-router traffic grapher
 
 RUN_DEPENDS=	${SITE_PERL}/SNMP_Session.pm:${PORTSDIR}/net-mgmt/p5-SNMP_Session \
-		${SITE_PERL}/Pod/Usage.pm:${PORTSDIR}/textproc/p5-Pod-Parser \
-		${SITE_PERL}/IO/Socket/INET6.pm:${PORTSDIR}/net/p5-IO-INET6
+		${SITE_PERL}/Pod/Usage.pm:${PORTSDIR}/textproc/p5-Pod-Parser
 
 LIB_DEPENDS=	gd.4:${PORTSDIR}/graphics/gd
 CONFIGURE_ARGS=	--with-gd-lib=${LOCALBASE}/lib \
@@ -40,6 +39,13 @@
 		mrtg-nw-guide.1 mrtg-reference.1 mrtg-rrd.1 mrtg-squid.1 \
 		mrtg-unix-guide.1 mrtg-webserver.1 mrtg.1 mrtglib.1
 
+.include <bsd.port.pre.mk>
+
+# IPv6 support is optional -- mrtg has code to support this
+.if !defined(WITHOUT_IPV6)
+RUN_DEPENDS+=	${SITE_PERL}/IO/Socket/INET6.pm:${PORTSDIR}/net/p5-IO-INET6
+.endif
+
 post-patch:
 	${RM} ${WRKSRC}/lib/mrtg2/BER.pm ${WRKSRC}/lib/mrtg2/SNMP_*.pm
 
@@ -72,4 +78,4 @@
 	@${ECHO} "############################################################################"
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->demon 
Responsible-Changed-By: lth 
Responsible-Changed-When: Thu Jul 28 15:07:19 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84211 
State-Changed-From-To: open->closed 
State-Changed-By: demon 
State-Changed-When: Mon Sep 5 11:12:01 GMT 2005 
State-Changed-Why:  
Patch committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84211 
>Unformatted:
