From pjd@tickbox.ctn.hosting.co.za  Tue Jul 26 11:53:51 2005
Return-Path: <pjd@tickbox.ctn.hosting.co.za>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5B8B116A41F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Jul 2005 11:53:51 +0000 (GMT)
	(envelope-from pjd@tickbox.ctn.hosting.co.za)
Received: from tickbox.ctn.hosting.co.za (tickbox.ctn.hosting.co.za [196.36.153.47])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E27EF43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Jul 2005 11:53:50 +0000 (GMT)
	(envelope-from pjd@tickbox.ctn.hosting.co.za)
Received: by tickbox.ctn.hosting.co.za (Postfix, from userid 1001)
	id 0D4A4AC94; Tue, 26 Jul 2005 13:53:49 +0200 (SAST)
Message-Id: <20050726115349.0D4A4AC94@tickbox.ctn.hosting.co.za>
Date: Tue, 26 Jul 2005 13:53:49 +0200 (SAST)
From: Piet Delport <pjd@satori.za.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rodrigc@crodrigues.org
Subject: [PATCH] devel/apr contains stray sed -i
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         84120
>Category:       ports
>Synopsis:       [PATCH] devel/apr contains stray sed -i
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 26 12:00:32 GMT 2005
>Closed-Date:    Wed Jul 27 20:48:38 GMT 2005
>Last-Modified:  Wed Jul 27 20:48:38 GMT 2005
>Originator:     Piet Delport
>Release:        FreeBSD 4.8-RELEASE-p13 i386
>Organization:
>Environment:
>Description:
	(maintainer cc'd)

	devel/apr does not build on my FreeBSD 4.5 box, which does not
	understand "sed -i".
>How-To-Repeat:
>Fix:

As far as i understand, ${REINPLACE} should be useed instead of ${SED} -i, as
per the following patch:

--- apr.patch begins here ---
--- Makefile.orig	Sun Jun 12 19:51:34 2005
+++ Makefile	Tue Jul 26 13:19:08 2005
@@ -125,7 +125,7 @@
 	@${ECHO_MSG} ""
 
 post-patch:
-	${SED} -i .orig1 's/OSVERSION/'${OSVERSION}'/g' \
+	${REINPLACE_CMD} -e 's/OSVERSION/'${OSVERSION}'/g' \
 		${WRKDIR}/apr-${PORTVERSION}/build/apr_hints.m4
 	${FIND} ${WRKDIR} -name "Makefile.in*" | ${XARGS} ${REINPLACE_CMD} -e \
 		's|[(]libdir[)]/pkgconfig|(prefix)/libdata/pkgconfig|g'
--- apr.patch ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Wed Jul 27 11:03:43 GMT 2005 
State-Changed-Why:  
Asked maintainer for approval 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Wed Jul 27 11:03:43 GMT 2005 
Responsible-Changed-Why:  
Track 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84120 

From: Pav Lucistnik <pav@FreeBSD.org>
To: rodrigc@crodrigues.org, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/84120: [PATCH] devel/apr contains stray sed -i
Date: Wed, 27 Jul 2005 13:03:45 +0200

 Dear maintainer of FreeBSD port devel/apr, please take a look at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=84120
 
 Do you approve this patch?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 And now something completely different.

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/84120: [PATCH] devel/apr contains stray sed -i
Date: Wed, 27 Jul 2005 09:40:29 -0400

 On Wed, Jul 27, 2005 at 01:03:45PM +0200, Pav Lucistnik wrote:
 > Dear maintainer of FreeBSD port devel/apr, please take a look at
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?q=84120
 > 
 > Do you approve this patch?
 
 Getting approval from my ports maintainer so I can commit it.
 
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org
State-Changed-From-To: feedback->closed 
State-Changed-By: rodrigc 
State-Changed-When: Wed Jul 27 20:48:11 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=84120 
>Unformatted:
