From odip@bionet.nsc.ru  Thu Jun 30 18:31:50 2005
Return-Path: <odip@bionet.nsc.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5CE6016A41C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 Jun 2005 18:31:50 +0000 (GMT)
	(envelope-from odip@bionet.nsc.ru)
Received: from hydra.bionet.nsc.ru (hydra.bionet.nsc.ru [84.237.118.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EC91D43D49
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 30 Jun 2005 18:31:49 +0000 (GMT)
	(envelope-from odip@bionet.nsc.ru)
Received: by hydra.bionet.nsc.ru (Postfix, from userid 1001)
	id 5F0B655CB; Fri,  1 Jul 2005 01:31:47 +0700 (NOVST)
Message-Id: <20050630183147.5F0B655CB@hydra.bionet.nsc.ru>
Date: Fri,  1 Jul 2005 01:31:47 +0700 (NOVST)
From: Dmitry A Grigorovich <odip@bionet.nsc.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: fm@cross-road.org.ua
Subject: [patch] Missing dependencies at ftp/lftp + enhanced config
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         82837
>Category:       ports
>Synopsis:       [patch] Missing dependencies at ftp/lftp + enhanced config
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mnag
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 30 18:40:15 GMT 2005
>Closed-Date:    Sun Sep 18 17:54:31 GMT 2005
>Last-Modified:  Sun Sep 18 17:54:31 GMT 2005
>Originator:     Dmitry A Grigorovich
>Release:        FreeBSD manticore.bionet.nsc.ru 5.4-RELEASE-p2
>Organization:
ICiG SB RAS, Russia
>Environment:
FreeBSD manticore.bionet.nsc.ru 5.4-RELEASE-p2

>Description:

At ftp/lftp ports missed dependency of expat library

Also added support for make config

Also lftp by default with openssl support

>How-To-Repeat:

Install ftp/lftp

root@manticore# ldd /usr/local/bin/lftp | grep expat
        libexpat.so.5 => /usr/local/lib/libexpat.so.5 (0x282a1000)

Library expat found

root@manticore# pkg_info -rx lftp
Information for lftp-3.2.1_1:

Depends on:
Dependency: libiconv-1.9.2_1
Dependency: gettext-0.14.5

Expat not presented in dependency list !

>Fix:

Apply patch
Reinstall port

--- patch-lftp begins here ---
diff -ur lftp/Makefile lftp.new/Makefile
--- lftp/Makefile	Mon Jun 27 14:26:38 2005
+++ lftp.new/Makefile	Fri Jul  1 01:15:07 2005
@@ -7,6 +7,7 @@
 
 PORTNAME=	lftp
 PORTVERSION=	3.2.1
+PORTREVISION=	1
 CATEGORIES=	ftp ipv6
 MASTER_SITES=	ftp://ftp.cs.tu-berlin.de/pub/net/ftp/lftp/ \
 		ftp://ftp.phear.org/pub/linux/networking/ftp/client/lftp/ \
@@ -40,6 +41,21 @@
 USE_GPG?=	yes
 SIG_FILES=	${DISTNAME}${EXTRACT_SUFX}.asc
 
+LIB_DEPENDS+=	expat.5:${PORTSDIR}/textproc/expat2
+
+GNU_CONFIGURE=	yes
+CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
+		LIBS="-L${LOCALBASE}/lib"
+
+OPTIONS=	GNUTLS "With GnutTLS support" off \
+		OPENSSL "With OpenSSL support" on \
+		SOCKS4 "With socks4 support" off \
+		SOCKS5 "With socks5 support" off \
+		SOCKS_DANTE "With socksdante support" off \
+		NLS "With i18n support" on
+
+.include <bsd.port.pre.mk>
+		
 .if defined(WITH_GNUTLS)
 CONFIGURE_ARGS+=	--with-gnutls
 LIB_DEPENDS+=	gnutls:${PORTSDIR}/security/gnutls
@@ -50,10 +66,6 @@
 USE_OPENSSL=	yes
 .endif
 
-GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
-		LIBS="-L${LOCALBASE}/lib"
-
 .if defined(WITH_SOCKS4)
 CONFIGURE_ARGS+=	--with-socks
 .endif
@@ -83,4 +95,4 @@
 .endfor
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- patch-lftp ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: flz 
State-Changed-When: Thu Jun 30 18:49:23 GMT 2005 
State-Changed-Why:  
Forward PR to maintainer. 

Note: If it built fine on pointyhat, it might be 'configure magic' that 
autodetected your expat library and added it to LDFLAGS. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82837 

From: Florent Thoumie <flz@FreeBSD.org>
To: fm@cross-road.org.ua
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/82837: [patch] Missing dependencies at ftp/lftp +
	enhanced config
Date: Thu, 30 Jun 2005 20:52:42 +0200

 Le Jeudi 30 juin 2005  18:51 +0000, Florent Thoumie a crit :
 > Synopsis: [patch] Missing dependencies at ftp/lftp + enhanced config
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: flz
 > State-Changed-When: Thu Jun 30 18:49:23 GMT 2005
 > State-Changed-Why: 
 > Forward PR to maintainer.
 > 
 > Note: If it built fine on pointyhat, it might be 'configure magic' that
 > autodetected your expat library and added it to LDFLAGS.
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=82837
 -- 
 Florent Thoumie
 flz@FreeBSD.org
 
State-Changed-From-To: feedback->open 
State-Changed-By: vs 
State-Changed-When: Fri Sep 16 07:40:26 GMT 2005 
State-Changed-Why:  
Feedback timeout 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82837 
Responsible-Changed-From-To: freebsd-ports-bugs->mnag 
Responsible-Changed-By: mnag 
Responsible-Changed-When: Sun Sep 18 05:29:14 GMT 2005 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82837 
State-Changed-From-To: open->closed 
State-Changed-By: mnag 
State-Changed-When: Sun Sep 18 17:54:21 GMT 2005 
State-Changed-Why:  
Commited, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=82837 
>Unformatted:
