From dgerow@dementia.afflictions.org  Sat May 21 05:46:59 2005
Return-Path: <dgerow@dementia.afflictions.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F81716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 May 2005 05:46:59 +0000 (GMT)
Received: from pandora.afflictions.org (asylum.afflictions.org [64.7.134.90])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8379543D58
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 May 2005 05:46:58 +0000 (GMT)
	(envelope-from dgerow@dementia.afflictions.org)
Received: from localhost (localhost [127.0.0.1])
	by pandora.afflictions.org (Postfix) with ESMTP id 4E7F578C5F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 May 2005 01:47:20 -0400 (EDT)
Received: from pandora.afflictions.org ([127.0.0.1])
 by localhost (pandora.afflictions.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 69730-05 for <FreeBSD-gnats-submit@freebsd.org>;
 Sat, 21 May 2005 01:47:15 -0400 (EDT)
Received: from dementia.afflictions.org (dementia.afflictions.org [172.19.206.56])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pandora.afflictions.org (Postfix) with ESMTP id 8393E78C70
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 May 2005 01:47:14 -0400 (EDT)
Received: by dementia.afflictions.org (Postfix, from userid 1001)
	id 6ADBC33C7B; Sat, 21 May 2005 01:46:50 -0400 (EDT)
Message-Id: <20050521054650.6ADBC33C7B@dementia.afflictions.org>
Date: Sat, 21 May 2005 01:46:50 -0400 (EDT)
From: Damian Gerow <dgerow@afflictions.org>
Reply-To: Damian Gerow <dgerow@afflictions.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: www/linux-firefox doesn't pick up linux-flashplugin7 via linkfarm
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         81333
>Category:       ports
>Synopsis:       www/linux-firefox doesn't pick up linux-flashplugin7 via linkfarm
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 21 05:50:02 GMT 2005
>Closed-Date:    Sat May 21 13:52:43 GMT 2005
>Last-Modified:  Sat May 21 13:52:43 GMT 2005
>Originator:     Damian Gerow
>Release:        FreeBSD 5.4-STABLE amd64
>Organization:
>Environment:
System: FreeBSD dementia.afflictions.org 5.4-STABLE FreeBSD 5.4-STABLE #1: Thu May 5 19:13:47 EDT 2005 root@:/usr/obj/usr/src/sys/GENERIC amd64


>Description:
When running linux-firefox and linux-flashplugin7, the links to enable the
plugin must be created manually, as the provided 'linkfarm' utility only looks
for linux-flashplugin6.  Note that concessions also need to be made for
linux-flashplugin, but those are not made here.

The utility also doesn't get rid of stale links, which prohibits someone from
easily swapping, say, flashplugin versions: as each version makes the same
softlink within /usr/X11R6/lib/linux-firefox/plugins, and as linkfarm does
not remove old links, new ones cannot be created.
>How-To-Repeat:
Install www/linux-flashplugin7.  Run linkfarm.  Watch as it doesn't enable
the plugin.
>Fix:
Patch below adds support for www/linux-flashplugin7, and also removes stale
links within the plugin directory:

--- linkfarm.orig       Sat May 21 01:39:40 2005
+++ linkfarm    Sat May 21 01:42:55 2005
@@ -1,11 +1,13 @@
 #!/bin/sh
 # Run this after installing Beonex, Mozilla or Netscape plugins.
 cd /usr/X11R6/lib/linux-firefox/plugins
+/usr/bin/find -L . -type l -delete
 /usr/bin/find /usr/local/lib/linux-beonex/plugins/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/lib/netscape-linux/plugins/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/lib/flash/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/lib/linux-mozilla/plugins/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/lib/linux-netscape*/plugins/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/lib/linux-flashplugin6/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
+/usr/bin/find /usr/local/lib/linux-flashplugin7/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/linux-blackdown-jdk1.3.1/jre/plugin/i386/mozilla/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null
 /usr/bin/find /usr/local/linux-blackdown-jdk1.4.1/jre/plugin/i386/mozilla/* -maxdepth 1 -exec /bin/ln -s {} \; 2>/dev/null

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Sat May 21 11:44:51 GMT 2005 
State-Changed-Why:  
linkfarm file is generated from port Makefile, so can you please provide 
patch for port Makefile? Also, I'm not sure if deleting all symlinks is 
desirable, what if someone makes a symlink by hand there? 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sat May 21 11:44:51 GMT 2005 
Responsible-Changed-Why:  
Track 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81333 
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Sat May 21 13:52:31 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81333 
>Unformatted:
