From nobody@FreeBSD.org  Thu May 19 17:31:02 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9F85616A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 19 May 2005 17:31:02 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6DB5D43D88
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 19 May 2005 17:31:02 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j4JHV1AR024299
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 19 May 2005 17:31:01 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j4JHV1NC024298;
	Thu, 19 May 2005 17:31:01 GMT
	(envelope-from nobody)
Message-Id: <200505191731.j4JHV1NC024298@www.freebsd.org>
Date: Thu, 19 May 2005 17:31:01 GMT
From: Nicolas Blais <nb_root@videotron.ca>
To: freebsd-gnats-submit@FreeBSD.org
Subject: FIX: Hydra port does not compile xhydra
X-Send-Pr-Version: www-2.3

>Number:         81275
>Category:       ports
>Synopsis:       FIX: Hydra port does not compile xhydra
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 19 17:40:01 GMT 2005
>Closed-Date:    Sat May 21 23:55:55 GMT 2005
>Last-Modified:  Sat May 21 23:55:55 GMT 2005
>Originator:     Nicolas Blais
>Release:        6-CURRENT
>Organization:
>Environment:
FreeBSD clk01a 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Thu May 19 09:13:03 EDT 2005     root@clk01a:/usr/obj/usr/src/sys/CLK01A  i386

>Description:
When compiling /security/hydra port, it will not compile xhydra, nor will it install it.

output of make:
gcc -I. -Wall -O2 -fno-strict-aliasing -pipe -march=athlon-mp -lm -o hydra hydra-vnc.o hydra-pcnfs.o hydra-rexec.o hydra-nntp.o hydra-socks5.o  hydra-telnet.o hydra-cisco.o hydra-http.o hydra-ftp.o hydra-imap.o  hydra-pop3.o hydra-smb.o hydra-icq.o hydra-cisco-enable.o hydra-ldap.o  hydra-mysql.o hydra-http-proxy.o hydra-smbnt.o hydra-mssql.o  hydra-snmp.o hydra-cvs.o hydra-smtpauth.o  hydra-sapr3.o hydra-ssh2.o d3des.o  hydra-mod.o hydra.o  -lssl -lcrypto -L/usr/lib -L/usr/local/lib -L/lib -L/usr/lib -L/lib

If men could get pregnant, abortion would be a sacrament

cd hydra-gtk && ./make_xhydra.sh
./make_xhydra.sh: not found
*** Error code 127 (ignored)



>How-To-Repeat:
in /ports/security/hydra and type make.
>Fix:
When make is done, go in work/hydra-4.5-src/hydra-gtk and type 
bash make_xhydra.sh
you will get this error msg:

Trying to compile xhydra now (hydra gtk gui) - dont worry if this fails, this is really optional ...
Error: could not compile. Analyse this:
"Makefile", line 215: Need an operator
make: fatal errors encountered -- cannot continue

Do not worry, as I said, xhydra is really optional. ./hydra is ready to go!

now type gmake. It will compile successfully and xhydra will be in src.


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Fri May 20 20:31:04 GMT 2005 
State-Changed-Why:  
Can you provide a patch for a port that will make it compile and install 
properly? Have you talked with maintainer about this? Maybe him could fix it. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Fri May 20 20:31:04 GMT 2005 
Responsible-Changed-Why:  
Track 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81275 

From: Nicolas Blais <nb_root@videotron.ca>
To: Pav Lucistnik <pav@FreeBSD.org>, freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Fri, 20 May 2005 17:12:24 -0400

 --Boundary_(ID_IBrLzhSVOOXkhAV8WYN0Fw)
 Content-type: text/plain; charset=iso-8859-1
 Content-transfer-encoding: 7BIT
 Content-disposition: inline
 
 On May 20, 2005 04:31 pm, you wrote:
 > Synopsis: FIX: Hydra port does not compile xhydra
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: pav
 > State-Changed-When: Fri May 20 20:31:04 GMT 2005
 > State-Changed-Why:
 > Can you provide a patch for a port that will make it compile and install
 > properly? Have you talked with maintainer about this? Maybe him could fix
 > it.
 >
 >
 > Responsible-Changed-From-To: freebsd-ports-bugs->pav
 > Responsible-Changed-By: pav
 > Responsible-Changed-When: Fri May 20 20:31:04 GMT 2005
 > Responsible-Changed-Why:
 > Track
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=81275
 
 I have attached the patches.
 
 If you have any problems, feel free to contact me.
 Nicolas.
 
 --Boundary_(ID_IBrLzhSVOOXkhAV8WYN0Fw)
 Content-type: text/x-diff; charset=iso-8859-1; name=Makefile.diff
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=Makefile.diff
 
 --- Makefile.orig	Fri May 20 17:06:02 2005
 +++ Makefile	Fri May 20 17:08:48 2005
 @@ -18,7 +18,7 @@
  COMMENT=	Brute force attack utility working on multiple network services
  
  NO_LATEST_LINK=	yes
 -PLIST_FILES=	bin/hydra
 +PLIST_FILES=	bin/hydra /bin/xhydra
  USE_REINPLACE=	yes
  GNU_CONFIGURE=	yes
  USE_OPENSSL=	yes
 @@ -30,6 +30,6 @@
  		${WRKSRC}/Makefile.am
  
  do-install:
 -	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${PREFIX}/bin
 +	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${WRKSRC}/hydra-gtk/src/xhydra ${PREFIX}/bin; \
  
  .include <bsd.port.mk>
 
 --Boundary_(ID_IBrLzhSVOOXkhAV8WYN0Fw)
 Content-type: text/x-diff; charset=iso-8859-1; name=patch-aa
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=patch-aa
 
 --- Makefile.am.orig	Fri May 20 16:54:16 2005
 +++ Makefile.am	Fri May 20 16:54:24 2005
 @@ -36,7 +36,7 @@
  	@echo
  
  xhydra:	
 -	-cd hydra-gtk && ./make_xhydra.sh
 +	-cd hydra-gtk && sh make_xhydra.sh
  
  pw-inspector: pw-inspector.c
  	-$(CC) $(OPTS) -o pw-inspector pw-inspector.c
 
 --Boundary_(ID_IBrLzhSVOOXkhAV8WYN0Fw)
 Content-type: text/x-diff; charset=iso-8859-1; name=patch-ab
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=patch-ab
 
 --- hydra-gtk/make_xhydra.sh.orig	Fri May 20 17:03:45 2005
 +++ hydra-gtk/make_xhydra.sh	Fri May 20 17:04:06 2005
 @@ -8,7 +8,7 @@
    cat errors
    exit 1
  }
 -make > /dev/null 2> errors
 +gmake > /dev/null 2> errors
  test -e src/xhydra || {
    echo "Error: could not compile. Analyse this:"
    cat errors
 
 --Boundary_(ID_IBrLzhSVOOXkhAV8WYN0Fw)--

From: Nicolas Blais <nb_root@videotron.ca>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Fri, 20 May 2005 17:14:47 -0400

 --Boundary_(ID_DqKZJxLD0PuJ02l40zDavA)
 Content-type: text/plain; charset=us-ascii
 Content-transfer-encoding: 7BIT
 Content-disposition: inline
 
 Attached are the patches.
 
 Nicolas.
 
 --Boundary_(ID_DqKZJxLD0PuJ02l40zDavA)
 Content-type: text/x-diff; charset=us-ascii; name=patch-aa
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=patch-aa
 
 --- Makefile.am.orig	Fri May 20 16:54:16 2005
 +++ Makefile.am	Fri May 20 16:54:24 2005
 @@ -36,7 +36,7 @@
  	@echo
  
  xhydra:	
 -	-cd hydra-gtk && ./make_xhydra.sh
 +	-cd hydra-gtk && sh make_xhydra.sh
  
  pw-inspector: pw-inspector.c
  	-$(CC) $(OPTS) -o pw-inspector pw-inspector.c
 
 --Boundary_(ID_DqKZJxLD0PuJ02l40zDavA)
 Content-type: text/x-diff; charset=us-ascii; name=patch-ab
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=patch-ab
 
 --- hydra-gtk/make_xhydra.sh.orig	Fri May 20 17:03:45 2005
 +++ hydra-gtk/make_xhydra.sh	Fri May 20 17:04:06 2005
 @@ -8,7 +8,7 @@
    cat errors
    exit 1
  }
 -make > /dev/null 2> errors
 +gmake > /dev/null 2> errors
  test -e src/xhydra || {
    echo "Error: could not compile. Analyse this:"
    cat errors
 
 --Boundary_(ID_DqKZJxLD0PuJ02l40zDavA)
 Content-type: text/x-diff; charset=us-ascii; name=Makefile.diff
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=Makefile.diff
 
 --- Makefile.orig	Fri May 20 17:06:02 2005
 +++ Makefile	Fri May 20 17:08:48 2005
 @@ -18,7 +18,7 @@
  COMMENT=	Brute force attack utility working on multiple network services
  
  NO_LATEST_LINK=	yes
 -PLIST_FILES=	bin/hydra
 +PLIST_FILES=	bin/hydra /bin/xhydra
  USE_REINPLACE=	yes
  GNU_CONFIGURE=	yes
  USE_OPENSSL=	yes
 @@ -30,6 +30,6 @@
  		${WRKSRC}/Makefile.am
  
  do-install:
 -	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${PREFIX}/bin
 +	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${WRKSRC}/hydra-gtk/src/xhydra ${PREFIX}/bin; \
  
  .include <bsd.port.mk>
 
 --Boundary_(ID_DqKZJxLD0PuJ02l40zDavA)--

From: Pav Lucistnik <pav@FreeBSD.org>
To: llevier@argosnet.com, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Fri, 20 May 2005 23:33:47 +0200

 Dear maintainer of FreeBSD port security/hydra, do you approve following
 patch which enabled build and installation of xhydra in your port?
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/security/hydra/Makefile,v
 retrieving revision 1.10
 diff -a -u -r1.10 Makefile
 --- Makefile	8 Feb 2005 21:54:03 -0000	1.10
 +++ Makefile	20 May 2005 21:29:10 -0000
 @@ -18,9 +18,11 @@
  COMMENT=	Brute force attack utility working on multiple network services
  
  NO_LATEST_LINK=	yes
 -PLIST_FILES=	bin/hydra
 +PLIST_FILES=	bin/hydra bin/xhydra
  USE_REINPLACE=	yes
  GNU_CONFIGURE=	yes
 +USE_GMAKE=	yes
 +USE_GNOME=	gtk20
  USE_OPENSSL=	yes
  WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}-src
  
 @@ -30,6 +32,6 @@
  		${WRKSRC}/Makefile.am
  
  do-install:
 -	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${PREFIX}/bin
 +	@${INSTALL_PROGRAM} ${WRKSRC}/hydra ${WRKSRC}/hydra-gtk/src/xhydra ${PREFIX}/bin
  
  .include <bsd.port.mk>
 Index: files/patch-Makefile.am
 ===================================================================
 RCS file: files/patch-Makefile.am
 diff -N files/patch-Makefile.am
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-Makefile.am	20 May 2005 21:29:10 -0000
 @@ -0,0 +1,11 @@
 +--- Makefile.am.orig	Fri May 20 16:54:16 2005
 ++++ Makefile.am	Fri May 20 16:54:24 2005
 +@@ -36,7 +36,7 @@
 + 	@echo
 + 
 + xhydra:	
 +-	-cd hydra-gtk && ./make_xhydra.sh
 ++	-cd hydra-gtk && sh make_xhydra.sh
 + 
 + pw-inspector: pw-inspector.c
 + 	-$(CC) $(OPTS) -o pw-inspector pw-inspector.c
 Index: files/patch-hydra-gtk-make_xhydra.sh
 ===================================================================
 RCS file: files/patch-hydra-gtk-make_xhydra.sh
 diff -N files/patch-hydra-gtk-make_xhydra.sh
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-hydra-gtk-make_xhydra.sh	20 May 2005 21:29:10 -0000
 @@ -0,0 +1,11 @@
 +--- hydra-gtk/make_xhydra.sh.orig	Fri May 20 17:03:45 2005
 ++++ hydra-gtk/make_xhydra.sh	Fri May 20 17:04:06 2005
 +@@ -8,7 +8,7 @@
 +   cat errors
 +   exit 1
 + }
 +-make > /dev/null 2> errors
 ++gmake > /dev/null 2> errors
 + test -e src/xhydra || {
 +   echo "Error: could not compile. Analyse this:"
 +   cat errors
 
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 arch> I went grocery shopping, made a pot of chilli, played ey,
 then ate some chilli

From: Nicolas Blais <nb_root@videotron.ca>
To: bug-followup@FreeBSD.org, nb_root@videotron.ca
Cc:  
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Fri, 20 May 2005 17:45:13 -0400

 --Boundary_(ID_4rcL457DSXbQYn6pHFGdrw)
 Content-type: text/plain; charset=us-ascii
 Content-transfer-encoding: 7BIT
 Content-disposition: inline
 
 There is also this patch missing which fixes a bug in the xhydra code.
 
 Nicolas.
 
 --Boundary_(ID_4rcL457DSXbQYn6pHFGdrw)
 Content-type: text/x-diff; charset=us-ascii; name=patch-ac
 Content-transfer-encoding: 7BIT
 Content-disposition: attachment; filename=patch-ac
 
 --- hydra-gtk/src/callbacks.c.orig	Fri May 20 17:38:13 2005
 +++ hydra-gtk/src/callbacks.c	Fri May 20 17:41:00 2005
 @@ -69,21 +69,6 @@
  
  	options[0] = HYDRA_BIN;
  
 -	/* get the target, or target list */
 -	widget = lookup_widget(GTK_WIDGET(wndMain), "radioTarget1");
 -	if ( gtk_toggle_button_get_active((GtkToggleButton *) widget) ){	
 -		widget = lookup_widget(GTK_WIDGET(wndMain), "entTarget");
 -		options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 -	} else {
 -		options[i++] = "-M";
 -		widget = lookup_widget(GTK_WIDGET(wndMain), "entTargetFile");
 -		options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 -	}
 -
 -	/* get the service */
 -	widget = lookup_widget(GTK_WIDGET(wndMain), "entProtocol");
 -	options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 -	
  	/* get the port */
  	widget = lookup_widget(GTK_WIDGET(wndMain), "spnPort");
  	j = gtk_spin_button_get_value_as_int((GtkSpinButton *) widget);
 @@ -307,6 +292,21 @@
  		}
  	}		
  
 +	/* get the target, or target list */
 +	widget = lookup_widget(GTK_WIDGET(wndMain), "radioTarget1");
 +	if ( gtk_toggle_button_get_active((GtkToggleButton *) widget) ){	
 +		widget = lookup_widget(GTK_WIDGET(wndMain), "entTarget");
 +		options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 +	} else {
 +		options[i++] = "-M";
 +		widget = lookup_widget(GTK_WIDGET(wndMain), "entTargetFile");
 +		options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 +	}
 +
 +	/* get the service */
 +	widget = lookup_widget(GTK_WIDGET(wndMain), "entProtocol");
 +	options[i++] = (char *) gtk_entry_get_text((GtkEntry *) widget);
 +	
  	options[i] = NULL;
  	return i;
  }
 
 --Boundary_(ID_4rcL457DSXbQYn6pHFGdrw)--

From: Pav Lucistnik <pav@FreeBSD.org>
To: Laurent LEVIER <llevier@argosnet.com>
Cc: bug-followup@FreeBSD.org, Nicolas Blais <nb_root@videotron.ca>
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Sat, 21 May 2005 12:06:54 +0200

 --=-BpG8w2cbd43XIPdOq1KQ
 Content-Type: text/plain; charset=ISO-8859-2
 Content-Transfer-Encoding: quoted-printable
 
 Laurent LEVIER p=ED=B9e v so 21. 05. 2005 v 10:01 +0200:
 > At 23:33 20/05/2005, Pav Lucistnik wrote:
 > >Dear maintainer of FreeBSD port security/hydra, do you approve following
 > >patch which enabled build and installation of xhydra in your port?
 
 > Hi Pav,
 >=20
 > I checked and it seems 2nd patch (on make_xhydra) does not apply here.
 > As a result, xhydra compile fails.
 > But it looks correct, I dont understand why it does not apply. Do you hav=
 e=20
 > an idea?
 
 It does apply nicely here, maybe your mailer did something nasty to tabs
 
 Get the patch from here http://hood.oook.cz/irc/hydra.diff or patched
 port from http://hood.oook.cz/irc/hydra.tar.gz
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Oh, no! Aaargh! It is the most unnatural, most disgusting
 creature imaginable: a two-eyed cyclops!
 
 --=-BpG8w2cbd43XIPdOq1KQ
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (FreeBSD)
 
 iD8DBQBCjwg+ntdYP8FOsoIRAoauAJkBLY6YL96/bwxOqpBxZc/9nlqRHQCgsdyu
 Iw68dErqpfhILMz9dfXBnmA=
 =ua8k
 -----END PGP SIGNATURE-----
 
 --=-BpG8w2cbd43XIPdOq1KQ--

From: Pav Lucistnik <pav@FreeBSD.org>
To: Laurent LEVIER <llevier@argosnet.com>
Cc: bug-followup@FreeBSD.org, Nicolas Blais <nb_root@videotron.ca>
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Sat, 21 May 2005 12:56:57 +0200

 Laurent LEVIER p=ED=B9e v so 21. 05. 2005 v 12:36 +0200:
 > At 12:06 21/05/2005, Pav Lucistnik wrote:
 > >Get the patch from here http://hood.oook.cz/irc/hydra.diff or patched
 > >port from http://hood.oook.cz/irc/hydra.tar.gz
 
 > Ported patch works definitely better, but compile failed for xhydra:
 
 Redownload the port from same URL and retry, I fixed that problem.
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 EMACS: Eight Megabytes And Continually Swapping

From: Pav Lucistnik <pav@FreeBSD.org>
To: Laurent LEVIER <llevier@argosnet.com>,
	Nicolas Blais <nb_root@videotron.ca>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/81275: FIX: Hydra port does not compile xhydra
Date: Sat, 21 May 2005 14:22:32 +0200

 Nicolas Blais p=ED=B9e v so 21. 05. 2005 v 08:10 -0400:
 > On May 21, 2005 06:56 am, Pav Lucistnik wrote:
 > > Laurent LEVIER p=ED=B9e v so 21. 05. 2005 v 12:36 +0200:
 > > > At 12:06 21/05/2005, Pav Lucistnik wrote:
 > > > >Get the patch from here http://hood.oook.cz/irc/hydra.diff or patche=
 d
 > > > >port from http://hood.oook.cz/irc/hydra.tar.gz
 > > >
 > > > Ported patch works definitely better, but compile failed for xhydra:
 > >
 > > Redownload the port from same URL and retry, I fixed that problem.
 >=20
 > The ported hydra above compiles and install fine, but it still contains t=
 he=20
 > bug in callbacks.c (argv not transfered in the correct order to hydra). M=
 y=20
 > last patch (patch-ac) fixes this problem while=20
 > patch-hydra-gtk-src-callbacks.c does not.
 
 Okay, intergrated Nicolas' patch, files on URLs above updated.
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 I am a shrubber. My name is Roger the Shrubber. I arrange, design and
 sell shrubberies.
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Sat May 21 23:55:48 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81275 
>Unformatted:
