From dsl@mayhem.webize.com.au  Tue Apr 19 14:00:15 2005
Return-Path: <dsl@mayhem.webize.com.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE7A216A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Apr 2005 14:00:15 +0000 (GMT)
Received: from mayhem.webize.com.au (mayhem.webize.com.au [203.48.28.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8246243D39
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Apr 2005 14:00:15 +0000 (GMT)
	(envelope-from dsl@mayhem.webize.com.au)
Received: by mayhem.webize.com.au (Postfix, from userid 1003)
	id 89AA5155; Wed, 20 Apr 2005 00:00:13 +1000 (EST)
Message-Id: <20050419140013.89AA5155@mayhem.webize.com.au>
Date: Wed, 20 Apr 2005 00:00:13 +1000 (EST)
From: David Lay <dsl@webize.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] mail/maildrop flock() failure
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         80106
>Category:       ports
>Synopsis:       [PATCH] mail/maildrop flock() failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sergei
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 19 14:00:49 GMT 2005
>Closed-Date:    Tue Apr 26 13:25:41 GMT 2005
>Last-Modified:  Tue Apr 26 13:25:41 GMT 2005
>Originator:     David Lay
>Release:        FreeBSD 4.11-RELEASE-p3 i386
>Organization:
Webize
>Environment:
System: FreeBSD mayhem.webize.com.au 4.11-RELEASE-p3 FreeBSD 4.11-RELEASE-p3 #16: Sun Apr 17 01:25:55 EST 2005 root@mayhem.webize.com.au:/usr/obj/usr/src/sys/MAYHEM i386

maildrop-1.8.0_2

>Description:
	Maildrop exits with "flock() failed" when an attempting to route messages to /dev/null.

>How-To-Repeat:

	~/.mailfilter:

            to "tmp/devnull"

>Fix:

diff -Nur /usr/ports/mail/maildrop/files/patch-filelock.C maildrop/files/patch-filelock.C
--- /usr/ports/mail/maildrop/files/patch-filelock.C	Thu Jan  1 10:00:00 1970
+++ maildrop/files/patch-filelock.C	Fri Apr 15 13:12:31 2005
@@ -0,0 +1,11 @@
+--- maildrop/filelock.C.orig	Sat Apr 29 03:17:45 2000
++++ maildrop/filelock.C	Fri Apr 15 13:09:25 2005
+@@ -64,7 +64,7 @@
+ 		// you're writing to a device file, you know what you're doing.
+ 
+ 		if (fstat(fd, &stat_buf) >= 0 && (
+-			S_ISREG(stat_buf.st_mode) || S_ISDIR(stat_buf.st_mode)))
++			S_ISCHR(stat_buf.st_mode) || S_ISBLK(stat_buf.st_mode)))
+ 		{
+ 			return;
+ 		}

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sergei 
Responsible-Changed-By: jylefort 
Responsible-Changed-When: Tue Apr 19 14:13:03 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80106 
State-Changed-From-To: open->closed 
State-Changed-By: sergei 
State-Changed-When: Tue Apr 26 13:25:32 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=80106 
>Unformatted:
