From lennox@cnr.cs.columbia.edu  Tue Apr 12 15:05:15 2005
Return-Path: <lennox@cnr.cs.columbia.edu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 43C3116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Apr 2005 15:05:15 +0000 (GMT)
Received: from cnr.cs.columbia.edu (cnr.cs.columbia.edu [128.59.19.133])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DBFFC43D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Apr 2005 15:05:14 +0000 (GMT)
	(envelope-from lennox@cnr.cs.columbia.edu)
Received: from cnr.cs.columbia.edu (localhost [127.0.0.1])
	by cnr.cs.columbia.edu (8.13.1/8.13.1) with ESMTP id j3CF5EeP011694
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Apr 2005 11:05:14 -0400 (EDT)
	(envelope-from lennox@cnr.cs.columbia.edu)
Received: (from lennox@localhost)
	by cnr.cs.columbia.edu (8.13.1/8.13.1/Submit) id j3CF5DRu011636;
	Tue, 12 Apr 2005 11:05:13 -0400 (EDT)
	(envelope-from lennox)
Message-Id: <200504121505.j3CF5DRu011636@cnr.cs.columbia.edu>
Date: Tue, 12 Apr 2005 11:05:13 -0400 (EDT)
From: Jonathan Lennox <lennox@cnr.cs.columbia.edu>
Reply-To: Jonathan Lennox <lennox@cnr.cs.columbia.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: multimedia/transcode builds without optimization if multimedia/linux-divx4linux is installed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         79826
>Category:       ports
>Synopsis:       multimedia/transcode builds without optimization if multimedia/linux-divx4linux is installed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 12 15:10:30 GMT 2005
>Closed-Date:    Wed May 04 11:44:50 GMT 2005
>Last-Modified:  Wed May 04 11:44:50 GMT 2005
>Originator:     Jonathan Lennox
>Release:        FreeBSD 5.3-RELEASE-p2 i386
>Organization:
Columbia University
>Environment:
System: FreeBSD cnr.cs.columbia.edu 5.3-RELEASE-p2 FreeBSD 5.3-RELEASE-p2 #9: Sat Dec 4 12:36:03 EST 2004 lennox@cnr.cs.columbia.edu:/usr/obj/usr/src/sys/CNR i386


	
>Description:

Due to a bug in the port Makefile, if the port multimedia/linux-divx4linux is
installed, the build of the port multimedia/transcode discards the system
CFLAGS, so transcode is built without any optimization flags.

>How-To-Repeat:
# portinstall multimedia/linux-divx4linux
# cd /usr/ports/multimedia/transcode; make

Observe the arguments to cc, in particular the lack of any -O options.

>Fix:

The following patch fixes it.  This fix might imply that a PORTREVISION
bump is in order; I'm not sure of what policy is on that.

Alternately, as a workaround, uninstall multimedia/linux-divx4linux before
building transcode.

--- multimedia/transcode/Makefile.orig	Tue Apr 12 10:54:59 2005
+++ multimedia/transcode/Makefile	Tue Apr 12 10:55:47 2005
@@ -261,7 +261,7 @@
 
 .if defined(WITH_DIVX5)
 BUILD_DEPENDS+=	${LINUXBASE}/usr/lib/libdivxdecore.so:${PORTSDIR}/multimedia/linux-divx4linux
-CONFIGURE_ENV+=	CFLAGS="-I${LINUXBASE}/usr/include/divx" CPPFLAGS="-I${LINUXBASE}/usr/include/divx"
+CONFIGURE_ENV+=	CFLAGS="-I${LINUXBASE}/usr/include/divx" CPPFLAGS="-I${LINUXBASE}/usr/include/divx ${CFLAGS}"
 .else
 .endif
 



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Tue Apr 12 21:14:50 GMT 2005 
State-Changed-Why:  
Asked maintainer for oppinion 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Tue Apr 12 21:14:50 GMT 2005 
Responsible-Changed-Why:  
Handle 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79826 

From: Pav Lucistnik <pav@FreeBSD.org>
To: hendrik@scholz.net, freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/79826: multimedia/transcode builds without optimization
	if multimedia/linux-divx4linux is installed
Date: Tue, 12 Apr 2005 23:14:48 +0200

 Dear maintainer of FreeBSD port multimedia/transcode, please take a look
 at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=79826
 
 Can you take a look at this patch and approve it/reject it/correct it?
 I'm not completely convinced it's the right solution.
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 The Phase Spider. A spider that never seems quite there.
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Wed May 4 11:44:38 GMT 2005 
State-Changed-Why:  
Maintainer timeout; variation on your patch committed, thank you. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79826 
>Unformatted:
