From johans@stack.nl  Thu Apr  7 17:49:42 2005
Return-Path: <johans@stack.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A9C8D16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Apr 2005 17:49:42 +0000 (GMT)
Received: from skynet.stack.nl (skynet.stack.nl [131.155.140.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BE2AE43D5E
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Apr 2005 17:49:41 +0000 (GMT)
	(envelope-from johans@stack.nl)
Received: by skynet.stack.nl (Postfix, from userid 65534)
	id D83113F98; Thu,  7 Apr 2005 19:49:59 +0200 (CEST)
Received: from mud.stack.nl (mud.stack.nl [IPv6:2001:610:1108:5011:207:e9ff:fe14:b498])
	by skynet.stack.nl (Postfix) with ESMTP id 6638C3F16;
	Thu,  7 Apr 2005 19:49:59 +0200 (CEST)
Received: by mud.stack.nl (Postfix, from userid 801)
	id AFF9A17038; Thu,  7 Apr 2005 19:50:33 +0200 (CEST)
Message-Id: <20050407175033.AFF9A17038@mud.stack.nl>
Date: Thu,  7 Apr 2005 19:50:33 +0200 (CEST)
From: Johan van Selst <johans@stack.nl>
Reply-To: Johan van Selst <johans@stack.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rmiya@cc.hirosaki-u.ac.jp
Subject: biology/deft: patch for compilation on FreeBSD 5.x
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         79639
>Category:       ports
>Synopsis:       biology/deft: patch for compilation on FreeBSD 5.x
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    thierry
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 07 17:50:08 GMT 2005
>Closed-Date:    Sat Dec 17 07:38:36 GMT 2005
>Last-Modified:  Sat Dec 17 07:38:36 GMT 2005
>Originator:     Johan van Selst
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD mud.stack.nl 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Jan 31 22:31:14 CET 2005 root@mud.stack.nl:/usr/obj/usr/src/sys/mud i386


	
>Description:
	[Cc: maintainer, rmiya@cc.hirosaki-u.ac.jp]

	The used Fortran compiler (ftn77) doesn't seem to default to
	the correct prototypes of functions used before they're defined.
	This breaks the ports build of DeFT on FreeBSD 5.x machines.

	Fix: This only seems to be a problem in one file, so let's
	make sure functions here are defined before they're used.

	btw. With this patch the mpi.f file still shows a warning,
	but I'm not sure where exactly (or how to fix it).
	
>How-To-Repeat:
	
>Fix:

	

	Add an extra patchfile, files/patch-mpi.f:

--- mpi.f.orig	Thu Apr  7 19:25:41 2005
+++ mpi.f	Thu Apr  7 19:25:46 2005
@@ -73,6 +73,13 @@
 
 
 
+      subroutine icopy(ia_sum,ia,n)
+      implicit real*8(a-h,o-z)
+      integer n,ia(*),ia_sum(*)
+      do 1001 i=1,n
+ 1001 ia_sum(i)=ia(i)
+      return
+      end
 
       subroutine mpi_reduce(a,a_sum,n,ntype,mpi_sum,node,mpi_comm_world,
      &                      ierror)
@@ -94,13 +101,6 @@
  1001 a_sum(i)=a(i)
       return
       end
-      subroutine icopy(ia_sum,ia,n)
-      implicit real*8(a-h,o-z)
-      integer n,ia(*),ia_sum(*)
-      do 1001 i=1,n
- 1001 ia_sum(i)=ia(i)
-      return
-      end
 
 
 
@@ -117,20 +117,6 @@
 
 
 
-      subroutine mpi_bsend(a,n,ntype,islave,itag,mpi_comm_world,ierror)
-      implicit real*8(a-h,o-z)
-      include "params.h"
-      integer n,ntype,islave,itag,mpi_comm_world,ierror
-      common/mpii/ibuffer(nibuffer),iis,iir,irs,irr
-      common/mpir/buffer(nrbuffer)
-      if(ntype.eq.1) then
-                           call send_buffer_real(a,n)
-                     else
-                           call send_buffer_integer(a,n)
-                     endif
-      ierror=0
-      return
-      end
       subroutine send_buffer_real(a,n)
       implicit real*8(a-h,o-z)
       include "params.h"
@@ -156,11 +142,40 @@
       if(iis.gt.nibuffer) stop 'out of space in mpi buffer (integers)'
       return
       end
+      subroutine mpi_bsend(a,n,ntype,islave,itag,mpi_comm_world,ierror)
+      implicit real*8(a-h,o-z)
+      include "params.h"
+      integer n,ntype,islave,itag,mpi_comm_world,ierror
+      common/mpii/ibuffer(nibuffer),iis,iir,irs,irr
+      common/mpir/buffer(nrbuffer)
+      if(ntype.eq.1) then
+                           call send_buffer_real(a,n)
+                     else
+                           call send_buffer_integer(a,n)
+                     endif
+      ierror=0
+      return
+      end
 
 
 
 
 
+      subroutine receive_buffer_integer(ia,n)
+      implicit real*8(a-h,o-z)
+      include "params.h"
+      integer n,ia(*)
+      common/mpii/ibuffer(nibuffer),iis,iir,irs,irr
+      common/mpir/buffer(nrbuffer)
+      do 1001 i=1,n
+ 1001 ia(i)=ibuffer(iir+i)
+      iir=iir+n
+      if(iir.eq.iis) then
+                           iis=0
+                           iir=0
+                     endif
+      return
+      end
       subroutine mpi_recv(a,n,ntype,isource,itag,mpi_comm_world,istat,
      &                    ierror)
       implicit real*8(a-h,o-z)
@@ -189,21 +204,6 @@
       if(irr.eq.irs) then
                            irs=0
                            irr=0
-                     endif
-      return
-      end
-      subroutine receive_buffer_integer(ia,n)
-      implicit real*8(a-h,o-z)
-      include "params.h"
-      integer n,ia(*)
-      common/mpii/ibuffer(nibuffer),iis,iir,irs,irr
-      common/mpir/buffer(nrbuffer)
-      do 1001 i=1,n
- 1001 ia(i)=ibuffer(iir+i)
-      iir=iir+n
-      if(iir.eq.iis) then
-                           iis=0
-                           iir=0
                      endif
       return
       end

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: thierry 
State-Changed-When: Fri Apr 8 16:09:38 GMT 2005 
State-Changed-Why:  

Waiting for maintainer's approval. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=79639 
Responsible-Changed-From-To: freebsd-ports-bugs->thierry 
Responsible-Changed-By: thierry 
Responsible-Changed-When: Fri Apr 8 16:10:47 GMT 2005 
Responsible-Changed-Why:  

Take it. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=79639 

From: Thierry Thomas <thierry@FreeBSD.org>
To: Ryo MIYAMOTO <rmiya@cc.hirosaki-u.ac.jp>
Cc: Johan van Selst <johans@stack.nl>,
	FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/79639: biology/deft: patch for compilation on FreeBSD 5.x
Date: Thu, 12 May 2005 21:32:00 +0200

 Le Lun 11 avr 05  12:16:10 +0200, Johan van Selst <johans@stack.nl>
  crivait:
 > Ryo MIYAMOTO wrote:
 > > Then, I recommend as a maintainer that 
 > > 0) Johan's patches are rejected, at this time; if all warings and/or 
 > >    errors were removed, his patches might be included as a result. 
 > > 1) Try another fortran compilers (e.g. lang/gfortran, lang/ifc7, etc.) 
 > > 2) or use older version of gcc (I don't know how to do it).  
 > > 3) Could you please send me a log of ``make build'' ? 
 > >    I may say something about this problem. 
 > 
 > Of course: attached are build logs from FreeBSD-STABLE using current
 > ports settings (ftn77), using my patch, using f77 and using f2c.
 > 
 > I canceled the build with f77, after it got stalled (busy for half an
 > hour) on the compile of 'gradcddd.f'. Maybe I was impatient - but half
 > an hour seems somewhat excessive.
 
 Ryo,
 
 This PR is now in the state "feedback" since Apr 8; do you still reject
 Johan's patches?
 
 If "yes", I shall close this PR; else, I should commit it.
 
 If you need some more time to investigate, let me know, and I shall
 suspend it.
 
 Truly yours,
 -- 
 Th. Thomas.
State-Changed-From-To: feedback->suspended 
State-Changed-By: thierry 
State-Changed-When: Sun Jul 3 13:10:39 GMT 2005 
State-Changed-Why:  

Rejected by maintainer. 

Don't close this PR, because this port is still marked BROKEN 
and should be fixed. 

Anyway, thanks for your submission. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=79639 

From: Sam Lawrance <lawrance@FreeBSD.org>
To: johans@stack.nl, bug-followup@FreeBSD.org,
   Ryo MIYAMOTO <rmiya@cc.hirosaki-u.ac.jp>
Cc:  
Subject: Re: ports/79639: biology/deft: patch for compilation on FreeBSD 5.x
Date: Sat, 06 Aug 2005 22:37:36 +1000

 Hello all,
 
 Why was Johan's original patch rejected?
 
 Also - although it does take a long time on slower machines, the base
 system fortran compiler f77 will build the port with no problem on 4.x,
 5.x and 6.x.
 
 One of these options is probably better than leaving the port marked
 BROKEN.
 
 Regards
 Sam
 
 
State-Changed-From-To: suspended->closed 
State-Changed-By: lawrance 
State-Changed-When: Sat Dec 17 07:35:10 UTC 2005 
State-Changed-Why:  
When I tested these patches they were useful.  In any case 
biology/deft is still BROKEN and now earmarked for removal  
in 14 days time. 

Closed without action. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79639 
>Unformatted:
