From boris@brooknet.com.au  Thu Apr  7 10:27:46 2005
Return-Path: <boris@brooknet.com.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0BB4516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Apr 2005 10:27:46 +0000 (GMT)
Received: from bloodwood.hunterlink.net.au (smtp-local.hunterlink.net.au [203.12.144.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AC3ED43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Apr 2005 10:27:44 +0000 (GMT)
	(envelope-from boris@brooknet.com.au)
Received: from localhost (ppp298A.dyn.pacific.net.au [61.8.41.138])
	by bloodwood.hunterlink.net.au (8.12.8/8.12.8) with ESMTP id j37ARRJn020108;
	Thu, 7 Apr 2005 20:27:27 +1000
Received: by localhost (Postfix, from userid 0)
	id E951B18E; Thu,  7 Apr 2005 20:27:34 +1000 (EST)
Message-Id: <20050407102734.E951B18E@localhost>
Date: Thu,  7 Apr 2005 20:27:34 +1000 (EST)
From: Sam Lawrance <boris@brooknet.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc: erik@smluc.org
Subject: [PATCH] lang/gauche: add PORTDOCS dir for benefit of other ports
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         79620
>Category:       ports
>Synopsis:       [PATCH] lang/gauche: add PORTDOCS dir for benefit of other ports
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 07 10:30:08 GMT 2005
>Closed-Date:    Sat Apr 09 15:15:38 GMT 2005
>Last-Modified:  Sat Apr 09 15:15:38 GMT 2005
>Originator:     Sam Lawrance
>Release:        FreeBSD 5.4-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD dirk.no.domain 5.4-PRERELEASE FreeBSD 5.4-PRERELEASE #11: Sun Mar  6 12:44:50 EST
>Description:
A number of gauche "module" ports install docs into
share/doc/gauche/XYZZY, and have to worry about removing
it when they are deinstalled.

This causes a small problem for gauche-gaunit because of the order
in which the packing list commands are executed, ie
@unexec rmdir %D/share/doc/gauche followed by removal of
PORTDOCS entries under share/doc/gauche (obviously you can't rmdir
share/doc/gauche before the PORTDOCS are removed, so it doesn't work).

>How-To-Repeat:
>Fix:

Add share/doc/gauche (and a .keepme) to the install and pkg-plist

--- gauche-0.8.3_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/lang/gauche/Makefile,v
retrieving revision 1.31
diff -u -r1.31 Makefile
--- Makefile	20 Feb 2005 14:52:28 -0000	1.31
+++ Makefile	7 Apr 2005 10:13:29 -0000
@@ -58,6 +58,8 @@
 	${TOUCH} ${PREFIX}/share/gauche/site/lib/.keepme
 	${TOUCH} ${PREFIX}/lib/gauche/site/${PORTVERSION}/${CONFIGURE_TARGET}/.keepme
 	${MKDIR} ${PREFIX}/share/gauche/${PORTVERSION}/lib/.packages
+	${MKDIR} ${DOCSDIR}
+	${TOUCH} ${DOCSDIR}/.keepme
 
 .if !defined(NOPORTDOCS)
 	${INSTALL_MAN} ${WRKSRC}/doc/*.1 ${MANPREFIX}/man/man1/
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/lang/gauche/pkg-plist,v
retrieving revision 1.17
diff -u -r1.17 pkg-plist
--- pkg-plist	20 Feb 2005 14:52:28 -0000	1.17
+++ pkg-plist	7 Apr 2005 08:11:01 -0000
@@ -210,6 +210,7 @@
 share/gauche/%%VERSION%%/lib/www/cgi-test.scm
 share/gauche/%%VERSION%%/lib/www/cgi.scm
 share/gauche/site/lib/.keepme
+%%DOCSDIR%%/.keepme
 @dirrm share/gauche/site/lib
 @dirrm share/gauche/site
 @dirrm share/gauche/%%VERSION%%/lib/www
@@ -244,3 +245,4 @@
 @dirrm lib/gauche/%%VERSION%%/%%TARGET%%
 @dirrm lib/gauche/%%VERSION%%
 @dirrm lib/gauche
+@dirrm %%DOCSDIR%%
--- gauche-0.8.3_1.patch ends here ---

>Release-Note:
>Audit-Trail:

From: Sam Lawrance <boris@brooknet.com.au>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: erik@smluc.org
Subject: Re: ports/79620: [PATCH] lang/gauche: add PORTDOCS dir for benefit
	of other ports
Date: Thu, 07 Apr 2005 20:36:25 +1000

 --=-X2OoXd0Uo4Of+Ib4xilg
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 Perhaps it would be a good idea for EXAMPLESDIR as well. Patch attached.
 We'll see what the maintainer thinks.
 
 
 --=-X2OoXd0Uo4Of+Ib4xilg
 Content-Disposition: attachment; filename=gauche_examples_as_well
 Content-Type: text/plain; name=gauche_examples_as_well; charset=ASCII
 Content-Transfer-Encoding: 7bit
 
 --- Makefile.orig	Thu Apr  7 20:13:29 2005
 +++ Makefile	Thu Apr  7 20:32:35 2005
 @@ -60,6 +60,8 @@
  	${MKDIR} ${PREFIX}/share/gauche/${PORTVERSION}/lib/.packages
  	${MKDIR} ${DOCSDIR}
  	${TOUCH} ${DOCSDIR}/.keepme
 +	${MKDIR} ${EXAMPLESDIR}
 +	${TOUCH} ${EXAMPLESDIR}/.keepme
  
  .if !defined(NOPORTDOCS)
  	${INSTALL_MAN} ${WRKSRC}/doc/*.1 ${MANPREFIX}/man/man1/
 --- pkg-plist.orig	Thu Apr  7 18:11:01 2005
 +++ pkg-plist	Thu Apr  7 20:33:47 2005
 @@ -211,6 +211,7 @@
  share/gauche/%%VERSION%%/lib/www/cgi.scm
  share/gauche/site/lib/.keepme
  %%DOCSDIR%%/.keepme
 +%%EXAMPLESDIR%%/.keepme
  @dirrm share/gauche/site/lib
  @dirrm share/gauche/site
  @dirrm share/gauche/%%VERSION%%/lib/www
 @@ -246,3 +247,4 @@
  @dirrm lib/gauche/%%VERSION%%
  @dirrm lib/gauche
  @dirrm %%DOCSDIR%%
 +@dirrm %%EXAMPLESDIR%%
 
 --=-X2OoXd0Uo4Of+Ib4xilg--
 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Fri Apr 8 22:01:13 GMT 2005 
State-Changed-Why:  
Maintainer asked for approval 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Fri Apr 8 22:01:13 GMT 2005 
Responsible-Changed-Why:  
Track 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79620 

From: Pav Lucistnik <pav@FreeBSD.org>
To: erik@smluc.org, freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/79620: [PATCH] lang/gauche: add PORTDOCS dir for benefit
	of other ports
Date: Sat, 09 Apr 2005 00:01:11 +0200

 Dear maintainer of FreeBSD port lang/gauche, please review a patch at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=79620
 
 and tell me if you approve it or not.
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 It whines, glows and fades...

From: Erik Greenwald <erik@smluc.org>
To: freebsd-gnats-submit@FreeBSD.org, pav@freebsd.org
Cc: egreenwald@arl.army.mil
Subject: Re: ports/79620: [PATCH] lang/gauche: add PORTDOCS dir for benefit
Date: Fri, 8 Apr 2005 21:37:40 -0500

 I'm easy, it all works for me... both the doc and the example dir...
 
 Thanks for stopping and asking for my approval :)
 
 *pets* to scheme and fbsd o.O
 
 -- 
         -Erik <erik@smluc.org> [http://math.smsu.edu/~erik] efnet: ``Erik
 
 The opinions expressed by me are not necessarily opinions. In all probability,
 they are random rambling, and to be ignored. Failure to ignore may result in
 severe boredom or confusion. Shake well before opening. Keep Refrigerated.
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Sat Apr 9 15:15:30 GMT 2005 
State-Changed-Why:  
Applied, and more :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=79620 
>Unformatted:
