From khera@kcilink.com  Mon Mar 14 19:55:22 2005
Return-Path: <khera@kcilink.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BE3F416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Mar 2005 19:55:22 +0000 (GMT)
Received: from yertle.kcilink.com (yertle.kcilink.com [65.205.34.180])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4489743D39
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Mar 2005 19:55:22 +0000 (GMT)
	(envelope-from khera@kcilink.com)
Received: by yertle.kcilink.com (Postfix, from userid 1002)
	id 242C5B857; Mon, 14 Mar 2005 14:55:21 -0500 (EST)
Message-Id: <20050314195521.242C5B857@yertle.kcilink.com>
Date: Mon, 14 Mar 2005 14:55:21 -0500 (EST)
From: Vivek Khera <vivek@khera.org>
Reply-To: Vivek Khera <vivek@khera.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: mDNSResponder compile warnings on amd64
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         78841
>Category:       ports
>Synopsis:       mDNSResponder compile warnings on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 14 20:00:08 GMT 2005
>Closed-Date:    Wed Mar 16 12:46:47 GMT 2005
>Last-Modified:  Wed Mar 16 12:46:47 GMT 2005
>Originator:     Vivek Khera
>Release:        FreeBSD 5.3-STABLE amd64
>Organization:
>Environment:
System: FreeBSD yertle.int.kciLink.com 5.3-STABLE FreeBSD 5.3-STABLE #0: Fri Jan 7 16:42:37 EST 2005 khera@yertle.int.kciLink.com:/usr/obj/usr/src/sys/YERTLE amd64


	
>Description:
	

building mDNSResponder results in the following warnings, which probably will
cause run-time problems given that the printf code will want to read a long
when it is really given just an integer.


[root@yertle]# make
===>  Vulnerability check disabled, database not found
===>  Extracting for mDNSResponder-98
=> Checksum OK for mDNSResponder-98.tar.gz.
/usr/ports/distfiles//mDNSResponder-98.tar.gz:   80.4%
===>  Patching for mDNSResponder-98
===>  Applying FreeBSD patches for mDNSResponder-98
===>   mDNSResponder-98 depends on executable: gmake - found
===>  Configuring for mDNSResponder-98
===>  Building for mDNSResponder-98
Responder daemon done
Client library done
Client.c: In function `main':
Client.c:275: warning: long int format, different type arg (arg 4)
Embedded Standalone Client done
Responder.c: In function `main':
Responder.c:835: warning: long int format, different type arg (arg 4)
Embedded Standalone Responder done
ProxyResponder.c: In function `main':
ProxyResponder.c:325: warning: long int format, different type arg (arg 3)
Embedded Standalone ProxyResponder done
Identify.c: In function `main':
Identify.c:403: warning: long int format, different type arg (arg 3)
Identify done
NetMonitor.c: In function `main':
NetMonitor.c:1129: warning: long int format, different type arg (arg 4)
NetMonitor done
dnsextd done


>How-To-Repeat:
	

"make" in net/mDNSResponder on an amd64 (or any 64-bit architecture).

>Fix:

	


cast the arg to (long) in the above files.

>Release-Note:
>Audit-Trail:

From: Vivek Khera <vivek@khera.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/78841: mDNSResponder compile warnings on amd64
Date: Mon, 14 Mar 2005 15:12:04 -0500

 --Apple-Mail-12--620061166
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=US-ASCII;
 	format=flowed
 
 
 Here's a patch file to drop into the files subdir of the port.
 
 
 --Apple-Mail-12--620061166
 Content-Transfer-Encoding: 7bit
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="patch-mDNSPosix"
 Content-Disposition: attachment;
 	filename=patch-mDNSPosix
 
 --- mDNSPosix/#Client.c~	Mon Mar 14 14:59:47 2005
 +++ mDNSPosix/Client.c	Mon Mar 14 14:59:47 2005
 @@ -272,7 +272,7 @@
          result = 2;
      }
      if ( (result != 0) || (gMDNSPlatformPosixVerboseLevel > 0) ) {
 -        fprintf(stderr, "%s: Finished with status %ld, result %d\n", gProgramName, status, result);
 +        fprintf(stderr, "%s: Finished with status %ld, result %d\n", gProgramName, (long)status, result);
      }
  
      return 0;
 --- mDNSPosix/#Identify.c~	Mon Mar 14 15:00:56 2005
 +++ mDNSPosix/Identify.c	Mon Mar 14 15:00:56 2005
 @@ -400,7 +400,7 @@
      	gRRCache, RR_CACHE_SIZE,
      	mDNS_Init_DontAdvertiseLocalAddresses,
      	mDNS_Init_NoInitCallback, mDNS_Init_NoInitCallbackContext);
 -	if (status) { fprintf(stderr, "Daemon start: mDNS_Init failed %ld\n", status); return(status); }
 +	if (status) { fprintf(stderr, "Daemon start: mDNS_Init failed %ld\n", (long)status); return(status); }
  
  	signal(SIGINT, HandleSIG);	// SIGINT is what you get for a Ctrl-C
  	signal(SIGTERM, HandleSIG);
 --- mDNSPosix/#NetMonitor.c~	Mon Mar 14 15:01:26 2005
 +++ mDNSPosix/NetMonitor.c	Mon Mar 14 15:01:26 2005
 @@ -1126,7 +1126,7 @@
  		}
  
  	status = mDNSNetMonitor();
 -	if (status) { fprintf(stderr, "%s: mDNSNetMonitor failed %ld\n", progname, status); return(status); }
 +	if (status) { fprintf(stderr, "%s: mDNSNetMonitor failed %ld\n", progname, (long)status); return(status); }
  	return(0);
  
  usage:
 --- mDNSPosix/#Responder.c~	Mon Mar 14 15:01:05 2005
 +++ mDNSPosix/Responder.c	Mon Mar 14 15:01:05 2005
 @@ -832,7 +832,7 @@
          result = 2;
      }
      if ( (result != 0) || (gMDNSPlatformPosixVerboseLevel > 0) ) {
 -        fprintf(stderr, "%s: Finished with status %ld, result %d\n", gProgramName, status, result);
 +        fprintf(stderr, "%s: Finished with status %ld, result %d\n", gProgramName, (long)status, result);
      }
      
      return result;
 --- mDNSPosix/#ProxyResponder.c~	Mon Mar 14 15:06:18 2005
 +++ mDNSPosix/ProxyResponder.c	Mon Mar 14 15:06:19 2005
 @@ -322,7 +322,7 @@
  		mDNS_Init_NoCache, mDNS_Init_ZeroCacheSize,
  		mDNS_Init_DontAdvertiseLocalAddresses,
  		mDNS_Init_NoInitCallback, mDNS_Init_NoInitCallbackContext);
 -	if (status) { fprintf(stderr, "Daemon start: mDNS_Init failed %ld\n", status); return(status); }
 +	if (status) { fprintf(stderr, "Daemon start: mDNS_Init failed %ld\n", (long)status); return(status); }
  
  	mDNSPosixListenForSignalInEventLoop(SIGINT);
  	mDNSPosixListenForSignalInEventLoop(SIGTERM);
 
 --Apple-Mail-12--620061166--
 
Responsible-Changed-From-To: freebsd-ports-bugs->alfred 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Mar 16 09:24:38 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=78841 
Responsible-Changed-From-To: alfred->freebsd-ports-bugs 
Responsible-Changed-By: alfred 
Responsible-Changed-When: Wed Mar 16 11:21:54 GMT 2005 
Responsible-Changed-Why:  
Sorry, dropping maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=78841 
State-Changed-From-To: open->closed 
State-Changed-By: flz 
State-Changed-When: Wed Mar 16 12:44:35 GMT 2005 
State-Changed-Why:  
Committed, thanks! 
Note: I've rewritten the patch, modifying printf format makes more 
sense since exit status are ints, not longs. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=78841 
>Unformatted:
