From mike@inbox.lv  Sat Jan 29 04:24:32 2005
Return-Path: <mike@inbox.lv>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A5E4E16A4CE; Sat, 29 Jan 2005 04:24:32 +0000 (GMT)
Received: from out009.verizon.net (out009pub.verizon.net [206.46.170.131])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 00BDC43D39; Sat, 29 Jan 2005 04:24:32 +0000 (GMT)
	(envelope-from mike@inbox.lv)
Received: from ringworm.mechee.com ([4.26.84.7]) by out009.verizon.net
          (InterMail vM.5.01.06.06 201-253-122-130-106-20030910) with ESMTP
          id <20050129042431.WPUX19876.out009.verizon.net@ringworm.mechee.com>;
          Fri, 28 Jan 2005 22:24:31 -0600
Received: by ringworm.mechee.com (Postfix, from userid 1001)
	id 399B62CE743; Fri, 28 Jan 2005 20:20:34 -0800 (PST)
Message-Id: <20050129042034.399B62CE743@ringworm.mechee.com>
Date: Fri, 28 Jan 2005 20:20:34 -0800 (PST)
From: Michael C.Shultz <reso3w83@verizon.net>
Reply-To: Michael C.Shultz <reso3w83@verizon.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: andreas@FreeBSD.org, Gerard Seibert <gerard-seibert@rcn.com>
Subject: [CHANGE-REQUEST] print/apsfilter dependency change from shells/bash2 to shells/bash
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         76805
>Category:       ports
>Synopsis:       [CHANGE-REQUEST] print/apsfilter dependency change from shells/bash2 to shells/bash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    andreas
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 29 04:30:20 GMT 2005
>Closed-Date:    Sun Jan 30 11:54:49 GMT 2005
>Last-Modified:  Sun Jan 30 11:54:49 GMT 2005
>Originator:     Michael C. Shultz
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD ringworm.mechee.com 5.3-STABLE FreeBSD 5.3-STABLE #0: Thu Jan 20 07:27:28 PST 2005 root@ringworm.mechee.com:/ROUTER/obj/ROUTER/src-5.3/sys/RINGWORM i386


>Description:
	
	From an email by one of my portmanager users:

"I am aware of apsfilter's dependency on bash-2.05b.007_2. The problem is
that  bash has to write it files to the same location. There is no way,
at least that I am aware of, to have two versions of bash installed.
Besides, why would I want two versions. Furthermore, apsfilter runs just
fine with the newer version of bash. I intend to contact the maintainer
of apsfilter to see if he can find a solution to this problem also."

This seems easy enough to implement so only if the maintainer concurs
please consider updating apsfilter with the attached apsfilter-7.2.5_6.diff.

>How-To-Repeat:

	N/A

>Fix:

I've added a WITH_BASH2 option in case someone
has good reason for this and changed the default
bash dependency from shells/bash2 to shells/bash.
Makefile.diff is attached.


--- apsfilter-7.2.5_6.diff begins here ---
diff -ruN apsfilter/Makefile apsfilter-7.2.5_6/Makefile
--- apsfilter/Makefile	Thu Dec 23 18:05:31 2004
+++ apsfilter-7.2.5_6/Makefile	Fri Jan 28 20:05:48 2005
@@ -7,7 +7,7 @@
 
 PORTNAME=	apsfilter
 PORTVERSION=	7.2.5
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	print
 MASTER_SITES=	http://www.apsfilter.org/download/

@@ -113,7 +113,12 @@
 .endif
 
 # needed for aps2file :-/
+
+.if defined(WITH_BASH2)
 RUN_DEPENDS+=	bash:${PORTSDIR}/shells/bash2
+.else
+RUN_DEPENDS+=	bash:${PORTSDIR}/shells/bash
+.endif
 
 # HP IJS driver is not automatically part of ghostscript port anymore
 RUN_DEPENDS+=	hpijs:${PORTSDIR}/print/hpijs
--- apsfilter-7.2.5_6.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Mark Linimon <linimon@lonesome.com>
To: "Michael C.Shultz" <reso3w83@verizon.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org,
	Gerard Seibert <gerard-seibert@rcn.com>, <andreas@FreeBSD.org>,
	<freebsd-ports-bugs@FreeBSD.org>
Subject: Re: ports/76805: [CHANGE-REQUEST] print/apsfilter dependency change
 from shells/bash2 to shells/bash
Date: Fri, 28 Jan 2005 22:36:27 -0600 (CST)

 Yes, well, IIRC shells/bash was marked deprecated some time ago due
 to being obsolete, but also IIRC someone objected.
 
 Is there really a pressing reason to keep it around?
 
 mcl
 

From: "Michael C. Shultz" <reso3w83@verizon.net>
To: freebsd-gnats-submit@freebsd.org, reso3w83@verizon.net
Cc:  
Subject: Re: ports/76805: [CHANGE-REQUEST] print/apsfilter dependency change from shells/bash2 to shells/bash
Date: Fri, 28 Jan 2005 20:58:36 -0800

 Here is from http://www.freshports.org/shells/bash
 
 port moved here from shells/bash3 on 2004-08-11
 REASON: move latest stable version to unnumbered directory
 
 The most recent update is 19 Nov 2004 to version 3.0.16_1
 
 I don't see anything in its Makefile indicating it is depreciated.
 
 -Mike
Responsible-Changed-From-To: freebsd-ports-bugs->andreas 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sat Jan 29 16:34:30 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76805 
State-Changed-From-To: open->closed 
State-Changed-By: andreas 
State-Changed-When: Sun Jan 30 11:36:05 GMT 2005 
State-Changed-Why:  
closing PR, applied your suggested patch, thanks for reporting this issue 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76805 
>Unformatted:
