From nobody@FreeBSD.org  Mon Jan 17 22:29:57 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1B47016A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Jan 2005 22:29:57 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F33FA43D41
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Jan 2005 22:29:56 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j0HMTuNJ040756
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 17 Jan 2005 22:29:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j0HMTuFf040751;
	Mon, 17 Jan 2005 22:29:56 GMT
	(envelope-from nobody)
Message-Id: <200501172229.j0HMTuFf040751@www.freebsd.org>
Date: Mon, 17 Jan 2005 22:29:56 GMT
From: Nate Eldredge <nge@cs.hmc.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Typo in vobcopy breaks device detection
X-Send-Pr-Version: www-2.3

>Number:         76378
>Category:       ports
>Synopsis:       Typo in vobcopy breaks device detection
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lioux
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 17 22:30:24 GMT 2005
>Closed-Date:    Sun Feb 27 15:54:31 GMT 2005
>Last-Modified:  Sun Feb 27 15:54:31 GMT 2005
>Originator:     Nate Eldredge
>Release:        5.3-RELEASE-p2
>Organization:
>Environment:
FreeBSD mercury.lan 5.3-RELEASE-p2 FreeBSD 5.3-RELEASE-p2 #2: Wed Dec  1 17:26:26 PST 2004     nate@mercury.lan:/medium/obj/medium/src/sys/MERCURY  i386    
>Description:
The sysutils/vobcopy port has code to detect the DVD device, given the mount point.  It has an #ifdef to do this right for FreeBSD 5.x.  However,  in checking the FreeBSD version, it uses the nonexistent macro __FreeBSD_Version instead of the correct __FreeBSD_version.  Thus, when built, it does the wrong thing and tries to read from the wrong device.
>How-To-Repeat:
$ vobcopy -m -i /cdrom   
[Hint] You use -i. Normally this is not necessary, vobcopy finds the input dir by itself. This option is only there if vobcopy makes trouble.
[Hint] If vobcopy makes trouble, please mail me so that I can fix this (robos@muon.de). Thanks
Vobcopy 0.5.14 - GPL Copyright (c) 2001 - 2004 robos@muon.de
[Hint] All lines starting with "libdvdread:" are not from vobcopy but from the libdvdread-library

path to dvd: /dev/racd0
libdvdread: Can't stat /dev/racd0
No such file or directory

[Error] Path thingy didn't work '(null)'
[Error] Try someting like -i /cdrom, /dvd  or /mnt/dvd 

>Fix:
(tabs may be broken here, but the fix is one byte anyway...)

--- dvd.c.orig  Mon Jan 17 14:17:21 2005
+++ dvd.c       Mon Jan 17 14:17:38 2005
@@ -199,7 +199,7 @@
        if( !strcmp( path, buf.f_mntonname ) )
          { 
            mounted = TRUE;
-#if defined(__FreeBSD__) && (__FreeBSD_Version > 500000)
+#if defined(__FreeBSD__) && (__FreeBSD_version > 500000)
           strcpy(device, buf.f_mntfromname);
 #else
           strcpy(device, "/dev/r");

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lioux 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Jan 18 06:21:27 GMT 2005 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76378 
State-Changed-From-To: open->closed 
State-Changed-By: lioux 
State-Changed-When: Sun Feb 27 15:54:30 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76378 
>Unformatted:
