From conrads@cox.net  Mon Jan 17 17:02:16 2005
Return-Path: <conrads@cox.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7F4DB16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Jan 2005 17:02:16 +0000 (GMT)
Received: from lakermmtao06.cox.net (lakermmtao06.cox.net [68.230.240.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E600643D49
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Jan 2005 17:02:15 +0000 (GMT)
	(envelope-from conrads@cox.net)
Received: from dolphin.local.net ([68.14.122.164]) by lakermmtao06.cox.net
          (InterMail vM.6.01.04.00 201-2131-117-20041022) with ESMTP
          id <20050117170215.BZYS7687.lakermmtao06.cox.net@dolphin.local.net>;
          Mon, 17 Jan 2005 12:02:15 -0500
Received: from dolphin.local.net (localhost.local.net [127.0.0.1])
	by dolphin.local.net (8.13.1/8.13.1) with ESMTP id j0HH2Cca023207;
	Mon, 17 Jan 2005 11:02:12 -0600 (CST)
	(envelope-from conrads@dolphin.local.net)
Received: (from root@localhost)
	by dolphin.local.net (8.13.1/8.13.1/Submit) id j0HH25Y4023206;
	Mon, 17 Jan 2005 11:02:05 -0600 (CST)
	(envelope-from conrads)
Message-Id: <200501171702.j0HH25Y4023206@dolphin.local.net>
Date: Mon, 17 Jan 2005 11:02:05 -0600 (CST)
From: "Conrad J. Sabatier" <conrads@cox.net>
Reply-To: "Conrad J. Sabatier" <conrads@cox.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Edwin Groothuis <edwin@mavetju.org>
Subject: Maintainer update: games/gnuchess
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         76359
>Category:       ports
>Synopsis:       Maintainer update: games/gnuchess
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 17 17:10:19 GMT 2005
>Closed-Date:    Mon Jan 17 23:24:05 GMT 2005
>Last-Modified:  Mon Jan 17 23:24:05 GMT 2005
>Originator:     Conrad J. Sabatier
>Release:        FreeBSD 6.0-CURRENT amd64
>Organization:
none
>Environment:
System: FreeBSD dolphin.local.net 6.0-CURRENT FreeBSD 6.0-CURRENT #1: Tue Jan 11 01:03:24 CST 2005 root@dolphin.local.net:/usr/obj/usr/src/sys/CUSTOM amd64

>Description:
	Correct a problem with the fetching of the port's distfiles.
	See the comment in the attached diff for description of a possible
	bug in the ports' make system.
>How-To-Repeat:
	Attempting to build with the existing Makefile fails to fetch the 
	source distfile, regardless of whether WITH_OPENING_BOOK is on or 
	off.
>Fix:
	Apply the following patch:

--- gnuchess.diff begins here ---
diff -u -r --exclude=CVS --exclude=README.html /usr/ports/games/gnuchess/Makefile /root/gnuchess/Makefile
--- /usr/ports/games/gnuchess/Makefile	Mon Jan 17 10:53:38 2005
+++ /root/gnuchess/Makefile	Mon Jan 17 10:52:20 2005
@@ -11,6 +11,13 @@
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	chess
 
+# Note: there seems to be a bug in the ports' make system's handling of
+# the DISTFILES+= line later in the Makefile.  Unless we explicitly
+# declare the base DISTFILES list first (i.e., the source package),
+# it won't be fetched
+
+DISTFILES=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}
+
 MAINTAINER=	conrads@cox.net
 COMMENT=	"Classic" Gnu Chess
 
@@ -23,7 +30,7 @@
 		README
 .endif
 
-OPTIONS=    OPENING_BOOK "Install opening book (24 MB download)" on
+OPTIONS=	OPENING_BOOK "Install opening book (24 MB download)" on
 
 .include <bsd.port.pre.mk>
 
--- gnuchess.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Mon Jan 17 23:18:27 GMT 2005 
State-Changed-Why:  
Comitted, thanks! 

It isn't a bug in the ports system: If DISTFILES or DISTNAME is not 
specified, it will build the name from the name, version and extract 
suffix. But this is done in the bsd.port.post.mk part, not in the 
pre.mk-part. So your DISTFILES+= actually fills it in, instead of 
adding it (since there wasn't anything yet) 


http://www.freebsd.org/cgi/query-pr.cgi?pr=76359 
>Unformatted:
