From boris@brooknet.com.au  Tue Jan 11 11:43:51 2005
Return-Path: <boris@brooknet.com.au>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3CCF416A4CE; Tue, 11 Jan 2005 11:43:51 +0000 (GMT)
Received: from bloodwood.hunterlink.net.au (smtp-local.hunterlink.net.au [203.12.144.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 95B4F43D49; Tue, 11 Jan 2005 11:43:49 +0000 (GMT)
	(envelope-from boris@brooknet.com.au)
Received: from localhost (ppp2977.dyn.pacific.net.au [61.8.41.119])
	by bloodwood.hunterlink.net.au (8.12.8/8.12.8) with ESMTP id j0BBhW15007676;
	Tue, 11 Jan 2005 22:43:35 +1100
Received: by localhost (Postfix, from userid 1001)
	id A7A094D2; Tue, 11 Jan 2005 22:43:28 +1100 (EST)
Message-Id: <20050111114328.A7A094D2@localhost>
Date: Tue, 11 Jan 2005 22:43:28 +1100 (EST)
From: Sam Lawrance <boris@brooknet.com.au>
Reply-To: Sam Lawrance <boris@brooknet.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jon@witchspace.com, boris@brooknet.com.au, demon@freebsd.org,
	danfe@freebsd.org
Subject: [patch] Unquoted shell characters in IGNORE messages causing port error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         76095
>Category:       ports
>Synopsis:       [patch] Unquoted shell characters in IGNORE messages causing port error
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 11 11:50:35 GMT 2005
>Closed-Date:    Wed Jan 19 16:59:58 GMT 2005
>Last-Modified:  Wed Jan 19 16:59:58 GMT 2005
>Originator:     Sam Lawrance
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD dirk.no.domain 5.3-STABLE FreeBSD 5.3-STABLE #1: Sat Jan 1 22:56:44 EST 2005 sam@dirk.no.domain:/usr/obj/usr/src/sys/GENERIC i386


>Description:
	Due to the way the ignore message is output by bsd.port.mk, quoted IGNORE
messages containing unquoted shell characters may cause the command to fail. The IGNORE
message is not printed and the user is left with a cryptic error message.

	The following ports are affected:

	graphics/kix-kmod
	palm/uppc-kmod
	print/trueprint
	x11/nvidia-driver
	
Maintainers are cc'ed.

>How-To-Repeat:
	"make" any of the abovementioned ports under IGNOREable conditions.

>Fix:
	The IGNORE message should not be wrapped in "". If you don't believe me, take a
look at IGNORECMD in bsd.port.mk. If IGNORE is quoted in "", the quoting in IGNORECMD
ends up all wrong.

	Patch below removes "" quotes.
	
Index: graphics/kix-kmod/Makefile
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/graphics/kix-kmod/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- graphics/kix-kmod/Makefile	6 Feb 2004 13:11:27 -0000	1.5
+++ graphics/kix-kmod/Makefile	11 Jan 2005 11:30:42 -0000
@@ -15,7 +15,7 @@
 COMMENT=	A graphical screensaver kernel module
 
 .if !exists(/usr/src/sys/dev/syscons/syscons.h)
-IGNORE=		"Requires kernel source (/usr/src/sys) to build"
+IGNORE=		Requires kernel source (/usr/src/sys) to build
 .endif
 PLIST_FILES=	lib/kix_saver.ko
 
Index: palm/uppc-kmod/Makefile
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/palm/uppc-kmod/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- palm/uppc-kmod/Makefile	11 Dec 2004 21:48:53 -0000	1.8
+++ palm/uppc-kmod/Makefile	11 Jan 2005 11:31:37 -0000
@@ -19,7 +19,7 @@
 USE_REINPLACE=	yes
 
 .if !exists(/usr/src/sys/dev/usb/usb.h)
-IGNORE=		"Requires kernel source (/usr/src/sys) to build"
+IGNORE=		Requires kernel source (/usr/src/sys) to build
 .endif
 
 .include <bsd.port.pre.mk>
@@ -43,4 +43,7 @@
 	@${ECHO_CMD} "       * and set up a connection.                                     *"
 	@${ECHO_CMD} "       ****************************************************************"
 
+test:
+	echo ${IGNORE}
+	echo ${IGNORECMD}
 .include <bsd.port.post.mk>
Index: print/trueprint/Makefile
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/print/trueprint/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- print/trueprint/Makefile	4 Feb 2004 05:08:39 -0000	1.7
+++ print/trueprint/Makefile	11 Jan 2005 11:31:47 -0000
@@ -20,7 +20,7 @@
 
 # Doesn't configure on bento because of this
 .if !exists(/usr/bin/lpr) || !exists(/usr/bin/lp)
-IGNORE=		"missing /usr/bin/lp or /usr/bin/lpr (hi bento)"
+IGNORE=		missing /usr/bin/lp or /usr/bin/lpr (hi bento)
 .endif
 
 MAN1=		trueprint.1
Index: x11/nvidia-driver/Makefile
===================================================================
RCS file: /home/ncvs/FreeBSD/ports/x11/nvidia-driver/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- x11/nvidia-driver/Makefile	31 Dec 2004 18:24:09 -0000	1.24
+++ x11/nvidia-driver/Makefile	11 Jan 2005 11:32:07 -0000
@@ -49,7 +49,7 @@
 .endif
 
 .if ${OSVERSION} < 490000 || ${OSVERSION} >= 500000 && ${OSVERSION} < 502001
-IGNORE=		"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
+IGNORE=		supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)
 .endif
 
 .if ${OSVERSION} < 500000


>Release-Note:
>Audit-Trail:

From: Sam Lawrance <boris@brooknet.com.au>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/76095: [patch] Unquoted shell characters in IGNORE messages
 causing port error
Date: Tue, 11 Jan 2005 23:12:37 +1100

 Bugger, I left 3 lines in uppc-kmod that I didn't mean to (the "test" 
 target). Committer, pretty please tweak them out for me. Cheers.
 
 -- 
 Sam Lawrance    ph +61 0425 228 579    freenode: deft
 

From: Sam Lawrance <boris@brooknet.com.au>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/76095: [patch] Unquoted shell characters in IGNORE messages
 causing port error
Date: Fri, 14 Jan 2005 13:43:29 +1100

 Forwarded message
 -------- Original Message --------
 Subject: 	Re: [patch] Unquoted shell characters in IGNORE messages 
 causing port error
 Date: 	Tue, 11 Jan 2005 12:58:39 -0000 (GMT)
 From: 	Jonathan Belson <jon@witchspace.com>
 To: 	Sam Lawrance <boris@brooknet.com.au>
 CC: 	freebsd-gnats-submit@freebsd.org
 References: 	<20050111114328.A7A094D2@localhost>
 
 
 
 Hiya
 
 The kix-kmod change looks fine to me; feel free to apply the patch.
 
 Cheers,
 
 --Jon
 
 http://www.witchspace.com
 
 
 
State-Changed-From-To: open->closed 
State-Changed-By: vs 
State-Changed-When: Wed Jan 19 16:59:26 GMT 2005 
State-Changed-Why:  
Fixed, thanks! I just committed the two last changes. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76095 
>Unformatted:
