From flz@xbsd.org  Mon Jan 10 09:29:24 2005
Return-Path: <flz@xbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CB6D016A4CE; Mon, 10 Jan 2005 09:29:24 +0000 (GMT)
Received: from gate.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 11A6243D1F; Mon, 10 Jan 2005 09:29:24 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by gate.xbsd.org (Postfix) with ESMTP id 8662211976;
	Mon, 10 Jan 2005 10:30:26 +0100 (CET)
Received: from gate.xbsd.org ([127.0.0.1])
 by localhost (gate.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 98514-06; Mon, 10 Jan 2005 10:30:17 +0100 (CET)
Received: by gate.xbsd.org (Postfix, from userid 2001)
	id E020211967; Mon, 10 Jan 2005 10:30:16 +0100 (CET)
Message-Id: <20050110093016.E020211967@gate.xbsd.org>
Date: Mon, 10 Jan 2005 10:30:16 +0100 (CET)
From: Florent Thoumie <flz@xbsd.org>
Reply-To: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: lioux@FreeBSD.org
Subject: New port: net/libtorrent - BitTorrent Library written in C++
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         76033
>Category:       ports
>Synopsis:       New port: net/libtorrent - BitTorrent Library written in C++
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lioux
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 10 09:30:25 GMT 2005
>Closed-Date:    Wed Jan 12 10:20:37 GMT 2005
>Last-Modified:  Wed Jan 12 10:20:37 GMT 2005
>Originator:     Florent Thoumie
>Release:        FreeBSD 5.3-RELEASE i386
>Organization:
Xbsd.org
>Environment:

System: FreeBSD gate.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386

>Description:

LibTorrent is a BitTorrent library written in C++ for *nix. It is designed to avoid
redundant copying and storing of data that other clients and libraries suffer from.
Licensed under the GPL.

WWW: http://libtorrent.rakshasa.no

Tinderbox Buildlogs available on :

http://www.xbsd.org/tb/logs/4-STABLE-FreeBSD/libtorrent-0.4.5.log
http://www.xbsd.org/tb/logs/5-STABLE-FreeBSD/libtorrent-0.4.5.log
http://www.xbsd.org/tb/logs/6-CURRENT-FreeBSD/libtorrent-0.4.5.log

>How-To-Repeat:

N/A

>Fix:

--- libtorrent-0.4.5.shar begins here ---
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	libtorrent
#	libtorrent/files
#	libtorrent/files/patch-src::data::file.cc
#	libtorrent/files/patch-client::rtorrent.cc
#	libtorrent/files/patch-src::torrent::torrent.h
#	libtorrent/Makefile
#	libtorrent/distinfo
#	libtorrent/pkg-descr
#	libtorrent/pkg-plist
#
echo c - libtorrent
mkdir -p libtorrent > /dev/null 2>&1
echo c - libtorrent/files
mkdir -p libtorrent/files > /dev/null 2>&1
echo x - libtorrent/files/patch-src::data::file.cc
sed 's/^X//' >libtorrent/files/patch-src::data::file.cc << 'END-of-libtorrent/files/patch-src::data::file.cc'
X--- src/data/file.cc.old	Fri Jan  7 14:35:43 2005
X+++ src/data/file.cc	Fri Jan  7 14:36:35 2005
X@@ -19,8 +19,9 @@
X 		  (flags & in && flags & out ? O_RDWR :
X 		   (flags & in  ? O_RDONLY : 0) |
X 		   (flags & out ? O_WRONLY : 0)) |
X-		  
X+#if defined(Linux) 
X 		  (flags & largefile ? O_LARGEFILE : 0) |
X+#endif
X 		  (flags & create    ? O_CREAT     : 0) |
X 		  (flags & truncate  ? O_TRUNC     : 0) |
X 		  (flags & nonblock  ? O_NONBLOCK  : 0),
END-of-libtorrent/files/patch-src::data::file.cc
echo x - libtorrent/files/patch-client::rtorrent.cc
sed 's/^X//' >libtorrent/files/patch-client::rtorrent.cc << 'END-of-libtorrent/files/patch-client::rtorrent.cc'
X--- client/rtorrent.cc.old	Fri Jan  7 15:04:15 2005
X+++ client/rtorrent.cc	Fri Jan  7 15:04:57 2005
X@@ -19,9 +19,9 @@
X #include "curl_get.h"
X 
X // Uncomment this if your system doesn't have execinfo.h
X-#define USE_EXECINFO
X+//#define USE_EXECINFO
X 
X-#ifdef USE_EXECINFO
X+#ifdef USE_EXECINFO 
X #include <execinfo.h>
X #endif
X 
END-of-libtorrent/files/patch-client::rtorrent.cc
echo x - libtorrent/files/patch-src::torrent::torrent.h
sed 's/^X//' >libtorrent/files/patch-src::torrent::torrent.h << 'END-of-libtorrent/files/patch-src::torrent::torrent.h'
X--- src/torrent/torrent.h.old	Fri Jan  7 22:34:09 2005
X+++ src/torrent/torrent.h	Fri Jan  7 22:51:03 2005
X@@ -4,6 +4,8 @@
X #include <list>
X #include <torrent/common.h>
X #include <torrent/download.h>
X+#include <sys/types.h>
X+#include <sys/select.h>
X 
X namespace torrent {
X 
END-of-libtorrent/files/patch-src::torrent::torrent.h
echo x - libtorrent/Makefile
sed 's/^X//' >libtorrent/Makefile << 'END-of-libtorrent/Makefile'
X# New ports collection makefile for:	libtorrent
X# Date created:				Jan 07 2005
X# Whom:					Florent Thoumie <flz@xbsd.org>
X#
X# $FreeBSD$
X#
X
XPORTNAME=	libtorrent
XPORTVERSION=	0.4.5
XCATEGORIES=	net
XMASTER_SITES=	http://libtorrent.rakshasa.no/downloads/
X
XMAINTAINER=	flz@xbsd.org
XCOMMENT=	BitTorrent Library written in C++
X
XLIB_DEPENDS=	curl.3:${PORTSDIR}/ftp/curl \
X		sigc-2.0.0:${PORTSDIR}/devel/libsigc++20
X
XUSE_REINPLACE=	yes
XGNU_CONFIGURE=	yes
XCONFIGURE_TARGET=	--build=${ARCH}-portbld-freebsd${OSREL}
X
XWITH_CLIENT?=	no
X
X.include <bsd.port.pre.mk>
X
X.if ${OSVERSION} < 500000
XUSE_GCC=	3.4
X.endif
X
X.if ${WITH_CLIENT:L} == "yes"
X.if ${OSVERSION} < 500000
XBROKEN=		Client doesn't compile on 4.x.
X.endif
X
XPLIST_FILES=	bin/rtorrent
X
Xpost-patch:
X	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" ${WRKSRC}/client/Makefile2
XPLIST_FILES=	bin/rtorrent
X
Xpost-patch:
X	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" ${WRKSRC}/client/Makefile2
X
Xpost-build:
X	@(cd ${WRKSRC}/client; make -f Makefile2)
X
Xpost-install:
X	${INSTALL_PROGRAM} ${WRKSRC}/client/rtorrent ${PREFIX}/bin
X.endif
X
X.include <bsd.port.post.mk>
END-of-libtorrent/Makefile
echo x - libtorrent/distinfo
sed 's/^X//' >libtorrent/distinfo << 'END-of-libtorrent/distinfo'
XMD5 (libtorrent-0.4.5.tar.gz) = 86c38d9036e083c9c2b21b88f7d847fa
XSIZE (libtorrent-0.4.5.tar.gz) = 401624
END-of-libtorrent/distinfo
echo x - libtorrent/pkg-descr
sed 's/^X//' >libtorrent/pkg-descr << 'END-of-libtorrent/pkg-descr'
XLibTorrent is a BitTorrent library written in C++ for *nix. It is designed to avoid
Xredundant copying and storing of data that other clients and libraries suffer from.
XLicensed under the GPL.
X
XWWW: http://libtorrent.rakshasa.no
X
X- Florent Thoumie
Xflz@xbsd.org
END-of-libtorrent/pkg-descr
echo x - libtorrent/pkg-plist
sed 's/^X//' >libtorrent/pkg-plist << 'END-of-libtorrent/pkg-plist'
Xinclude/torrent/common.h
Xinclude/torrent/download.h
Xinclude/torrent/exceptions.h
Xinclude/torrent/entry.h
Xinclude/torrent/http.h
Xinclude/torrent/peer.h
Xinclude/torrent/torrent.h
Xlib/libtorrent.so
Xlib/libtorrent.so.2
Xlib/libtorrent.la
Xlib/pkgconfig/libtorrent.pc
X@dirrm include/torrent
X@unexec rmdir %D/lib/pkgconfig 2> /dev/null || true
END-of-libtorrent/pkg-plist
exit
--- libtorrent-0.4.5.shar ends here ---
>Release-Note:
>Audit-Trail:

From: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org,
	lioux@FreeBSD.org
Cc:  
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written
 in C++
Date: Mon, 10 Jan 2005 10:54:43 +0100

 I forgot to run portlint.
 
 I've modified some things in the port, I'm waiting for tinderbox logs
 to re-send the shar archive.
 
 Sorry for inconvenience.

From: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org,
	lioux@FreeBSD.org
Cc:  
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written
 in C++
Date: Mon, 10 Jan 2005 12:17:53 +0100

 This is a multi-part message in MIME format.
 --------------020209040209020001000205
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Here is the corrected version.
 
 Buildlogs have been updated.
 
 --------------020209040209020001000205
 Content-Type: text/plain;
  name="libtorrent-0.4.5.shar"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="libtorrent-0.4.5.shar"
 
 # This is a shell archive.  Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file".  Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 #	libtorrent
 #	libtorrent/files
 #	libtorrent/files/patch-src::data::file.cc
 #	libtorrent/files/patch-client::rtorrent.cc
 #	libtorrent/files/patch-src::torrent::torrent.h
 #	libtorrent/Makefile
 #	libtorrent/distinfo
 #	libtorrent/pkg-descr
 #	libtorrent/pkg-plist
 #
 echo c - libtorrent
 mkdir -p libtorrent > /dev/null 2>&1
 echo c - libtorrent/files
 mkdir -p libtorrent/files > /dev/null 2>&1
 echo x - libtorrent/files/patch-src::data::file.cc
 sed 's/^X//' >libtorrent/files/patch-src::data::file.cc << 'END-of-libtorrent/files/patch-src::data::file.cc'
 X--- src/data/file.cc.old	Fri Jan  7 14:35:43 2005
 X+++ src/data/file.cc	Fri Jan  7 14:36:35 2005
 X@@ -19,8 +19,9 @@
 X 		  (flags & in && flags & out ? O_RDWR :
 X 		   (flags & in  ? O_RDONLY : 0) |
 X 		   (flags & out ? O_WRONLY : 0)) |
 X-		  
 X+#if defined(Linux) 
 X 		  (flags & largefile ? O_LARGEFILE : 0) |
 X+#endif
 X 		  (flags & create    ? O_CREAT     : 0) |
 X 		  (flags & truncate  ? O_TRUNC     : 0) |
 X 		  (flags & nonblock  ? O_NONBLOCK  : 0),
 END-of-libtorrent/files/patch-src::data::file.cc
 echo x - libtorrent/files/patch-client::rtorrent.cc
 sed 's/^X//' >libtorrent/files/patch-client::rtorrent.cc << 'END-of-libtorrent/files/patch-client::rtorrent.cc'
 X--- client/rtorrent.cc.old	Fri Jan  7 15:04:15 2005
 X+++ client/rtorrent.cc	Fri Jan  7 15:04:57 2005
 X@@ -19,9 +19,9 @@
 X #include "curl_get.h"
 X 
 X // Uncomment this if your system doesn't have execinfo.h
 X-#define USE_EXECINFO
 X+//#define USE_EXECINFO
 X 
 X-#ifdef USE_EXECINFO
 X+#ifdef USE_EXECINFO 
 X #include <execinfo.h>
 X #endif
 X 
 END-of-libtorrent/files/patch-client::rtorrent.cc
 echo x - libtorrent/files/patch-src::torrent::torrent.h
 sed 's/^X//' >libtorrent/files/patch-src::torrent::torrent.h << 'END-of-libtorrent/files/patch-src::torrent::torrent.h'
 X--- src/torrent/torrent.h.old	Fri Jan  7 22:34:09 2005
 X+++ src/torrent/torrent.h	Fri Jan  7 22:51:03 2005
 X@@ -4,6 +4,8 @@
 X #include <list>
 X #include <torrent/common.h>
 X #include <torrent/download.h>
 X+#include <sys/types.h>
 X+#include <sys/select.h>
 X 
 X namespace torrent {
 X 
 END-of-libtorrent/files/patch-src::torrent::torrent.h
 echo x - libtorrent/Makefile
 sed 's/^X//' >libtorrent/Makefile << 'END-of-libtorrent/Makefile'
 X# New ports collection makefile for:	libtorrent
 X# Date created:				Jan 07 2005
 X# Whom:					Florent Thoumie <flz@xbsd.org>
 X#
 X# $FreeBSD$
 X#
 X
 XPORTNAME=	libtorrent
 XPORTVERSION=	0.4.5
 XCATEGORIES=	net
 XMASTER_SITES=	http://libtorrent.rakshasa.no/downloads/
 X
 XMAINTAINER=	flz@xbsd.org
 XCOMMENT=	BitTorrent Library written in C++
 X
 XLIB_DEPENDS=	curl.3:${PORTSDIR}/ftp/curl \
 X		sigc-2.0.0:${PORTSDIR}/devel/libsigc++20
 X
 XUSE_REINPLACE=	yes
 XINSTALLS_SHLIB=	yes
 XUSE_LIBTOOL_VER=	15
 XCONFIGURE_TARGET=	--build=${ARCH}-portbld-freebsd${OSREL}
 X
 XWITH_CLIENT?=	no
 X
 X.include <bsd.port.pre.mk>
 X
 X.if ${OSVERSION} < 500000
 XUSE_GCC=	3.4
 X.endif
 X
 Xpost-patch:
 X	@${REINPLACE_CMD} -e "s#\(pkgconfigdir =\).*#\1 ${PREFIX}/libexec/pkgconfig#" \
 X			${WRKSRC}/Makefile.in
 X	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" ${WRKSRC}/client/Makefile2
 X
 X.if ${WITH_CLIENT:L} == "yes"
 X.if ${OSVERSION} < 500000
 XBROKEN=		Client doesn't compile on 4.x.
 X.endif
 X
 XPLIST_FILES=	bin/rtorrent
 X
 Xpost-build:
 X	@(cd ${WRKSRC}/client; make -f Makefile2)
 X
 Xpost-install:
 X	${INSTALL_PROGRAM} ${WRKSRC}/client/rtorrent ${PREFIX}/bin
 X.endif
 X
 X.include <bsd.port.post.mk>
 END-of-libtorrent/Makefile
 echo x - libtorrent/distinfo
 sed 's/^X//' >libtorrent/distinfo << 'END-of-libtorrent/distinfo'
 XMD5 (libtorrent-0.4.5.tar.gz) = 86c38d9036e083c9c2b21b88f7d847fa
 XSIZE (libtorrent-0.4.5.tar.gz) = 401624
 END-of-libtorrent/distinfo
 echo x - libtorrent/pkg-descr
 sed 's/^X//' >libtorrent/pkg-descr << 'END-of-libtorrent/pkg-descr'
 XLibTorrent is a BitTorrent library written in C++ for *nix. It is designed to
 Xavoid redundant copying and storing of data that other clients and libraries
 Xsuffer from. Licensed under the GPL.
 X
 XWWW: http://libtorrent.rakshasa.no
 X
 X- Florent Thoumie
 Xflz@xbsd.org
 END-of-libtorrent/pkg-descr
 echo x - libtorrent/pkg-plist
 sed 's/^X//' >libtorrent/pkg-plist << 'END-of-libtorrent/pkg-plist'
 Xinclude/torrent/common.h
 Xinclude/torrent/download.h
 Xinclude/torrent/exceptions.h
 Xinclude/torrent/entry.h
 Xinclude/torrent/http.h
 Xinclude/torrent/peer.h
 Xinclude/torrent/torrent.h
 Xlib/libtorrent.a
 Xlib/libtorrent.so
 Xlib/libtorrent.so.2
 Xlibexec/pkgconfig/libtorrent.pc
 X@dirrm include/torrent
 X@unexec rmdir %D/libexec/pkgconfig 2> /dev/null || true
 END-of-libtorrent/pkg-plist
 exit
 
 
 --------------020209040209020001000205--
Responsible-Changed-From-To: freebsd-ports-bugs->lioux 
Responsible-Changed-By: lioux 
Responsible-Changed-When: Tue Jan 11 02:04:09 GMT 2005 
Responsible-Changed-Why:  
I'll handle this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76033 

From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: Florent Thoumie <flz@xbsd.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written in C++
Date: Tue, 11 Jan 2005 00:11:19 -0200

 --E13BgyNx05feLLmH
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 	I did a few changes to your port. I would like to know what
 do you think?  As always, this is your port. Everything is open to
 discussion until you're satisfied. :)
 
 	The explanation for the changes follow:
 
 	- Makefile
 		1) Remove '.if ${WITH_CLIENT:L} =3D=3D "yes"' like
 		constructs. That is appropriate for NetBSD. FreeBSD
 		does it differently, we check for both WITH_CLIENT
 		and WITHOUT_CLIENT. Code has been changed accordingly
 		2) fmt(1) REINPLACE_CMD line, added \ to make it
 		span through 2 lines instead of 1 (wrap around)
 		3) Add quotes around BROKEN text
 		4) Un"echo" post-install. It's better to do a silent
 		installation. It won't scare the most shy users :)
 		5) Advertise the existence of WITH_CLIENT option
 
 	- pkg-descr
 		* Add trailing / to WWW tag * Pass text through
 		fmt(1)
 
 	Let me know what do you think.
 
 	Regards,
 
 --=20
 Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
 feature, n: a documented bug | bug, n: an undocumented feature
 
 --E13BgyNx05feLLmH
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 Content-Transfer-Encoding: quoted-printable
 
 diff -ruN libtorrent.orig/Makefile libtorrent/Makefile
 --- libtorrent.orig/Makefile	Mon Jan 10 13:43:31 2005
 +++ libtorrent/Makefile	Mon Jan 10 14:36:09 2005
 @@ -21,22 +21,28 @@
  USE_LIBTOOL_VER=3D	15
  CONFIGURE_TARGET=3D	--build=3D${ARCH}-portbld-freebsd${OSREL}
 =20
 -WITH_CLIENT?=3D	no
 -
  .include <bsd.port.pre.mk>
 =20
  .if ${OSVERSION} < 500000
  USE_GCC=3D	3.4
  .endif
 =20
 +pre-everything::
 +.if !defined(WITH_CLIENT) && ${OSVERSION} >=3D 500000
 +	@${ECHO_MSG} '=3D=3D=3D>'
 +	@${ECHO_MSG} '=3D=3D=3D> Define WITH_CLIENT to build libtorrent client'
 +	@${ECHO_MSG} '=3D=3D=3D>'
 +.endif
 +
  post-patch:
  	@${REINPLACE_CMD} -e "s#\(pkgconfigdir =3D\).*#\1 ${PREFIX}/libexec/pkgco=
 nfig#" \
  			${WRKSRC}/Makefile.in
 -	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" ${WRKSRC}/c=
 lient/Makefile2
 +	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" \
 +			${WRKSRC}/client/Makefile2
 =20
 -.if ${WITH_CLIENT:L} =3D=3D "yes"
 +.if defined(WITH_CLIENT)
  .if ${OSVERSION} < 500000
 -BROKEN=3D		Client doesn't compile on 4.x.
 +BROKEN=3D		"Client doesn't compile on 4.x"
  .endif
 =20
  PLIST_FILES=3D	bin/rtorrent
 @@ -45,7 +51,7 @@
  	@(cd ${WRKSRC}/client; make -f Makefile2)
 =20
  post-install:
 -	${INSTALL_PROGRAM} ${WRKSRC}/client/rtorrent ${PREFIX}/bin
 +	@${INSTALL_PROGRAM} ${WRKSRC}/client/rtorrent ${PREFIX}/bin
  .endif
 =20
  .include <bsd.port.post.mk>
 diff -ruN libtorrent.orig/pkg-descr libtorrent/pkg-descr
 --- libtorrent.orig/pkg-descr	Mon Jan 10 13:43:31 2005
 +++ libtorrent/pkg-descr	Mon Jan 10 13:49:39 2005
 @@ -1,8 +1,8 @@
 -LibTorrent is a BitTorrent library written in C++ for *nix. It is designed=
  to
 -avoid redundant copying and storing of data that other clients and librari=
 es
 -suffer from. Licensed under the GPL.
 +LibTorrent is a BitTorrent library written in C++ for *nix. It is
 +designed to avoid redundant copying and storing of data that other
 +clients and libraries suffer from. Licensed under the GPL.
 =20
 -WWW: http://libtorrent.rakshasa.no
 +WWW: http://libtorrent.rakshasa.no/
 =20
  - Florent Thoumie
  flz@xbsd.org
 
 --E13BgyNx05feLLmH--

From: Florent Thoumie <flz@xbsd.org>
To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written
 in C++
Date: Tue, 11 Jan 2005 11:08:25 +0100

 Mario Sergio Fujikawa Ferreira wrote:
 
 > Hi,
 > 
 > 	I did a few changes to your port. I would like to know what
 > do you think?  As always, this is your port. Everything is open to
 > discussion until you're satisfied. :)
 > 
 > 	The explanation for the changes follow:
 > 
 > 	- Makefile
 > 		1) Remove '.if ${WITH_CLIENT:L} == "yes"' like
 > 		constructs. That is appropriate for NetBSD. FreeBSD
 > 		does it differently, we check for both WITH_CLIENT
 > 		and WITHOUT_CLIENT. Code has been changed accordingly
 > 		2) fmt(1) REINPLACE_CMD line, added \ to make it
 > 		span through 2 lines instead of 1 (wrap around)
 > 		3) Add quotes around BROKEN text
 > 		4) Un"echo" post-install. It's better to do a silent
 > 		installation. It won't scare the most shy users :)
 > 		5) Advertise the existence of WITH_CLIENT option
 > 
 > 	- pkg-descr
 > 		* Add trailing / to WWW tag * Pass text through
 > 		fmt(1)
 > 
 > 	Let me know what do you think.
 > 
 > 	Regards,
 
 	I've noted all the changes you made and I'm ok with them, except
 	for the first you mentioned. Actually I hate having WITH_* and
 	WITHOUT_* in the ports tree. This would be more consistent if
 	everyone used only WITH_*. That's how I wrote all knobs since
 	some months.
 
 	But I guess I'm dreaming so this change will be ok too ;)

From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: Florent Thoumie <flz@xbsd.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written in C++
Date: Wed, 12 Jan 2005 03:26:42 -0200

 --Lb0e7rgc7IsuDeGj
 Content-Type: multipart/mixed; boundary="cQXOx3fnlpmgJsTP"
 Content-Disposition: inline
 
 
 --cQXOx3fnlpmgJsTP
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 	Sorry for the awful delay. Very busy past few days.
 I have just one more change to your port before committing it.
 
 	The port was not C{,XX}FLAGS safe, it was using '-O3'
 instead of respecting the ports system and defaulting to whatever
 the user has decided to use in his /etc/make.conf.  Not to mention
 respecting CPUTYPE.
 
 	It's just a 3 liner change to the port Makefile.
 
 	Let me know how do you want to handle it.
 
 	Regards,
 
 --=20
 Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
 feature, n: a documented bug | bug, n: an undocumented feature
 
 --cQXOx3fnlpmgJsTP
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 Content-Transfer-Encoding: quoted-printable
 
 --- Makefile.orig	Wed Jan 12 03:08:55 2005
 +++ Makefile	Wed Jan 12 03:22:36 2005
 @@ -39,6 +39,11 @@
  			${WRKSRC}/Makefile.in
  	@${REINPLACE_CMD} -e "s#-Wall -O3 -g#${CFLAGS} -fpermissive#" \
  			${WRKSRC}/client/Makefile2
 +# uphold CXXFLAGS
 +	@${REINPLACE_CMD} -E \
 +			-e 's#^(CXXFLAGS[[:space:]]*=3D[[:space:]]*).*-O.*$$#\1${CXXFLAGS}#' \
 +			-e 's#^(CFLAGS[[:space:]]*=3D[[:space:]]*).*-O.*$$#\1${CFLAGS}#' \
 +			${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
 =20
  .if defined(WITH_CLIENT)
  .if ${OSVERSION} < 500000
 
 --cQXOx3fnlpmgJsTP--
 
 --Lb0e7rgc7IsuDeGj
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 
 iD8DBQFB5LUorxEiaFLzGQwRAsisAJ49yqEe8EeK6+gQkqkf2h5Wi7JWeQCggOGE
 K3OlSSMOCoS/RWdG6HNSWPY=
 =IqA/
 -----END PGP SIGNATURE-----
 
 --Lb0e7rgc7IsuDeGj--

From: Florent Thoumie <flz@xbsd.org>
To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>,
	freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/76033: New port: net/libtorrent - BitTorrent Library written
 in C++
Date: Wed, 12 Jan 2005 07:27:45 +0100

 Mario Sergio Fujikawa Ferreira wrote:
 
 > Hi,
 > 
 > 	Sorry for the awful delay. Very busy past few days.
 > I have just one more change to your port before committing it.
 > 
 > 	The port was not C{,XX}FLAGS safe, it was using '-O3'
 > instead of respecting the ports system and defaulting to whatever
 > the user has decided to use in his /etc/make.conf.  Not to mention
 > respecting CPUTYPE.
 > 
 > 	It's just a 3 liner change to the port Makefile.
 > 
 > 	Let me know how do you want to handle it.
 
 	Still ok obviously. It looks like I overlooked the port.
 
 	Sorry for the unneeded work on this port, should have done it
 	myself.
 
 	Best regards.
State-Changed-From-To: open->closed 
State-Changed-By: lioux 
State-Changed-When: Wed Jan 12 10:20:31 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=76033 
>Unformatted:
