From nobody@FreeBSD.org  Tue Dec 28 11:01:40 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EC7DB16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Dec 2004 11:01:40 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B589E43D45
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Dec 2004 11:01:40 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBSB1eRJ057763
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 28 Dec 2004 11:01:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iBSB1e31057761;
	Tue, 28 Dec 2004 11:01:40 GMT
	(envelope-from nobody)
Message-Id: <200412281101.iBSB1e31057761@www.freebsd.org>
Date: Tue, 28 Dec 2004 11:01:40 GMT
From: Kensaku MASUDA <greg@greg.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Automatic dependency was broken for security/gnutls
X-Send-Pr-Version: www-2.3

>Number:         75567
>Category:       ports
>Synopsis:       Automatic dependency was broken for security/gnutls
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    sergei
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 28 11:10:22 GMT 2004
>Closed-Date:    Mon Feb 28 12:16:02 GMT 2005
>Last-Modified:  Mon Feb 28 12:16:02 GMT 2005
>Originator:     Kensaku MASUDA
>Release:        5.3-STABLE
>Organization:
>Environment:
FreeBSD omoikane.greg.jp 5.3-STABLE FreeBSD 5.3-STABLE #0: Wed Dec 22 15:23:25 JST 2004     root@omoikane.greg.jp:/a/uzume.greg.rim.or.jp/export/src/system-5-stable/src/sys/i386/compile/omoikane.greg.jp  i386

>Description:
      gnutls depends by opencdk and tasn1 libraries, if installed. Configure script can found it, But packaging system was not.
>How-To-Repeat:
1. Install opencdk and tasn1 library
2. Build security/gnutls
3. Install security/gnutls
4. Look dependency for gnutls. Builded binary was depends by it libraries, But gnutls-1.0.21/+CONTENTS was no lines for opencdk and tasn1.
>Fix:
--- Makefile.old        Wed Oct 13 18:08:06 2004
+++ Makefile    Tue Dec 28 11:07:29 2004
@@ -20,14 +20,6 @@
 LIB_DEPENDS=   gcrypt.12:${PORTSDIR}/security/libgcrypt \
                gpg-error.1:${PORTSDIR}/security/libgpg-error
 
-.if defined(WITH_OPENCDK) || exists(${LOCALBASE}/lib/libopencdk.so.8)
-LIB_DEPENDS+=  opencdk.8:${PORTSDIR}/security/opencdk
-.endif
-
-.if defined(WITH_LIBTASN1) || exists(${LOCALBASE}/lib/libtasn1.so.2)
-LIB_DEPENDS+=  tasn1.2:${PORTSDIR}/security/libtasn1
-.endif
-
 CONFLICTS=     gnutls-devel-[0-9]*
 
 USE_GPG?=      yes
@@ -47,6 +39,24 @@
 DOCS=          AUTHORS NEWS README THANKS doc/tex/*.ps
 EXAMPLES=      doc/examples/*.c
 
+.include <bsd.port.pre.mk>
+
+.if exists(${LOCALBASE}/lib/libopencdk.so) && !defined(WITHOUT_OPENCDK)
+WITH_OPENCDK=  yes
+.endif
+
+.if exists(${LOCALBASE}/lib/libtasn1.so) && !defined(WITHOUT_LIBTASN1)
+WITH_LIBTASN1= yes
+.endif
+
+.if defined(WITH_OPENCDK)
+LIB_DEPENDS+=  opencdk.8:${PORTSDIR}/security/opencdk
+.endif
+
+.if defined(WITH_LIBTASN1)
+LIB_DEPENDS+=  tasn1.2:${PORTSDIR}/security/libtasn1
+.endif
+
 post-install:
        @${MKDIR} ${EXAMPLESDIR}
        cd ${WRKSRC} && ${INSTALL_DATA} ${EXAMPLES} ${EXAMPLESDIR}
@@ -55,4 +65,4 @@
        cd ${WRKSRC} && ${INSTALL_DATA} ${DOCS} ${DOCSDIR}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sergei 
Responsible-Changed-By: krion 
Responsible-Changed-When: Tue Dec 28 22:03:10 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75567 

From: Sergei Kolobov <sergei@FreeBSD.org>
To: Kensaku MASUDA <greg@greg.jp>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/75567: Automatic dependency was broken for security/gnutls
Date: Mon, 7 Feb 2005 15:14:16 +0300

 On 2004-12-28 at 11:01 +0000, Kensaku MASUDA wrote:
 > >Description:
 >       gnutls depends by opencdk and tasn1 libraries, if installed. Configure
 >       script can found it, But packaging system was not.
 > >How-To-Repeat:
 > 1. Install opencdk and tasn1 library
 > 2. Build security/gnutls
 > 3. Install security/gnutls
 > 4. Look dependency for gnutls. Builded binary was depends by it libraries,
 > But gnutls-1.0.21/+CONTENTS was no lines for opencdk and tasn1.
 
 I cannot replicate the problem on my systems.
 
 Here is a excerpt from the build logs (produced by "port test" - part of 
 porttools):
 
 [...]
 ===>  Building package for gnutls-1.0.24
 Creating package /FreeBSD/packages/All/gnutls-1.0.24.tbz
 Registering depends: gettext-0.14.1 libgcrypt-1.2.1 libgpg-error-1.0_1 libiconv-1.9.2_1 libtasn1-0.2.10 opencdk-0.5.5_1,1 perl-5.8.6_2.
 Registering conflicts: gnutls-devel-[0-9]*.
 Creating bzip'd tar ball in '/FreeBSD/packages/All/gnutls-1.0.24.tbz'
 ===> Checking pkg_info
 gnutls-1.0.24       GNU Transport Layer Security library
 ===> Checking shared library dependencies
 /lib/libc.so.5
 /lib/libz.so.2
 /pkg/lib/libgcrypt.so.13
 /pkg/lib/libgpg-error.so.1
 /pkg/lib/libiconv.so.3
 /pkg/lib/libintl.so.6
 /pkg/lib/libopencdk.so.8
 /pkg/lib/libtasn1.so.2
 /var/build/gnutls-1.0.24/lib/libgnutls-extra.so.12
 /var/build/gnutls-1.0.24/lib/libgnutls.so.12
 [...]
 
 As you see, it correctly registers both shared library dependencies
 and package dependcies to external libtasn1 and opencdk ports.
 
 Please retest with the latest version of all related ports 
 and let us know if the problem still persists.
 
 Sergei
State-Changed-From-To: open->feedback 
State-Changed-By: sergei 
State-Changed-When: Mon Feb 7 13:09:21 GMT 2005 
State-Changed-Why:  
Asked if the submitter still experiences the problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75567 
State-Changed-From-To: feedback->closed 
State-Changed-By: sergei 
State-Changed-When: Mon Feb 28 12:13:57 GMT 2005 
State-Changed-Why:  
Feedback timeout. 

This problem does not seem to exist in the current port versions 
(at least in my testing).  

Please resubmit as a new PR if you think the problem persists. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75567 
>Unformatted:
