From nobody@FreeBSD.org  Sun Dec 26 04:53:52 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C8B0116A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Dec 2004 04:53:52 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B32CA43D45
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Dec 2004 04:53:52 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBQ4rqOm003526
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Dec 2004 04:53:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iBQ4rqIn003525;
	Sun, 26 Dec 2004 04:53:52 GMT
	(envelope-from nobody)
Message-Id: <200412260453.iBQ4rqIn003525@www.freebsd.org>
Date: Sun, 26 Dec 2004 04:53:52 GMT
From: "Pedro F. Giffuni" <giffunip@asme.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Minor enhancement to the cad/ngspice port
X-Send-Pr-Version: www-2.3

>Number:         75504
>Category:       ports
>Synopsis:       Minor enhancement to the cad/ngspice port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 26 05:00:50 GMT 2004
>Closed-Date:    Fri Dec 31 11:22:37 GMT 2004
>Last-Modified:  Fri Dec 31 11:22:37 GMT 2004
>Originator:     Pedro F. Giffuni
>Release:        5.2.1 Release
>Organization:
>Environment:
>Description:
ngspice is being built without readline support to avoid possible licensing issues: ngspice license is GPL-incompatible. The GPL only applies to distribution though, so I suggest to enable it when we are not PACKAGE_BUILDING. Also, when we are package building we shouldn't build-in debugging support.
>How-To-Repeat:
My enhancements are pretty minimalistic. JFYI, the ngspice team also added xspice and cider but they consider it experimental so they don't build it. They don't build X support either. 
>Fix:
diff -ruN ngspice_rework.orig/Makefile ngspice_rework/Makefile
--- ngspice_rework.orig/Makefile	Thu Dec 23 22:50:53 2004
+++ ngspice_rework/Makefile	Sat Dec 25 19:56:49 2004
@@ -21,6 +21,12 @@
 USE_LIBTOOL_VER?=15
 USE_GMAKE=	yes
 
+.ifndef PACKAGE_BUILDING
+CONFIGURE_ARGS += --with-readline=yes
+.else
+CONFIGURE_ARGS += --disable-debug 
+.endif
+
 INFO=		ngspice
 MAN1=		ngspice.1 ngnutmeg.1 ngsconvert.1
 

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Tue Dec 28 03:36:40 GMT 2004 
State-Changed-Why:  
Asked maintainer for review. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Tue Dec 28 03:36:40 GMT 2004 
Responsible-Changed-Why:  
Handle. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75504 

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, amakawa@jp.FreeBSD.org
Cc:  
Subject: Re: ports/75504: Minor enhancement to the cad/ngspice port
Date: Tue, 28 Dec 2004 04:36:35 +0100

 Dear maintainer of FreeBSD port cad/ngspice_rework, please review a
 patch at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=75504
 
 Do you approve or reject this change?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 A spoonful of curry, garlic and mustard helps the medicine go down...
 and come straight back up again.
   -- JLE on #angband

From: "Pedro F. Giffuni" <giffunip@yahoo.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/75504: Minor enhancement to the cad/ngspice port
Date: Tue, 28 Dec 2004 12:05:57 -0800 (PST)

 --0-463665273-1104264357=:39512
 Content-Type: text/plain; charset=us-ascii
 Content-Id: 
 Content-Disposition: inline
 
 Hi;
 The patch is trivial (and smaller than what I suggested to the maintainer), but
 according to portlint I added a space at the end of a line. Just letting you
 know so that this doesn't go in unnoticed :).
 
 
 		
 __________________________________ 
 Do you Yahoo!? 
 Send holiday email and support a worthy cause. Do good. 
 http://celebrity.mail.yahoo.com
 --0-463665273-1104264357=:39512
 Content-Type: application/octet-stream; name=patch-ngspice
 Content-Transfer-Encoding: base64
 Content-Description: patch-ngspice
 Content-Disposition: attachment; filename=patch-ngspice
 
 ZGlmZiAtcnVOIG5nc3BpY2VfcmV3b3JrLm9yaWcvTWFrZWZpbGUgbmdzcGlj
 ZV9yZXdvcmsvTWFrZWZpbGUKLS0tIG5nc3BpY2VfcmV3b3JrLm9yaWcvTWFr
 ZWZpbGUJVGh1IERlYyAyMyAyMjo1MDo1MyAyMDA0CisrKyBuZ3NwaWNlX3Jl
 d29yay9NYWtlZmlsZQlTYXQgRGVjIDI1IDE5OjU2OjQ5IDIwMDQKQEAgLTIx
 LDYgKzIxLDEyIEBACiBVU0VfTElCVE9PTF9WRVI/PTE1CiBVU0VfR01BS0U9
 CXllcwogCisuaWZuZGVmIFBBQ0tBR0VfQlVJTERJTkcKK0NPTkZJR1VSRV9B
 UkdTICs9IC0td2l0aC1yZWFkbGluZT15ZXMKKy5lbHNlCitDT05GSUdVUkVf
 QVJHUyArPSAtLWRpc2FibGUtZGVidWcgCisuZW5kaWYKKwogSU5GTz0JCW5n
 c3BpY2UKIE1BTjE9CQluZ3NwaWNlLjEgbmdudXRtZWcuMSBuZ3Njb252ZXJ0
 LjEKIAo=
 
 --0-463665273-1104264357=:39512--

From: AMAKAWA Shuhei <sa264@cam.ac.uk>
To: pav@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org, amakawa@jp.FreeBSD.org,
	giffunip@yahoo.com
Subject: Re: ports/75504: Minor enhancement to the cad/ngspice port
Date: Thu, 30 Dec 2004 05:39:29 +0000

 At Tue, 28 Dec 2004 04:36:35 +0100,
 Pav Lucistnik wrote:
 > 
 > Dear maintainer of FreeBSD port cad/ngspice_rework, please review a
 > patch at
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?q=75504
 > 
 > Do you approve or reject this change?
 
 Pav
 
 I'll have a look.
 Thank you.
 
 shuhei

From: AMAKAWA Shuhei <amakawa@jp.FreeBSD.org>
To: pav@FreeBSD.org
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/75504: Minor enhancement to the cad/ngspice port
Date: Fri, 31 Dec 2004 03:43:57 +0000

 At Tue, 28 Dec 2004 04:36:35 +0100,
 Pav Lucistnik wrote:
 > 
 > Dear maintainer of FreeBSD port cad/ngspice_rework, please review a
 > patch at
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?q=75504
 > 
 > Do you approve or reject this change?
 
 yes.
 Looks ok to me.
 
 shuhei
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Fri Dec 31 11:22:30 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75504 
>Unformatted:
