From fernan@pi.iib.unsam.edu.ar  Thu Dec  9 19:17:23 2004
Return-Path: <fernan@pi.iib.unsam.edu.ar>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8D32A16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  9 Dec 2004 19:17:23 +0000 (GMT)
Received: from smtp.unsam.edu.ar (smtp.unsam.edu.ar [170.210.48.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CB5C143D49
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  9 Dec 2004 19:17:19 +0000 (GMT)
	(envelope-from fernan@pi.iib.unsam.edu.ar)
Received: from pi.iib.unsam.edu.ar (pi.iib.unsam.edu.ar [192.168.10.11])
	by smtp.unsam.edu.ar (8.12.6/8.12.6) with ESMTP id iB9JSi6X066422
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 9 Dec 2004 16:28:45 -0300 (ART)
	(envelope-from fernan@pi.iib.unsam.edu.ar)
Received: from pi.iib.unsam.edu.ar (localhost.iib.unsam.edu.ar [127.0.0.1])
	by pi.iib.unsam.edu.ar (8.12.11/8.12.9) with ESMTP id iB9JH6Ic064932
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 9 Dec 2004 16:17:06 -0300 (ART)
	(envelope-from fernan@pi.iib.unsam.edu.ar)
Received: (from fernan@localhost)
	by pi.iib.unsam.edu.ar (8.12.11/8.12.11/Submit) id iB9JH63K064929;
	Thu, 9 Dec 2004 16:17:06 -0300 (ART)
	(envelope-from fernan)
Message-Id: <200412091917.iB9JH63K064929@pi.iib.unsam.edu.ar>
Date: Thu, 9 Dec 2004 16:17:06 -0300 (ART)
From: Fernan Aguero <fernan@iib.unsam.edu.ar>
Reply-To: Fernan Aguero <fernan@iib.unsam.edu.ar>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer update] unbreak, set all distfiles on by default 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         74896
>Category:       ports
>Synopsis:       [maintainer update] biology/embassy: unbreak, set all distfiles on by default
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 09 19:20:19 GMT 2004
>Closed-Date:    Sat Dec 11 23:33:03 GMT 2004
>Last-Modified:  Sat Dec 11 23:33:03 GMT 2004
>Originator:     Fernan Aguero
>Release:        FreeBSD 4.10-RELEASE i386
>Organization:
IIB-UNSAM
>Environment:

FreeBSD pi.iib.unsam.edu.ar 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Wed May 26 12:56:43 ART 2004 fernan@pi.iib.unsam.edu.ar:/usr/obj/usr/src/sys/PI  i386

	
>Description:
	
	
	When the build is run without first specifying options (i.e.
	without first running 'make config'), and in a non-interactive
	mode (BATCH=yes), then DISTFILES is empty.
	
>How-To-Repeat:
	
	
>Fix:

	
	
	Set all WITH_* variables by default. This makes for a fully
	populated DISTFILES list.

	While here, add a modeline for vi.


--- embassy.diff begins here ---
diff -ruN /usr/ports/biology/embassy/Makefile embassy/Makefile
--- /usr/ports/biology/embassy/Makefile	Mon Dec  6 06:00:20 2004
+++ embassy/Makefile	Mon Dec  6 13:40:20 2004
@@ -1,3 +1,4 @@
+# ex:ts=8
 # New ports collection makefile for:	embassy
 # Date created:		1.November.2004
 # Whom:	      		Fernan Aguero <fernan@iib.unsamn.edu.ar>
@@ -19,13 +20,20 @@
 BUILD_DEPENDS=	${LOCALBASE}/include/emboss.h:${PORTSDIR}/biology/emboss
 LIB_DEPENDS=	nucleus.1:${PORTSDIR}/biology/emboss:install
 
-BROKEN=		Broken distinfo file
-
 USE_SUBMAKE=	yes
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 USE_XLIB=	yes
 USE_MOTIF=	yes
+
+WITH_DOMAINATRIX=	yes
+WITH_EMNU=	 	yes
+WITH_ESIM4=	 	yes
+WITH_HMMER=	 	yes
+WITH_MEME=	 	yes
+WITH_MSE=	 	yes
+WITH_PHYLIP=	 	yes
+WITH_TOPO=	 	yes
 
 OPTIONS=	DOMAINATRIX	"Protein structure and domain apps" on \
 		EMNU		"EMBOSS simple menu" on \
--- embassy.diff ends here ---

>Release-Note:
>Audit-Trail:

From: Sergey Matveychuk <sem@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, fernan@iib.unsam.edu.ar
Cc:  
Subject: Re: ports/74896: [maintainer update] biology/embassy: unbreak, set
 all distfiles on by default
Date: Sat, 11 Dec 2004 06:27:14 +0300

 It's a wrong way.
 OPTIONS is useless in this case.
 
 -- 
 Sem.
 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sat Dec 11 23:32:43 GMT 2004 
State-Changed-Why:  
This patch is completely bogus. I committed a proper fix, see rev. 1.3 
of Makefile. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74896 
>Unformatted:
