From nobody@FreeBSD.org  Sun Nov 21 16:48:08 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ED7CE16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Nov 2004 16:48:08 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DC44643D4C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Nov 2004 16:48:08 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iALGm8xT079850
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 21 Nov 2004 16:48:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id iALGm8Oo079849;
	Sun, 21 Nov 2004 16:48:08 GMT
	(envelope-from nobody)
Message-Id: <200411211648.iALGm8Oo079849@www.freebsd.org>
Date: Sun, 21 Nov 2004 16:48:08 GMT
From: Michael Hambly <mike@blackbirdsoftware.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Patch for Connection.cc in the mysqlcppapi port needs to check for higher versions of MySQL.
X-Send-Pr-Version: www-2.3

>Number:         74205
>Category:       ports
>Synopsis:       Patch for Connection.cc in the mysqlcppapi port needs to check for higher versions of MySQL.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 21 16:50:24 GMT 2004
>Closed-Date:    Sun Jan 30 00:10:04 GMT 2005
>Last-Modified:  Sun Jan 30 00:10:04 GMT 2005
>Originator:     Michael Hambly
>Release:        5.3
>Organization:
Blackbird Software Design Ltd.
>Environment:
5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov  5 04:19:18 UTC 2004     root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The mysqlcppapi port fails to compile against MySQL version 4.1.5
because the mysql_shutdown function parameters changed in version
4.1.3.

The patch for this already exists as /usr/ports/databases/mysqlcppapi/files/patch-mysqlcppapi-Connection.cc.

Problem - the patch checks for specific versions of MySQL as follows:
+#if  ( MYSQL_VERSION_ID == 40103 ) || ( MYSQL_VERSION_ID == 50001 )

This check does not catch higher versions of MySQL which also contain the altered mysql_shutdown function.

>How-To-Repeat:
cd /usr/ports/databases/mysql41-server
make install clean
cd /usr/ports/databases/mysqlcpapi
make install clean

>Fix:
The patch should check for higher version increments of MySQL as follows:
+#if  ( MYSQL_VERSION_ID >= 40103 && MYSQL_VERSION_ID < 50000 ) || ( MYSQL_VERSION_ID >= 50001 )

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Mon Nov 22 10:39:31 GMT 2004 
Responsible-Changed-Why:  
Ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74205 
State-Changed-From-To: open->feedback 
State-Changed-By: sem 
State-Changed-When: Sat Nov 27 22:18:39 GMT 2004 
State-Changed-Why:  
Ask maintainer for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74205 

From: Sergey Matveychuk <sem@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, gaoj@cpsc.ucalgary.ca
Cc:  
Subject: Re: ports/74205: Patch for Connection.cc in the mysqlcppapi port
 needs to check for higher versions of MySQL.
Date: Sun, 28 Nov 2004 01:17:27 +0300

 Dear maintainer!
 
 Take the PR in account please.
 
 -- 
 Sem.
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Jan 30 00:09:06 GMT 2005 
State-Changed-Why:  
Maintainer says that this should be fixed by the commit that was 
done using ports/71348. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=74205 
>Unformatted:
