From alfred@FreeBSD.org  Wed Nov 10 03:54:47 2004
Return-Path: <alfred@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E6DA716A4D0
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 03:54:47 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA11E43D39
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 03:54:47 +0000 (GMT)
	(envelope-from alfred@FreeBSD.org)
Received: from freefall.freebsd.org (alfred@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iAA3slS5062916
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Nov 2004 03:54:47 GMT
	(envelope-from alfred@freefall.freebsd.org)
Received: (from alfred@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iAA3slqG062915;
	Wed, 10 Nov 2004 03:54:47 GMT
	(envelope-from alfred)
Message-Id: <200411100354.iAA3slqG062915@freefall.freebsd.org>
Date: Wed, 10 Nov 2004 03:54:47 GMT
From: Alfred Perlstein <alfred@FreeBSD.org>
Reply-To: Alfred Perlstein <alfred@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: logjam port does not link
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         73758
>Category:       ports
>Synopsis:       logjam port does not link
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    novel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 10 04:00:50 GMT 2004
>Closed-Date:    Mon May 09 16:47:58 GMT 2005
>Last-Modified:  Mon May 09 16:47:58 GMT 2005
>Originator:     Alfred Perlstein
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
RED Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 4.10-STABLE FreeBSD 4.10-STABLE #13: Fri May 28 21:29:54 PDT 2004 kensmith@freefall.freebsd.org:/c/src/sys/compile/FREEFALL i386


	
>Description:

under 6.x logjam fails to compile, the attached diff fixes it, but may
not work on 4.x
>How-To-Repeat:
>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile	7 Nov 2004 22:36:10 -0000	1.12
+++ Makefile	10 Nov 2004 02:27:52 -0000
@@ -32,7 +32,7 @@
 USE_GNOME=	gnomehack gnomeprefix gtk20 libxml2 intlhack
 CONFIGURE_ARGS=	--program-transform-name="s/$$//"
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
-		LIBS="-L${LOCALBASE}/lib"
+		LIBS="-L${LOCALBASE}/lib -lpthread"
 
 .ifndef(WITHOUT_GTKSPELL)
 LIB_DEPENDS+=		gtkspell.0:${PORTSDIR}/textproc/gtkspell2
>Release-Note:
>Audit-Trail:

From: Miguel Mendez <flynn@energyhq.es.eu.org>
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/73758: logjam port does not link
Date: Wed, 10 Nov 2004 16:03:30 +0100

 --Signature=_Wed__10_Nov_2004_16_03_30_+0100_6=4mtCvqfdBuD5TM
 Content-Type: text/plain; charset=US-ASCII
 Content-Disposition: inline
 Content-Transfer-Encoding: 7bit
 
 On Wed, 10 Nov 2004 03:54:47 GMT
 Alfred Perlstein <alfred@FreeBSD.org> wrote:
 
 Hi,
 
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v
 > retrieving revision 1.12
 > diff -u -r1.12 Makefile
 > --- Makefile	7 Nov 2004 22:36:10 -0000	1.12
 > +++ Makefile	10 Nov 2004 02:27:52 -0000
 > @@ -32,7 +32,7 @@
 >  USE_GNOME=	gnomehack gnomeprefix gtk20 libxml2 intlhack
 >  CONFIGURE_ARGS=	--program-transform-name="s/$$//"
 >  CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
 > -		LIBS="-L${LOCALBASE}/lib"
 > +		LIBS="-L${LOCALBASE}/lib -lpthread"
 >  
 
 Wouldn't it be preferable to use ${PTHREAD_LIBS} instead of hardcoding
 -lpthread?
 
 Cheers,
 -- 
 	Miguel Mendez <flynn@energyhq.es.eu.org> | Extreme ways are back again
 	http://www.energyhq.es.eu.org            | Extreme places I didn't know
 	PGP Key: 0xDC8514F1                      | I broke everything new again
 	Note: All HTML mail goes to /dev/null    | Everything that I'd owned
 
 
 --Signature=_Wed__10_Nov_2004_16_03_30_+0100_6=4mtCvqfdBuD5TM
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQFBki3GnLctrNyFFPERAvEhAKCI6hNpHxNswEZfCUQGmwwQsCEQRQCgqQia
 bEY6x54gK3+funWmMYhkLOM=
 =CrWq
 -----END PGP SIGNATURE-----
 
 --Signature=_Wed__10_Nov_2004_16_03_30_+0100_6=4mtCvqfdBuD5TM--

From: Alfred Perlstein <alfred@freebsd.org>
To: Miguel Mendez <flynn@energyhq.es.eu.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/73758: logjam port does not link
Date: Wed, 10 Nov 2004 11:23:36 -0800

 * Miguel Mendez <flynn@energyhq.es.eu.org> [041110 07:03] wrote:
 > On Wed, 10 Nov 2004 03:54:47 GMT
 > Alfred Perlstein <alfred@FreeBSD.org> wrote:
 > 
 > Hi,
 > 
 > > Index: Makefile
 > > ===================================================================
 > > RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v
 > > retrieving revision 1.12
 > > diff -u -r1.12 Makefile
 > > --- Makefile	7 Nov 2004 22:36:10 -0000	1.12
 > > +++ Makefile	10 Nov 2004 02:27:52 -0000
 > > @@ -32,7 +32,7 @@
 > >  USE_GNOME=	gnomehack gnomeprefix gtk20 libxml2 intlhack
 > >  CONFIGURE_ARGS=	--program-transform-name="s/$$//"
 > >  CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
 > > -		LIBS="-L${LOCALBASE}/lib"
 > > +		LIBS="-L${LOCALBASE}/lib -lpthread"
 > >  
 > 
 > Wouldn't it be preferable to use ${PTHREAD_LIBS} instead of hardcoding
 > -lpthread?
 
 I dunno, I'm not so great with ports. ;)
 
 -- 
 - Alfred Perlstein

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, alfred@FreeBSD.org
Cc:  
Subject: Re: ports/73758: logjam port does not link
Date: Thu, 11 Nov 2004 14:01:02 +0100

 --=-o5HG7qaxXhS4OhIdMZ0n
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 How current is your -CURRENT? I just built logjam port on 4-STABLE and
 5-STABLE and at neither environment it needed threading at all. This
 application just don't have any use of threading.
 
 Just an idea - what's content of your /var/db/ports/libxml2/options
 file? Especially WITHOUT_THREADS knob, true or false?
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 A two-eyed cyclops would be a bicyclops.
 
 --=-o5HG7qaxXhS4OhIdMZ0n
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
 	=?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?=
 	=?ISO-8859-1?Q?_zpr=E1vy?=
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQBBk2KOntdYP8FOsoIRAqrVAJwNaDqG5u/ZVIaDy28PPVdvfS4DCACfYTkW
 57K2i3KR1h/0ZaJEzFhN3bc=
 =TR2H
 -----END PGP SIGNATURE-----
 
 --=-o5HG7qaxXhS4OhIdMZ0n--

From: Alfred Perlstein <alfred@freebsd.org>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/73758: logjam port does not link
Date: Thu, 11 Nov 2004 09:44:58 -0800

 * Pav Lucistnik <pav@FreeBSD.org> [041111 05:02] wrote:
 > How current is your -CURRENT? I just built logjam port on 4-STABLE and
 > 5-STABLE and at neither environment it needed threading at all. This
 > application just don't have any use of threading.
 > 
 > Just an idea - what's content of your /var/db/ports/libxml2/options
 > file? Especially WITHOUT_THREADS knob, true or false?
 
 ~ % less /var/db/ports/libxml2/options
 /var/db/ports/libxml2/options: No such file or directory
 
 My /var/db/ports is empty.
 
 FreeBSD big.endian.org 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Sat Oct 30 19:02:30 PDT 2004     root@big.endian.org:/vol/share/obj/vol/share/src/sys/smpng  i386
 
 
 -- 
 - Alfred Perlstein
 - Research Engineering Development Inc.
 - email: bright@mu.org cell: 408-480-4684

From: Pav Lucistnik <pav@FreeBSD.org>
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/73758: logjam port does not link
Date: Thu, 11 Nov 2004 18:48:04 +0100

 --=-2hJmj023sCYzdx2a+k7F
 Content-Type: text/plain; charset=ISO8859-2
 Content-Transfer-Encoding: quoted-printable
 
 Alfred Perlstein p=ED=B9e v =E8t 11. 11. 2004 v 09:44 -0800:
 > * Pav Lucistnik <pav@FreeBSD.org> [041111 05:02] wrote:
 > > How current is your -CURRENT? I just built logjam port on 4-STABLE and
 > > 5-STABLE and at neither environment it needed threading at all. This
 > > application just don't have any use of threading.
 > >=20
 > > Just an idea - what's content of your /var/db/ports/libxml2/options
 > > file? Especially WITHOUT_THREADS knob, true or false?
 >=20
 > ~ % less /var/db/ports/libxml2/options
 > /var/db/ports/libxml2/options: No such file or directory
 >=20
 > My /var/db/ports is empty.
 
 And any chance you defined WITH_THREADS somewhere? make.conf or
 environment or something?
 
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Mischief managed.
 
 --=-2hJmj023sCYzdx2a+k7F
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
 	=?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?=
 	=?ISO-8859-1?Q?_zpr=E1vy?=
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQBBk6XUntdYP8FOsoIRAqyeAJ9Q/TovdocvJXnpYwyUsQuCB7N2VQCgsgqO
 2WWdQed89rd44LWx14jYZz0=
 =gGgt
 -----END PGP SIGNATURE-----
 
 --=-2hJmj023sCYzdx2a+k7F--

From: Alfred Perlstein <alfred@freebsd.org>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/73758: logjam port does not link
Date: Thu, 11 Nov 2004 13:00:44 -0800

 * Pav Lucistnik <pav@FreeBSD.org> [041111 09:48] wrote:
 > Alfred Perlstein p??e v ?t 11. 11. 2004 v 09:44 -0800:
 > > 
 > > ~ % less /var/db/ports/libxml2/options
 > > /var/db/ports/libxml2/options: No such file or directory
 > > 
 > > My /var/db/ports is empty.
 > 
 > And any chance you defined WITH_THREADS somewhere? make.conf or
 > environment or something?
 
 not afaik...
 
 -- 
 - Alfred Perlstein
 - Research Engineering Development Inc.
 - email: bright@mu.org cell: 408-480-4684

From: Roman Bogorodskiy <novel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, alfred@FreeBSD.org
Cc:  
Subject: Re: ports/73758: logjam port does not link
Date: Fri, 11 Mar 2005 15:44:19 +0000

 Is that PR still actual?
 
 -Roman Bogorodskiy
State-Changed-From-To: open->closed 
State-Changed-By: novel 
State-Changed-When: Mon Mar 14 14:12:22 GMT 2005 
State-Changed-Why:  
Doesn't seem to be actual anmore. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73758 
State-Changed-From-To: closed->open 
State-Changed-By: alfred 
State-Changed-When: Sun Mar 27 12:12:06 GMT 2005 
State-Changed-Why:  
This is still broken for me: 

cc -DLOCALEDIR="/usr/X11R6/share/locale" -DPIXMAPDIR="/usr/X11R6/share/gnome/ 
pixmaps" -I/usr/X11R6/include -I/usr/X11R6/include/xmms -I/usr/X11R6/include/gt 
k12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -O2 -f 
no-strict-aliasing -pipe -o logjam-xmms-client logjam-xmms-client.o -Wl,-E  -L/u 
sr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -lgmodule12 -lglib12 -lintl -lXi - 
lXext -lX11 -lm -lxmms 
/usr/local/lib/libgthread12.so.3: undefined reference to `pthread_cond_timedwait 
' 
collect2: ld returned 1 exit status 
gmake[3]: *** [logjam-xmms-client] Error 1 
gmake[3]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 
/util/xmmsclient' 
gmake[2]: *** [all-recursive] Error 1 
gmake[2]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 
/util' 
gmake[1]: *** [all-recursive] Error 1 
gmake[1]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 
' 
gmake: *** [all] Error 2 
*** Error code 2 

Stop in /vol/share/ports/deskutils/logjam. 
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade13601.8 mak 
e 
** Fix the problem and try again. 

This seems to fix it: 


Index: Makefile 
=================================================================== 
RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v 
retrieving revision 1.14 
diff -u -r1.14 Makefile 
--- Makefile	12 Mar 2005 10:52:35 -0000	1.14 
+++ Makefile	27 Mar 2005 12:07:01 -0000 
@@ -33,7 +33,7 @@ 
USE_GNOME=	gnomehack gnomeprefix gtk20 libxml2 intlhack 
CONFIGURE_ARGS=	--program-transform-name="s/$$//" 
CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include"  
-		LIBS="-L${LOCALBASE}/lib" 
+		LIBS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}" 

.ifndef(WITHOUT_GTKSPELL) 
LIB_DEPENDS+=		gtkspell.0:${PORTSDIR}/textproc/gtkspell2 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73758 

From: Sam Lawrance <lawrance@FreeBSD.org>
To: alfred@FreeBSD.org, bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/73758: logjam port does not link
Date: Mon, 18 Apr 2005 20:21:16 +1000

 The port's configure script should get '-pthread' as a link argument
 from pkg-config:
 
 sam@dirk sam> pkg-config --libs gthread-2.0
 -pthread -L/usr/local/lib -lgthread-2.0 -lglib-2.0 -liconv
 
 That is sourced from /usr/local/libdata/pkgconfig/gthread-2.0.pc.  What
 does that command show for you, Alfred?
 
 Could you try force upgrading glib-2.0 to see if that helps?
 
 
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->novel 
Responsible-Changed-By: novel 
Responsible-Changed-When: Fri Apr 22 18:52:32 GMT 2005 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73758 
State-Changed-From-To: open->feedback 
State-Changed-By: novel 
State-Changed-When: Fri Apr 22 19:01:10 GMT 2005 
State-Changed-Why:  
Are you building it with WITH_XMMS defined? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73758 
State-Changed-From-To: feedback->closed 
State-Changed-By: novel 
State-Changed-When: Mon May 9 16:46:51 GMT 2005 
State-Changed-Why:  
I've committed your fix, thanks! Sorry for the delay. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73758 
>Unformatted:
