From apeiron@prophecy.dyndns.org  Thu Oct 21 16:54:42 2004
Return-Path: <apeiron@prophecy.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EE00516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 21 Oct 2004 16:54:42 +0000 (GMT)
Received: from prophecy.dyndns.org (pcp08490587pcs.levtwn01.pa.comcast.net [68.83.169.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8DFA443D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 21 Oct 2004 16:54:42 +0000 (GMT)
	(envelope-from apeiron@prophecy.dyndns.org)
Received: from prophecy.dyndns.org (localhost.dyndns.org [127.0.0.1])
	by prophecy.dyndns.org (8.13.1/8.13.1) with ESMTP id i9LGsfjt075377
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 21 Oct 2004 12:54:41 -0400 (EDT)
	(envelope-from apeiron@prophecy.dyndns.org)
Received: (from apeiron@localhost)
	by prophecy.dyndns.org (8.13.1/8.13.1/Submit) id i9LGseF2075376;
	Thu, 21 Oct 2004 12:54:40 -0400 (EDT)
	(envelope-from apeiron)
Message-Id: <200410211654.i9LGseF2075376@prophecy.dyndns.org>
Date: Thu, 21 Oct 2004 12:54:40 -0400 (EDT)
From: Christopher Nehren <apeiron@comcast.net>
Reply-To: Christopher Nehren <apeiron@comcast.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Broken network support in x{mame,mess} partially failing silently
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         72968
>Category:       ports
>Synopsis:       Broken network support in x{mame,mess} partially failing silently
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 21 17:00:14 GMT 2004
>Closed-Date:    Sun Dec 19 17:29:12 GMT 2004
>Last-Modified:  Sun Dec 19 17:29:12 GMT 2004
>Originator:     Christopher Nehren
>Release:        FreeBSD 5.3-BETA7 i386
>Organization:
>Environment:
System: FreeBSD prophecy.dyndns.org 5.3-BETA7 FreeBSD 5.3-BETA7 #0: Sun Oct 10 13:50:39 EDT 2004 root@prophecy.dyndns.org:/usr/src/sys/i386/compile/PROPHECY i386


	
>Description:
As stated http://www.mail-archive.com/xmame@toybox.twisted.org.uk/msg07256.html,
networking support is currently known to be broken in xmame and xmess. The port
will still attempt to build network support, however, which will fail because
the code is broken. Apparently the port maintainer wants the port to continue
building but without networking support, and without notifying the user. This
silent failure can cause much confusion (it did for me and others, at least).
Therefore, I recommend marking the port as BROKEN rather than partially failing
silently. This way a user isn't led to believe -- under false pretenses -- that
their networking should still be working.

Also take note that the port does not properly disable networking support even
if it's enabled.
>How-To-Repeat:
Attempt to build recent xmame/xmess with networking support, notice the broken
code.
>Fix:

--- /usr/ports/emulators/xmame/Makefile	Thu Oct 21 12:49:05 2004
+++ xmame/Makefile	Thu Oct 21 12:48:55 2004
@@ -223,11 +223,8 @@
 #.endif
 
 .if ${WITH_NETWORK:L} != "no"
-NETWORK=
-.else
-NETWORK=\#
+BROKEN=	"Network support is broken in 0.85+"
 .endif
-#.endif
 
 .include <bsd.port.pre.mk>
 
>Release-Note:
>Audit-Trail:

From: Miguel Mendez <flynn@energyhq.es.eu.org>
To: Christopher Nehren <apeiron@comcast.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/72968: Broken network support in x{mame,mess} partially
 failing silently
Date: Fri, 22 Oct 2004 09:17:28 +0200

 --Signature=_Fri__22_Oct_2004_09_17_28_+0200_qdkxa.Xcg=qybAPA
 Content-Type: text/plain; charset=US-ASCII
 Content-Disposition: inline
 Content-Transfer-Encoding: 7bit
 
 On Thu, 21 Oct 2004 12:54:40 -0400 (EDT)
 Christopher Nehren <apeiron@comcast.net> wrote:
 
 Christopher,
 
 It was certainly an omission on my part and I should have added a
 pkg-message warning the user about it. The thing is, your condescending
 tone was uncalled for. I have more important things to worry about than
 having a perfect xmame port (specially considering we've been in ports
 freeze until recently) but, since it seems to be so important to you, be
 my guest and become the new maintainer. That's all I have to say.
 
 Cheers,
 -- 
 	Miguel Mendez <flynn@energyhq.es.eu.org>
 	http://www.energyhq.es.eu.org
 	PGP Key: 0xDC8514F1
 	Note: All HTML and non-english mail goes to /dev/null
 
 --Signature=_Fri__22_Oct_2004_09_17_28_+0200_qdkxa.Xcg=qybAPA
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQFBeLQLnLctrNyFFPERAsY/AJ4rPGrPXE8G/bRjrtFnN6TMSQr5/QCfQ8qm
 JjUrvd8UhcQmk00xTEyl8k8=
 =26OV
 -----END PGP SIGNATURE-----
 
 --Signature=_Fri__22_Oct_2004_09_17_28_+0200_qdkxa.Xcg=qybAPA--

From: Christopher Nehren <apeiron@comcast.net>
To: Miguel Mendez <flynn@energyhq.es.eu.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/72968: Broken network support in x{mame,mess} partially
	failing silently
Date: Fri, 22 Oct 2004 10:44:37 -0400

 --=-sUL5pLsMQlGc1aObXfku
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, 2004-10-22 at 09:17 +0200, Miguel Mendez wrote:
 > It was certainly an omission on my part and I should have added a
 > pkg-message warning the user about it. The thing is, your condescending
 > tone was uncalled for. I have more important things to worry about than
 > having a perfect xmame port (specially considering we've been in ports
 > freeze until recently) but, since it seems to be so important to you, be
 > my guest and become the new maintainer. That's all I have to say.
 
 ... eep. The PR was not meant to be condescending or anything else of
 the sort. I apologise for that. All that I wanted to accomplish was to
 give the people reading the PR an account from my perspective of the
 issue with the port. I definitely couldn't do as good a job as you have
 with maintaining the port.
 
 --=20
 I abhor a system designed for the "user", if that word is a coded
 pejorative meaning "stupid and unsophisticated".  -- Ken Thompson
 -
 Unix is user friendly. However, it isn't idiot friendly.
 
 
 --=-sUL5pLsMQlGc1aObXfku
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQBBeRzVk/lo7zvzJioRAs3RAJ9emxlwbXbSFpNrwvSH4V8OICDbSQCePZSA
 k2JHzddD/i9z484rivJGTLA=
 =nlCv
 -----END PGP SIGNATURE-----
 
 --=-sUL5pLsMQlGc1aObXfku--
 

From: Miguel Mendez <flynn@energyhq.es.eu.org>
To: Christopher Nehren <apeiron@comcast.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/72968: Broken network support in x{mame,mess} partially
 failing silently
Date: Fri, 22 Oct 2004 21:52:03 +0200

 --Signature=_Fri__22_Oct_2004_21_52_03_+0200_DWYwJsUklQb3P12A
 Content-Type: text/plain; charset=US-ASCII
 Content-Disposition: inline
 Content-Transfer-Encoding: 7bit
 
 On Fri, 22 Oct 2004 10:44:37 -0400
 Christopher Nehren <apeiron@comcast.net> wrote:
 
 Hi,
 
 > ... eep. The PR was not meant to be condescending or anything else of
 > the sort. I apologise for that. All that I wanted to accomplish was to
 > give the people reading the PR an account from my perspective of the
 > issue with the port. I definitely couldn't do as good a job as you
 > have with maintaining the port.
 
 Ok, sorry for blowing things out of proportion. This last 2 weeks have
 been specially stressing at work. Let's have this patch comitted and, in
 two weeks when I have some days off I'll work on fully OPTIONS-ifying
 the port. 
 
 Sorry again for the mess. Now time to head to the pub to relax.
 
 -- 
 	Miguel Mendez <flynn@energyhq.es.eu.org>
 	http://www.energyhq.es.eu.org
 	PGP Key: 0xDC8514F1
 	Note: All HTML and non-english mail goes to /dev/null
 
 --Signature=_Fri__22_Oct_2004_21_52_03_+0200_DWYwJsUklQb3P12A
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (FreeBSD)
 
 iD8DBQFBeWTlnLctrNyFFPERAiIlAJ4qDAoYvSnNMjJbOrS10DoYHMKpvACgyKyj
 umvVi2fUoP9V/1os+QI3reU=
 =2sa4
 -----END PGP SIGNATURE-----
 
 --Signature=_Fri__22_Oct_2004_21_52_03_+0200_DWYwJsUklQb3P12A--
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Dec 19 17:28:46 GMT 2004 
State-Changed-Why:  
Maintainer notes that this has been fixed by a later port update. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72968 
>Unformatted:
