From pjd@gauss.point45.net  Tue Oct 12 12:19:37 2004
Return-Path: <pjd@gauss.point45.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 40F4B16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Oct 2004 12:19:37 +0000 (GMT)
Received: from gauss.point45.net (gauss.point45.net [207.150.161.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1A69D43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Oct 2004 12:19:37 +0000 (GMT)
	(envelope-from pjd@gauss.point45.net)
Received: by gauss.point45.net (Postfix, from userid 1002)
	id 86C7E416D; Tue, 12 Oct 2004 12:19:36 +0000 (GMT)
Message-Id: <20041012121936.86C7E416D@gauss.point45.net>
Date: Tue, 12 Oct 2004 12:19:36 +0000 (GMT)
From: Piet Delport <pjd@point45.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [UNBREAK] graphics/agg with CC, CXX
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         72570
>Category:       ports
>Synopsis:       [UNBREAK] graphics/agg with CC, CXX
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 12 12:20:28 GMT 2004
>Closed-Date:    Wed Oct 13 15:44:28 GMT 2004
>Last-Modified:  Wed Oct 13 15:44:28 GMT 2004
>Originator:     Piet Delport
>Release:        
>Organization:
>Environment:
>Description:

Port graphics/agg:
	* does not build when CC contains whitespace.
	* ignores the value of CXX completely.

>How-To-Repeat:

% make
===>   agg-2.1 depends on executable: gmake - found
===>  Configuring for agg-2.1
===>  Building for agg-2.1
cc: SHELL=/bin/sh: No such file or directory
cc: PORTOBJFORMAT=elf: No such file or directory
cc: PREFIX=/usr/local: No such file or directory
cc: LOCALBASE=/usr/local: No such file or directory
cc: X11BASE=/usr/X11R6: No such file or directory
cc: MOTIFLIB=-L/usr/X11R6/lib -lXm -lXp: No such file or directory
cc: LIBDIR=/usr/lib: No such file or directory
cc: CFLAGS=-O -pipe -march=pentiumpro: No such file or directory
cc: CXXFLAGS= -O -pipe -march=pentiumpro: No such file or directory
cc: MANPREFIX=/usr/local: No such file or directory
cc: BSD_INSTALL_PROGRAM=install -c -s  -m 555: No such file or directory
cc: BSD_INSTALL_SCRIPT=install -c  -m 555: No such file or directory
cc: BSD_INSTALL_DATA=install -c  -m 444: No such file or directory
cc: BSD_INSTALL_MAN=install -c  -m 444: No such file or directory
cc: gmake: No such file or directory
cc: all: No such file or directory
cc: No input files specified
*** Error code 1

Stop in /usr/home/pjd/work/ports/agg.
%

>Fix:

--- agg.patch begins here ---
diff -u /usr/ports/graphics/agg/Makefile agg/Makefile
--- /usr/ports/graphics/agg/Makefile	Tue Oct 12 13:03:23 2004
+++ agg/Makefile	Tue Oct 12 13:13:35 2004
@@ -18,7 +18,6 @@
 
 WRKSRC=		${WRKDIR}/agg2
 USE_GMAKE=	yes
-MAKE_ENV=	C=${CC}
 
 PLIST_FILES=	lib/libagg.a
 
@@ -29,7 +28,7 @@
 	@${SED} 's,%%X11BASE%%,${X11BASE},g' < ${FILESDIR}/Makefile.in.FreeBSD > ${WRKSRC}/Makefile.in.FreeBSD
 
 do-build:
-	@cd ${WRKSRC}/src && ${SETENV} ${MAKE_ENV} ${GMAKE} all && ranlib libagg.a
+	@cd ${WRKSRC}/src && ${SETENV} C="${CC}" CXX="${CXX}" ${GMAKE} all && ranlib libagg.a
 
 do-install:
 	${INSTALL_DATA} ${WRKSRC}/src/libagg.a ${PREFIX}/lib
--- agg.patch ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Wed Oct 13 15:44:10 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

I used a slightly less disruptive variation on your patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72570 
>Unformatted:
