From nobody@FreeBSD.org  Mon Sep 27 22:09:23 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D1BC616A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Sep 2004 22:09:23 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C571043D39
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Sep 2004 22:09:23 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i8RM9L5Q088111
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Sep 2004 22:09:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i8RM9LWK088110;
	Mon, 27 Sep 2004 22:09:21 GMT
	(envelope-from nobody)
Message-Id: <200409272209.i8RM9LWK088110@www.freebsd.org>
Date: Mon, 27 Sep 2004 22:09:21 GMT
From: Michel Lavondes <fox@vader.aacc.cc.md.us>
To: freebsd-gnats-submit@FreeBSD.org
Subject: make clean crashes in x11/nvidia-driver too.
X-Send-Pr-Version: www-2.3

>Number:         72137
>Category:       ports
>Synopsis:       make clean crashes in x11/nvidia-driver
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    danfe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 27 22:10:36 GMT 2004
>Closed-Date:    Tue Nov 09 09:45:02 GMT 2004
>Last-Modified:  Tue Nov 09 09:45:02 GMT 2004
>Originator:     Michel Lavondes
>Release:        4.8-RELEASE-p25
>Organization:
Ecdysiasts United for Overdressing
>Environment:
>Description:
# cd /usr/ports/x11/nvidia-driver; make clean
"Makefile", line 44: warning: String comparison operator should be either == or !=
"Makefile", line 44: Malformed conditional (${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001))
"Makefile", line 44: Missing dependency operator
"Makefile", line 46: if-less endif
"Makefile", line 46: Need an operator
make: fatal errors encountered -- cannot continue

Note: this is a near-duplicate of ports/72118, http://www.freebsd.org/cgi/query-pr.cgi?pr=72118


>How-To-Repeat:
See above "Full Description"
>Fix:
Change line 44 of Makefile from:

.if ${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001)

to

.if ${OSVERSION} < 490000 || ${OSVERSION} >= 500000 && ${OSVERSION} < 502001

Note: make(1) states that && has higher precedence than ||, so the () shouldn't be necessary. Just to be on the safe side (I don't have the resources to test on other FreeBSD versions), I checked my fix with: 

# make -V OSVERSION
480000
# make -V IGNORE
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=489999
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=490000

# make -V IGNORE OSVERSION=499999

# make -V IGNORE OSVERSION=500000
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=502000
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# 

I hope I didn't overlook anything.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->danfe 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Sep 28 03:20:32 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer. 

I sure will be glad when everyone has that newer make(1) ... 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72137 
State-Changed-From-To: open->closed 
State-Changed-By: danfe 
State-Changed-When: Tue Nov 9 09:44:33 GMT 2004 
State-Changed-Why:  
Fixed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=72137 
>Unformatted:
