From domi@dominik.saargate.de  Sun Sep 12 17:28:43 2004
Return-Path: <domi@dominik.saargate.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 83C2316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:28:43 +0000 (GMT)
Received: from jail.teresto.net (jail.teresto.net [212.88.134.36])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3E28143D39
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 17:28:43 +0000 (GMT)
	(envelope-from domi@dominik.saargate.de)
Received: from srlo-d9b99a47.pool.mediaways.net ([217.185.154.71] helo=dominik.saargate.de)
	by jail.teresto.net with esmtp (Exim 4.42 (FreeBSD))
	id 1C6XBM-000IIw-84
	for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 18:26:28 +0200
Received: from dominik.saargate.de (localhost [127.0.0.1])
	by dominik.saargate.de (8.12.9/8.12.9) with ESMTP id i8CHSfYd087034
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 12 Sep 2004 19:28:41 +0200 (CEST)
	(envelope-from domi@dominik.saargate.de)
Received: (from domi@localhost)
	by dominik.saargate.de (8.12.9/8.12.9/Submit) id i8CHSfNq087033;
	Sun, 12 Sep 2004 19:28:41 +0200 (CEST)
Message-Id: <200409121728.i8CHSfNq087033@dominik.saargate.de>
Date: Sun, 12 Sep 2004 19:28:41 +0200 (CEST)
From: Dominik Brettnacher <domi@saargate.de>
Reply-To: Dominik Brettnacher <domi@saargate.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: graphics/xsane update 0.93 -> 0.97
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71658
>Category:       ports
>Synopsis:       graphics/xsane update 0.93 -> 0.97
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 17:30:26 GMT 2004
>Closed-Date:    Fri Oct 29 16:51:18 GMT 2004
>Last-Modified:  Fri Oct 29 16:51:18 GMT 2004
>Originator:     Dominik Brettnacher
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD dominik.saargate.de 4.8-STABLE FreeBSD 4.8-STABLE #20: Thu May 1 21:02:19 CEST 2003 domi@dominik.saargate.de:/usr/src/sys/compile/DOMINIK i386


>Description:
>How-To-Repeat:
>Fix:

diff -urN /usr/ports/graphics/xsane/Makefile xsane/Makefile
--- /usr/ports/graphics/xsane/Makefile	Thu Jul  1 21:41:27 2004
+++ xsane/Makefile	Sun Sep 12 19:05:12 2004
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	xsane
-PORTVERSION=	0.93
+PORTVERSION=	0.96
 CATEGORIES=	graphics
 MASTER_SITES=	http://www.xsane.org/download/ \
 		http://gd.tuwien.ac.at/hci/sane/xsane/ \
diff -urN /usr/ports/graphics/xsane/distinfo xsane/distinfo
--- /usr/ports/graphics/xsane/distinfo	Thu Jul  1 21:41:27 2004
+++ xsane/distinfo	Sun Sep 12 19:13:20 2004
@@ -1,2 +1,2 @@
-MD5 (xsane-0.93.tar.gz) = ff775bc264b81b2a3e8fafbcef0181c0
-SIZE (xsane-0.93.tar.gz) = 2755529
+MD5 (xsane-0.96.tar.gz) = 32e4693c207d0380436c76096f8c157c
+SIZE (xsane-0.96.tar.gz) = 3173665
diff -urN /usr/ports/graphics/xsane/pkg-plist xsane/pkg-plist
--- /usr/ports/graphics/xsane/pkg-plist	Thu Jul  1 21:41:27 2004
+++ xsane/pkg-plist	Sun Sep 12 19:18:46 2004
@@ -35,7 +35,7 @@
 share/sane/xsane/doc/sane-xsane-gimp-doc.html
 share/sane/xsane/doc/sane-xsane-histogram-doc.html
 share/sane/xsane/doc/sane-xsane-mail-doc.html
-share/sane/xsane/doc/sane-xsane-main-doc.html
+share/sane/xsane/doc/sane-xsane-medium-definition-doc.html
 share/sane/xsane/doc/sane-xsane-preview-doc.html
 share/sane/xsane/doc/sane-xsane-save-doc.html
 share/sane/xsane/doc/sane-xsane-setup-copy-doc.html
@@ -65,6 +65,7 @@
 share/sane/xsane/doc/xsane-delete-preview-cache.jpg
 share/sane/xsane/doc/xsane-despeckle.jpg
 share/sane/xsane/doc/xsane-disk.jpg
+share/sane/xsane/doc/xsane-edit-medium.jpg
 share/sane/xsane/doc/xsane-fax-project.jpg
 share/sane/xsane/doc/xsane-fax.jpg
 share/sane/xsane/doc/xsane-gamma.jpg
@@ -74,6 +75,7 @@
 share/sane/xsane/doc/xsane-mail-project.jpg
 share/sane/xsane/doc/xsane-mail.jpg
 share/sane/xsane/doc/xsane-medium.jpg
+share/sane/xsane/doc/xsane-medium-add.jpg
 share/sane/xsane/doc/xsane-mirror-x.jpg
 share/sane/xsane/doc/xsane-mirror-y.jpg
 share/sane/xsane/doc/xsane-negative.jpg
@@ -95,6 +97,7 @@
 share/sane/xsane/doc/xsane-pipette-white.jpg
 share/sane/xsane/doc/xsane-preferences.jpg
 share/sane/xsane/doc/xsane-preset-area.jpg
+share/sane/xsane/doc/xsane-preset-area-context-menu.jpg
 share/sane/xsane/doc/xsane-preview.jpg
 share/sane/xsane/doc/xsane-printer.jpg
 share/sane/xsane/doc/xsane-rename.jpg
@@ -129,7 +132,6 @@
 share/sane/xsane/doc/xsane-zoom-out.jpg
 share/sane/xsane/doc/xsane-zoom-undo.jpg
 share/sane/xsane/doc/xsane-zoom.jpg
-share/sane/xsane/doc/xsane.jpg
 share/sane/xsane/sane-epson-logo.xpm
 share/sane/xsane/sane-hp-logo.xpm
 share/sane/xsane/sane-umax-logo.xpm
>Release-Note:
>Audit-Trail:

From: Sean Farley <sean-freebsd@farley.org>
To: freebsd-gnats-submit@FreeBSD.org, domi@saargate.de
Cc:  
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Tue, 14 Sep 2004 08:53:45 -0500 (CDT)

 I had just updated this port.  Next time, I will check if someone else
 has updated a port first.  :)
 
 I do have one addition to this patch.  The share/sane directory is
 created by xsane as well as sane-backends.  Maybe the following line
 should be added to the end of xsane anyway?
 
 @unexec rmdir %D/share/sane 2> /dev/null || true

From: Sean Farley <sean-freebsd@farley.org>
To: freebsd-gnats-submit@FreeBSD.org, domi@saargate.de
Cc:  
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Tue, 14 Sep 2004 09:35:07 -0500 (CDT)

 One last addition.  FreeBSD 4 should use GCC 3.3 (or maybe 3.2) to
 compile.  xsane tickles an optimization bug in GCC 2.95.4 which causes
 color previews to crash xsane.
 
 The Preview struct claims the width is over 100000 for an image that is
 actually about 500.  Compiling with GCC 3.3.5 fixed it.
 
 Line to add to Makefile:
 USE_GCC=	3.3
 
 I am not sure how this affects FreeBSD 5.
 
 Sean
 -----------------------
 sean-freebsd@farley.org

From: Dominik Brettnacher <domi@saargate.de>
To: Sean Farley <sean-freebsd@farley.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Thu, 16 Sep 2004 10:00:27 +0200 (CEST)

 On Tue, 14 Sep 2004, Sean Farley wrote:
 
 > One last addition.  FreeBSD 4 should use GCC 3.3 (or maybe 3.2) to
 > compile.  xsane tickles an optimization bug in GCC 2.95.4 which causes
 > color previews to crash xsane.
 
 I'd hesitate to depend on a newer GCC version.
 
 As far as I know, the bug also disappears if you try different compiler
 options (e.g. CFLAGS=-g).
 
 YMMV.
 
 -- 
 Yours,
 
 Dominik

From: Sean Farley <sean-freebsd@farley.org>
To: Dominik Brettnacher <domi@saargate.de>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Sat, 18 Sep 2004 10:14:04 -0500 (CDT)

 On Thu, 16 Sep 2004, Dominik Brettnacher wrote:
 
 > On Tue, 14 Sep 2004, Sean Farley wrote:
 >
 >> One last addition.  FreeBSD 4 should use GCC 3.3 (or maybe 3.2) to
 >> compile.  xsane tickles an optimization bug in GCC 2.95.4 which
 >> causes color previews to crash xsane.
 >
 > I'd hesitate to depend on a newer GCC version.
 >
 > As far as I know, the bug also disappears if you try different
 > compiler options (e.g. CFLAGS=-g).
 
 That is what I have read.  Removing the -O should work around the
 optimization bug.  Possibilities:
 1. Use newer GCC.  I tested with GCC v3.3.5.  This idea suffers from
     having to install another GCC.
 2. Prevent '-O' from being used.  The only problem is that the Makefile
     has to prevent -O from being in CFLAGS (even user-defined in
     make.conf) at least for the funciton in question
     (preview_autoselect_scanarea()/xsane-preview.c).  According to this
     post, the -g flag is not necessary; only removing -O is needed.
 
     http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&selm=b0clss%242nq%241%40newsreader2.netcologne.de
 
 Sean
 -----------------------
 sean-freebsd@farley.org

From: Oliver Lehmann <oliver@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: domi@saargate.de, sean-freebsd@farley.org
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Tue, 26 Oct 2004 21:00:03 +0200

 Hi,
 
 I'm wondering, how it's possible to reproduce the crash? I've tried
 several (color) previews and (color) scans with my old AGFA SnapScan 310,
 but got no crash @FreeBSD 4.10. I've even tried acquiring a preview of an
 image which started dark, and ended up in a light white. That made all
 prior versions (up to 0.92 - no newer versions tried) coredump. Now it
 works.
 
 Anyway, with that change, it should be possible, to strike out -O:
 
 .if ${OSVERSION} < 500035
 CONFIGURE_ENV+=	CFLAGS="${CFLAGS:C/-O[0-9]*//g}"
 .endif
 
 Dominik:
 Is it ok for you to commit with that change? (So no new compiler would NOT
 be needed for FreeBSD 4)
 
 But, I would like to know how to reproduce the crash first!
 
 
   Greetings
 
 -- 
  Oliver Lehmann
   http://www.pofo.de/
   http://wishlist.ans-netz.de/

From: Sean Farley <sean-freebsd@farley.org>
To: Oliver Lehmann <oliver@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, domi@saargate.de
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Tue, 26 Oct 2004 18:31:06 -0500 (CDT)

 On Tue, 26 Oct 2004, Oliver Lehmann wrote:
 
 > Hi,
 >
 > I'm wondering, how it's possible to reproduce the crash? I've tried
 > several (color) previews and (color) scans with my old AGFA SnapScan
 > 310, but got no crash @FreeBSD 4.10. I've even tried acquiring a
 > preview of an image which started dark, and ended up in a light white.
 > That made all prior versions (up to 0.92 - no newer versions tried)
 > coredump. Now it works.
 
 From the URL I posted and what I use for a scanner, it looks like Epson
 1200U scanners are related.
 
 Sean
 -- 
 sean-freebsd@farley.org

From: Dominik Brettnacher <domi@saargate.de>
To: Oliver Lehmann <oliver@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, sean-freebsd@farley.org
Subject: Re: ports/71658: graphics/xsane update 0.93 -> 0.97
Date: Fri, 29 Oct 2004 11:54:50 +0200 (CEST)

 On Tue, 26 Oct 2004, Oliver Lehmann wrote:
 
 > I'm wondering, how it's possible to reproduce the crash? I've tried
 > several (color) previews and (color) scans with my old AGFA SnapScan 310,
 > but got no crash @FreeBSD 4.10. I've even tried acquiring a preview of an
 > image which started dark, and ended up in a light white. That made all
 > prior versions (up to 0.92 - no newer versions tried) coredump. Now it
 > works.
 
 I think it is the nature of bugs like these that they aren't easy to
 reproduce - after all it seems to be a compiler bug.
 
 > Anyway, with that change, it should be possible, to strike out -O:
 >
 > .if ${OSVERSION} < 500035
 > CONFIGURE_ENV+=	CFLAGS="${CFLAGS:C/-O[0-9]*//g}"
 > .endif
 >
 > Dominik:
 > Is it ok for you to commit with that change? (So no new compiler would NOT
 > be needed for FreeBSD 4)
 
 I'm fine with it. Could you create a patch against the current xsane
 port, so that one of the committers could apply it?
 
 At the moment, I am spending a few months abroad without a FreeBSD machine
 at hand. Therefore I would be very glad if you could do me that favor.
 
 
 -- 
 Regards,
 
 Dominik
State-Changed-From-To: open->closed 
State-Changed-By: oliver 
State-Changed-When: Fri Oct 29 16:51:04 GMT 2004 
State-Changed-Why:  
Committed, Thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71658 
>Unformatted:
