From jh@pc-21490.bc.rogers.wave.ca  Sat Jul  4 14:08:57 1998
Received: from pc-21490.bc.rogers.wave.ca (pc-21490.bc.rogers.wave.ca [24.113.51.240])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA14533
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 4 Jul 1998 14:08:56 -0700 (PDT)
          (envelope-from jh@pc-21490.bc.rogers.wave.ca)
Received: (from jh@localhost)
	by pc-21490.bc.rogers.wave.ca (8.8.8/8.8.7) id OAA05709;
	Sat, 4 Jul 1998 14:08:27 -0700 (PDT)
Message-Id: <199807042108.OAA05709@pc-21490.bc.rogers.wave.ca>
Date: Sat, 4 Jul 1998 14:08:27 -0700 (PDT)
From: Jonathan Hanna <jh@pc-21490.bc.rogers.wave.ca>
Reply-To: pangolin@rogers.wave.ca
To: FreeBSD-gnats-submit@freebsd.org
Subject: xsysinfo does not report interrupt state (with patch)
X-Send-Pr-Version: 3.2

>Number:         7160
>Category:       ports
>Synopsis:       xsysinfo does not report interrupt state (with patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul  4 14:10:00 PDT 1998
>Closed-Date:    Sun Jul 12 15:43:34 PDT 1998
>Last-Modified:  Sun Jul 12 15:45:07 PDT 1998
>Originator:     Jonathan Hanna
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	

>Description:

xsysinfo neglects to display the interrupt cpu state.

>How-To-Repeat:

>Fix:

Somewhat against POLA in that Nice has changed to green and
yellow is now Interrupt. I find green nicer than yellow.

diff -c -r -N xsysinfo/patches/patch-ab xsysinfo.new/patches/patch-ab
*** xsysinfo/patches/patch-ab	Wed Dec 31 16:00:00 1969
--- xsysinfo.new/patches/patch-ab	Sat Jul  4 13:48:36 1998
***************
*** 0 ****
--- 1,20 ----
+ *** sysinfo.c.old	Sat Jul  4 13:35:51 1998
+ --- sysinfo.c	Sat Jul  4 13:36:23 1998
+ ***************
+ *** 220,226 ****
+   	    states[i] = 0;
+   	getkval(nl[X_CP_TIME].n_value, (int *)cp_time, sizeof(cp_time), "_cp_time");
+   	states[1] = delta(CP_SYS);
+ ! 	states[4] = delta(CP_NICE);
+   	states[8] = delta(CP_USER);
+   	states[9] = delta(CP_IDLE);
+   	draw_bar(cpuflag-1, states, 10);
+ --- 220,227 ----
+   	    states[i] = 0;
+   	getkval(nl[X_CP_TIME].n_value, (int *)cp_time, sizeof(cp_time), "_cp_time");
+   	states[1] = delta(CP_SYS);
+ ! 	states[4] = delta(CP_INTR);
+ ! 	states[7] = delta(CP_NICE);
+   	states[8] = delta(CP_USER);
+   	states[9] = delta(CP_IDLE);
+   	draw_bar(cpuflag-1, states, 10);
diff -c -r -N xsysinfo/patches/patch-ac xsysinfo.new/patches/patch-ac
*** xsysinfo/patches/patch-ac	Wed Dec 31 16:00:00 1969
--- xsysinfo.new/patches/patch-ac	Sat Jul  4 13:49:01 1998
***************
*** 0 ****
--- 1,19 ----
+ *** xsysinfo.man.old	Sat Jul  4 13:37:09 1998
+ --- xsysinfo.man	Sat Jul  4 13:37:47 1998
+ ***************
+ *** 14,20 ****
+   displays bars showing the percentage of system statistics :
+   .PP
+   CPU : The time of the CPU spends in different states. The colors mean :
+ ! Red:system,  Yellow:Nice,  Blue:User.
+   .PP
+   Load: The load of the system, each scale (color) means load 1.  Multi-colors
+   based on the load.
+ --- 14,20 ----
+   displays bars showing the percentage of system statistics :
+   .PP
+   CPU : The time of the CPU spends in different states. The colors mean :
+ ! Red:system,  Yellow:Interrupt,  Green:Nice, Blue:User.
+   .PP
+   Load: The load of the system, each scale (color) means load 1.  Multi-colors
+   based on the load.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Sun Jul 12 15:43:34 PDT 1998 
State-Changed-Why:  
Suggested patches applied, thanks! 
>Unformatted:
